From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBC3C3600C for ; Thu, 3 Apr 2025 03:53:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB795280004; Wed, 2 Apr 2025 23:53:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E64E1280001; Wed, 2 Apr 2025 23:53:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D52AF280004; Wed, 2 Apr 2025 23:53:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B44A8280001 for ; Wed, 2 Apr 2025 23:53:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C197C81254 for ; Thu, 3 Apr 2025 03:53:40 +0000 (UTC) X-FDA: 83291363400.02.314730C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 07B1380004 for ; Thu, 3 Apr 2025 03:53:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZXf9CJuv; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743652419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j98rwQL7G8di/BtMjoHWfEqONBrRzM9ADm8HabBJsPs=; b=66V9+htLat1rU3Mu/T0fN6wCGiaJ/odoe/YIzzya57s5UXEHAABBHfIusBo5iVLqn/CCpu wOCZnjbBFaMb/3AOkrvgZcFdFNH5ZNtuMe1TRv/37yhOXNn6QSlLBtdVj6aBFL8NIwJ04K 63oKQTvlvtdad7wCu3iSD9V6EhwbWR4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZXf9CJuv; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743652419; a=rsa-sha256; cv=none; b=53zr83en/On4F2fHhgGMHlNP+0PBYiVAW4CR4QBGZvrX1Gz72+9L1j4e8KFHxCpilHae7j JjR1fs+fxarKYTidkrHhudrsSLOIIiSl5kCLOI0rZUXxwaLhZRtIuPCGUFjsdXovuozar8 /Wbcw45o/CTXL/nLz5G5ehP7N02j+8o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j98rwQL7G8di/BtMjoHWfEqONBrRzM9ADm8HabBJsPs=; b=ZXf9CJuvoUH/YE50tXTG4O7y7B rgnnIdzHH4ih+uy9q+Zxo+7Bycoq/fP9k7VVNa89ePhRcOL6u3/fY/0qMnMssb+xaTLwHZgMR7e6h tEzEDVFicwQVGYeucAIE2BgpVdl/BcTayDpYZYejpY4HgBrrT/PLkoS3ED4PbzhupuG8PrkfYXJxG 7IH30YgiWnEqITe6xTrx6b6fNflMNeHp3uBRsfLxd/7u+hcQ/gFnxD/lZp8k53eAf42bm51EDsrgf Cj88ngx2F139E/LMxJ4YlS1/vMQZ8WWC9AE52UurF+GhIU1CZvYHdkahDQNrcfyee89PBN7aPll4k qY+38SkQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0Be4-0000000Aw2v-1G9j; Thu, 03 Apr 2025 03:53:36 +0000 Date: Thu, 3 Apr 2025 04:53:36 +0100 From: Matthew Wilcox To: Dominique Martinet Cc: linux-fsdevel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, stable@vger.kernel.org, David Howells , v9fs@lists.linux.dev Subject: Re: [PATCH v2 1/9] 9p: Add a migrate_folio method Message-ID: References: <20250402150005.2309458-1-willy@infradead.org> <20250402150005.2309458-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 07B1380004 X-Stat-Signature: 8tchmahf1gyexsqf4xjhpcesq3iqqszb X-HE-Tag: 1743652418-296851 X-HE-Meta: U2FsdGVkX18w1/ldgkTTKsAyMOz295FxYj1vNBKdh3YHzhEevz4UPvX2yiH5gKwVLr50bo5t3oCesTarqHoCohfOm6AVDCn+RybVPcmkgsPW4joNEuyXZDO3AOPnWTStDOWua88J+pDmvX2oUHbVLxtcToJ0Odn8IgLRkesuqzcVpHr62vayjtIJu14NPtU+lJXnB1cSBFvDCv1nWxetF2Yd09csJpsZzT28zOOr5czWs08i86DVntas7IKqy92HQU/wRRfcn5YFVnDnlGYfnHumgsKuTU1235xiNII/gQqB8uRlCumhVUsLZDP9ei/Vja9s9BUov6A1JY1VTqZwi5QaFHGYsnrEYEoCuZwKdYE8oWGwVqcqo3yCwDDWBdSQEF+0dF3O3+WR4y6DMZFTenqZEd9tiAvfQCgXz1Xfqj86AENQkprRFBdxuvyMRqbqn+/GamLijRz4fwt4Z4CjsguokOHFfTyyYCyOVXREBsIhOmgyh4Ae1nUa0jFJTmOtN3v5e9O/ZleYOAubFLU90C7tvnsocI0J3gCJsFmTVdI2uFIMV6u99YNOTNW0JI26Q7c3tMkfV1vQ7xFL+rtU6xQxV8l2CkPG3OX5HvdUPnEQ4HFwR/X05I6kJjTvjhO1FDH/2jsuciKqZsgJWgqbdvgGvxyuRraNCuYUs4StaePxmM/ieUCneV3K6rUWjUHHKPr8RvBlW8B4QFNHMOST+hBezUU0xnS8n0vfNmjPpN7JHXbcCwoA/prseiY0chqE/+EPd7gS0P1gs9SX2QLj+p2r0Bu+5klPYWdE6k1IGHKrAyTFVcTDB+Ihcv0d/FnDB/RXoyt5/c83sFVuiRP8XbqIDcawPSac78WpTtbxxEyELRqB75u65oPJtJ8NR5WVOC0dLyDIwFCbWvDRVTsPJNwf5Lr4g7S8L/KCZHBv1zPjzOQvLZW+mrgoTIagfJMs6zrp3ORVp9s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 03, 2025 at 12:46:17PM +0900, Dominique Martinet wrote: > Matthew Wilcox (Oracle) wrote on Wed, Apr 02, 2025 at 03:59:55PM +0100: > > The migration code used to be able to migrate dirty 9p folios by writing > > them back using writepage. When the writepage method was removed, > > we neglected to add a migrate_folio method, which means that dirty 9p > > folios have been unmovable ever since. This reduced our success at > > defragmenting memory on machines which use 9p heavily. > > Given I'm not in Cc of the whole series I'm lacking context but I assume > that means I'm not supposed to take this in. Right; I'm routing this whole series via Christian. There's various bits of the VFS that need to be touched as part of this series, and it'd take forever to get it all merged by going through individual maintainer trees. > I won't pretend I understand folios anyway, but commit messages makes > sense to me: > Acked-by: Dominique Martinet Thanks! Folios aren't really that hard a concept for a filesystem developer to understand, but dhowells has done a great job of insulating you from even having to understand them with netfs. All they are is a container of one-or-more pages which maintain all the filesystem state which used to be managed per-page. eg dirty, writeback, locked, offset-in-file, number-of-mappings. There's more to it from a MM point of view, but as a filesystem developer, that's all you really need to understand.