From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15831C3600C for ; Thu, 3 Apr 2025 07:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63D66280004; Thu, 3 Apr 2025 03:45:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EC9A280001; Thu, 3 Apr 2025 03:45:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48E88280004; Thu, 3 Apr 2025 03:45:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 29F8F280001 for ; Thu, 3 Apr 2025 03:45:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EFB6B585E6 for ; Thu, 3 Apr 2025 07:45:43 +0000 (UTC) X-FDA: 83291948166.04.ED9C2C8 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf13.hostedemail.com (Postfix) with ESMTP id F02D420009 for ; Thu, 3 Apr 2025 07:45:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZRIKapfK; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743666342; a=rsa-sha256; cv=none; b=EeUjtyEOygY6o3yOaxkJf/h0XkZxD5vl0yXq68MruQmxyq9EVxeXlMMPgFLMPRhYygpmiC UZvFAkeaMT/ouUqCz8IOYEIahMVY50VpwcGA+kHFAqHKBhd0s40+FJgouZLhbqytN2sAar XeuH+wGqUPR2ZaSyHv8ow6cQMXr3Txc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZRIKapfK; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743666342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5VAk2UK6ZWJVQD+p+NwG0TWAjSp74Ywmjjho6zwF9q0=; b=TiBrlM6bNBZXfEIwqu5wenkjAy7QU4/zOov3tyK24F7RC+0+EVHZ4Bn7d7mTOS42Qd1EOl VD44rVf7Tk/HUng2bo3kkvVgNpdA6deF0rkgwDk1V/vDcVJ6JSUIG18/Yo5esh170mp9PP mTEzAc0lBdqwTyJ30lbOH1DVhnz4rLc= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-39129fc51f8so488335f8f.0 for ; Thu, 03 Apr 2025 00:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1743666340; x=1744271140; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5VAk2UK6ZWJVQD+p+NwG0TWAjSp74Ywmjjho6zwF9q0=; b=ZRIKapfKz232SB9ASBsCjI1tkjW9Iyfx6nUrCgpdAmPnpeHURoTeggdZoaO3H0W33F ZFfQ1jDXuDjmvxY8wGTwB9LyyJ/f3D/BRbmF7Bdewe7ba4GnTeGTCi750fMKGvuyGHy3 HBuKZki4GrpSJzPV4jcT2uX+s95t7CS6BEIELc2Q/rKE029VzhPIhxOOs3Q78fTGOJb1 Lm0tJsqRvoRArcoQ2zXjuKzwhnEbuqk1uuIjj0u+dsG77+23PUs1XyNH9WwAPBH7Dz5i sFqT5l7fpHnObOezm+IywLAB5y0XVCbp2RauiKX/Ji5P8ntnUCw0f9KjW8NL3nEDDo7H bQwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743666340; x=1744271140; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5VAk2UK6ZWJVQD+p+NwG0TWAjSp74Ywmjjho6zwF9q0=; b=crxgQWjIzNUuArnVb7TzR9RyCZl4lk6rJIEXx1weTMVYnBiRXMt4FpAQ4V8JdewMGy do9zx/f4EO3Uc5nViPbQuatzIGw1CIXLas6NhPIublrYnpFduBPeNpnpMCIcT7ZEcZ7w M7p5TU8FUHl0+nlU6DKrxLvusYNIRnHlu6RRTc/j3W64A0T61653dX+c/pjetdJ1ZNCY 0rv27XihrZrAq9gbtaIBK8Dr/2Cf6MrOIj0hX6n1RpjJ6x3PMQeGuJazjKgGpH+Rnkjy H1m8quQBU9PGX1K1K0CNbdnUNa8LuJIzAbuaoHK2XUx0nPP52S5zZJiRXYgi+SsjziWo wX+g== X-Forwarded-Encrypted: i=1; AJvYcCUgBsYM6OSSlBnv+yqpHyVqfWT3v4JnSeDwKVH6j4FaaocdvM41MOkBXWkkwEZqswCVnuRHdSvRAw==@kvack.org X-Gm-Message-State: AOJu0Yx2/PDFszM6ioAMA1ufiKB4+/zKPHGrGvvI81Zk++ZT8f1yx6Dk HzdMbDG8FxWm7WqZ8cskbqCu++VZTY0nlNeCrlwBjnK95zrMnhAB0GEoEXobb4Nn3CIOhQYoirs s X-Gm-Gg: ASbGncsDMtuPb3leAUZnnFnAGucrEGSzPxRQiSZm4Imce0W8DzqV5Xny7wKolUzetx5 e2owfuOPCSB1mjK3dFYULfWV7a3+Q0z0+tCAEjmgKMoMxgUemZ9W59WCYg0dupBkX0x4hVUohVx vhMUJ3shDB7BRm8LQvVM6t/AZJblpw3iJxVXd9S/whH6O9wCinPkEomoVd8FkE1la+i44VRBD77 xf8LSU1M2v+ASDVU4btEim1BnWkvkV1C2RfHD12ner43to/P94Kam4sZ7aRAlDGNhOubpMbEfHB OoEKd4+cmiGbfk+6KhVTnvF6dzze9Au3RutoCOHzLPeuaSVswihsy6I= X-Google-Smtp-Source: AGHT+IFVtsVP5aa9ArTL0eTRZ7z7nYosq4DIG82dzzri9OCIBx4/ZOUO1Sez8TySKMOSMj7BQjQj8A== X-Received: by 2002:a05:6000:1789:b0:39c:cc7:3c62 with SMTP id ffacd0b85a97d-39c1211b6edmr16117808f8f.51.1743666340279; Thu, 03 Apr 2025 00:45:40 -0700 (PDT) Received: from localhost (109-81-82-69.rct.o2.cz. [109.81.82.69]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39c301a79aasm1048844f8f.35.2025.04.03.00.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 00:45:39 -0700 (PDT) Date: Thu, 3 Apr 2025 09:45:38 +0200 From: Michal Hocko To: Shakeel Butt Cc: Andrew Morton , Uladzislau Rezki , Johannes Weiner , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: vmalloc: simplify MEMCG_VMALLOC updates Message-ID: References: <20250403053326.26860-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250403053326.26860-1-shakeel.butt@linux.dev> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F02D420009 X-Stat-Signature: xm4pqwysexc5szci3nhx115obgb8pewn X-Rspam-User: X-HE-Tag: 1743666341-489076 X-HE-Meta: U2FsdGVkX1/8xuuXVhLODOywyTWNo+AmRyHjT9V+hCL3uZDlJTp9YgO4tPOEiskKWFlhZcGkAjDoEdupUjAzPiBtqN1meaOViJ/QBmt5oDP8tE2IyO14YdZSsnR/Ff4Y5USjkqL7b9LpppEFimHzniJ7ZXRqLVsZkVT5Bj094LlzYUw43oUkLsUii9sF7fsO3Qo40bFbj5FXr8yjpvDXgHTpCpfF3d+SdOFqQdkB3zfPjnWCVYbB2mS8RiBY6toi5goVL6H/YGx3PykxFirMYEdpXPzDWTFcDPq2s0GMEpR+pWlOM0yy+qCLYjZMVkRnCIpVoFUQB9ytdDNiT14Ztr28y7hDWjIdWSjnl7l8s2p+BFqvK58nre8calLrS5tKSaYnfontK7r6JpbofT8ZEMqdGEEHkWbNJR74Aq+sXZ9ecPJ5z/ieR1rNugndX/VvWXtH/ifdtSxiF3Pqx6bguLkQz6h+ghQvFzJEX1xjxsJUKkoA5a3NACzZuoX9lmiuJzXUs3tWpTCNQVbgSD+U0Q4b2oUlColsxbe6XDxkZDBRdEZs2s4sYzpSxApOsdfowe02C1Ir6aDETV49jNvs+pi3daOiPYOcH5hVJ5X72SbhzqUyGL0QtVDE3B4pKV7ESppC6RnohA1dDjkU4FCNKHVAqeUkGly0FDyzhnAHUEfT01i0PS97ISMLvJEVzkf02GlMWLEVvNOmm0ncqYejo/XSw/WMa7C0ZV4DMMcqzOMJvD6FIgyOQ7Hy1/yZgLdNBztBQrZpPxENqj0Q5tXRsalnOBWwV0rZfXQ9Wa8Uk/tvlfS5tgyIDZpeTRkXvk4HAs0qwRkewywCmiLQbhoPNVQ+x3SozRa9I+d+JISbMNh3N68XktVR+srbaISgWSD78LqGdgVAYU97iwiM4NSHeGt8+t8UojNpsu1oJ0mCMoQmDrfO3M+0Ts3L0WxYxR8tkZot7e16uKnDgViqfT2 b58bIN9k UbpxLkDIaC48DZvGaZEI8IhDM0FsWXd6Mxyy07L/pdO9xclTX5ZSeYzDPRmbKwi6wNjPFuJ3V9UcUu21nGh7d+RBSrJgP5YOCoHLLKaTQ0/jdI7HDTHB5acveCfR6uOd0wUdKXlCbf7sgx+lRoKT1PC45A3o7hp5mFrpz65fhJAkGjSwIK+e1JW66SYOjgX1xNK1k982829WjofCtW1Ft+6++WCGPPIdXzmoJDBk7fYi8kdxIsoft5hPhLtknom2+XJEUBtTrew3hNaUYP4NMOeFdhN2hJQNuuAALruhu1B0CrUZfpPBAFz77YqPvyTDsLuCpQR0IdlgPMJrS/nEaDF0N4xq5YUn2U6SJiAiMv7qGv4FadVbaz1JbosTmOFnDDVjKuTbcT0llfvXo9wVeTFdy6zfE57FgBetV05ca07VbVC0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 02-04-25 22:33:26, Shakeel Butt wrote: > The vmalloc region can either be charged to a single memcg or none. At > the moment kernel traverses all the pages backing the vmalloc region to > update the MEMCG_VMALLOC stat. However there is no need to look at all > the pages as all those pages will be charged to a single memcg or none. > Simplify the MEMCG_VMALLOC update by just looking at the first page of > the vmalloc region. I do not rememeber why this was done on page by page but I suspect originally we could have mixed more memcgs on one vm. The patch makes sense. > Signed-off-by: Shakeel Butt Acked-by: Michal Hocko Thanks! > --- > mm/vmalloc.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3ed720a787ec..cdae76994488 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3370,12 +3370,12 @@ void vfree(const void *addr) > > if (unlikely(vm->flags & VM_FLUSH_RESET_PERMS)) > vm_reset_perms(vm); > + if (vm->nr_pages && !(vm->flags & VM_MAP_PUT_PAGES)) > + mod_memcg_page_state(vm->pages[0], MEMCG_VMALLOC, -vm->nr_pages); > for (i = 0; i < vm->nr_pages; i++) { > struct page *page = vm->pages[i]; > > BUG_ON(!page); > - if (!(vm->flags & VM_MAP_PUT_PAGES)) > - mod_memcg_page_state(page, MEMCG_VMALLOC, -1); > /* > * High-order allocs for huge vmallocs are split, so > * can be freed as an array of order-0 allocations > @@ -3671,12 +3671,9 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > node, page_order, nr_small_pages, area->pages); > > atomic_long_add(area->nr_pages, &nr_vmalloc_pages); > - if (gfp_mask & __GFP_ACCOUNT) { > - int i; > - > - for (i = 0; i < area->nr_pages; i++) > - mod_memcg_page_state(area->pages[i], MEMCG_VMALLOC, 1); > - } > + if (gfp_mask & __GFP_ACCOUNT && area->nr_pages) > + mod_memcg_page_state(area->pages[0], MEMCG_VMALLOC, > + area->nr_pages); > > /* > * If not enough pages were obtained to accomplish an > -- > 2.47.1 -- Michal Hocko SUSE Labs