From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB6DC3600C for ; Thu, 3 Apr 2025 07:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87B58280003; Thu, 3 Apr 2025 03:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8273D280001; Thu, 3 Apr 2025 03:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C985280003; Thu, 3 Apr 2025 03:25:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4DC83280001 for ; Thu, 3 Apr 2025 03:25:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 83B32141A0C for ; Thu, 3 Apr 2025 07:25:08 +0000 (UTC) X-FDA: 83291896296.17.859B780 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 4BB5F4000E for ; Thu, 3 Apr 2025 07:25:06 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fP9iFvHa; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Q5+kNh+K; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Mdx6mtOj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=87gxF9P0; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743665106; a=rsa-sha256; cv=none; b=I+VKuDUye+kkX7G0qyroMtqaaACj7HJZWd2G9ZkgmAIyPOR1Zv2HEkI1oPgBykpgHCjaQX FAlcNpqYwyOacCpgpm8gHNN+4D5G5d8J97Qn8oRry+NPYGmCfkaRj+oo77afjqWHjWB7Gu 4r6P/A0T2qWbrMJbvflABVk66JK9DXI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fP9iFvHa; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Q5+kNh+K; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Mdx6mtOj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=87gxF9P0; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743665106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2KeaHAMR8ENgFFbELZLDJEj7XhlNjVDTBZt2DEloISc=; b=tOe5tZDexfWCvCgZmjkKU4pKm8TCa1nFqXICtuJXV3zqaYYISJYMMWiC+eN9DnWDggiLIi 6XEd7wCwC5lBc4b1KZmkeq5d58+b/wmeZxRadRmCLvdUI5OY9jGO7tr+BiqTDMTfQRPuHi e0qjMJBbuRQruLJPN9jXnQaAXkRlVOM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6CE711F38E; Thu, 3 Apr 2025 07:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743665104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2KeaHAMR8ENgFFbELZLDJEj7XhlNjVDTBZt2DEloISc=; b=fP9iFvHaBSRp9dmHUMrk6pRg2zhENYlB53sL+48QdTcydIyNfMQrkUo0h8oKvuF/TDkbvU fn0egzqyUCgDzDF1xan9Rnx3gqC0Aqa8TtAeTsolj12sN6GFx4S+KYkZIcOl2ln49ra518 zr30UlaOC9B2iiK6zU2/4brcWqXHzMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743665104; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2KeaHAMR8ENgFFbELZLDJEj7XhlNjVDTBZt2DEloISc=; b=Q5+kNh+K0TJhWDwMUOWl1aZGOfh0CROBD7ThnT9g6pG9SlX9mkW1tyIrWCuimcifOBRhf6 4zQtbv7WtoIzukBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743665103; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2KeaHAMR8ENgFFbELZLDJEj7XhlNjVDTBZt2DEloISc=; b=Mdx6mtOjVw6I38KZnL+zKKJTljn1B8R9c7y3w2XmwJ/FamC5qkDDS42MPqvoh5oW/EMQO6 H3Fnx0RGjUjbeQz8UDuzG3izdsFY8lIXBjzq3x/cyYeRxOShrHhGdEdbTMn9/8ZmvMUD/i lyXeJRv1+2DG8+2d/xfF1+L1YU28SEs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743665103; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2KeaHAMR8ENgFFbELZLDJEj7XhlNjVDTBZt2DEloISc=; b=87gxF9P085/iUswHelCNwDBYtlG7OKaKsSk9tx/6RXW6jl9ZiYYHcsdFwNV12nIOT9tkpF tyYKc6+fYSNJhZDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DC94A13A2C; Thu, 3 Apr 2025 07:25:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id A0EeM8437meGRQAAD6G6ig (envelope-from ); Thu, 03 Apr 2025 07:25:02 +0000 Date: Thu, 3 Apr 2025 09:24:57 +0200 From: Oscar Salvador To: Liu Shixin Cc: Andrew Morton , Muchun Song , Kefeng Wang , David Hildenbrand , Nanyong Sun , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: fix nid mismatch in alloc_surplus_hugetlb_folio() Message-ID: References: <20250403064138.2867929-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250403064138.2867929-1-liushixin2@huawei.com> X-Rspamd-Queue-Id: 4BB5F4000E X-Stat-Signature: a3mcj87c8rsaw1gc73m4d37x4dyg4r6j X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743665106-962218 X-HE-Meta: U2FsdGVkX1/OpyqDox8kw33lFZzR1tcwtvCBSO+wbVxjEGsZNHC82IMbTb9g51qLHRvHb34+M2Sh6CGChLIAlclHAvMhXRciJR6uoIOK11/Mr3Q151QKGLmK4x4spmHHV2XGJMDFN1WHxdD3pfN9hBVBdX9T4g1Z9nVFq4c+6WM7pmHTNmXsXcGhTIgmRaq2HhSGtTG5iSQLqFqONFcySP10kfSu0Xh5dNDDHzTpwudtzsKMpMJCf3QMxH60FQRqgYS5R8bH3IwNBk4VC5e2pUDEVaxRCV37S5oW8Z3wxwkd9xTinEIxq856IRRnAmJXggDAUY6/GvZOiDzKvmjsEEbC59c+0GlefjVOP7sdtRNPsXNA6PY3kr/vYoUYnPWPAkikubs1lLOlSdqCJvv7b/pl7p65+q6FoRl7p2jy1WZfo8rHipLG1WG5F0f4X61jkFGQWheCsJV8Qpy3kO7XfU6/5BPmPsKOi5+/KMqqMqm/juAbQZBkeMGHrhOuKXf/F6iD0DsNYmtezHamy4xEi+yVCpnd4SajHkTC/1Jgrok+3bSE9K1DN0TaAu8eQVreXoWTTC32NEa59atMkEd/zNOq6hneKSNAQGkpt9hG7ieH9I88r3mkhbU7k6i7RlOX9aIPF0fIfjEMk4fjthUpOZfTnfgSZ0TxsJjXkFHpMJ7czAHnHK1d5sU2a5LltGgvsvlRcsHXuZWZzp2Tqt0AZn/07eNHURe4Dvs6SzVsviLzGiuTOs526iVdOfXuMLMulgjtDjZfXzzN8t8l1OLqatsF5Gbck048QDNye854BYjP3biJJlpbO2rWoSuhqiWbRoXXQeuXmYhtwIALZhpdNwOkzse3DPJAnWG/GTpQbHQxKO48cLr/nenrSnVWh+y3tvy9n1/L2/RMk8lPQZ23xA7sktxi4SHYQ7qX9Y+4pdu7QnDqPgT/JUwFrBpOqonaHIKiCxBHqdc1+Cm8yk3 Et9qdt7p ULHfFkvuP/9qIGVsA11pm9CSWgsDdTwsypTFmPv0YJm49+D7ethJOkPpkHcq0xkUoAVstaYF7ejA+H5OuA7EohKYNHIe7uLK5n+3NiQeSy6eOKI86ZRceF/LeZRUq75Dff46ByQ2bHADwvwFa4B7YgOnoD7RUve3tR3FeJOJIpsLv39mO3oLZ+ayTc4aZwVLgiJ0Bz2U1lIEVDDoOinB2d2XcuVtfMs1XD1zwQhzfz/ZcN0jIWtLsChkjAPDfU4A35ZcIP8y7DqB4FK1VsRbzgghI6I6zKrCM85Ju1pXS++Rv1hh+T7bdIBC0T9MWTRHbXWlPZ2MG6JRXLL4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 03, 2025 at 02:41:38PM +0800, Liu Shixin wrote: > It's wrong to use nid directly since the nid may be changed in allocation. > Use folio_nid() to obtain the nid of folio instead. > > Fix: 2273dea6b1e1 ("mm/hugetlb: update nr_huge_pages and surplus_huge_pages together") > Signed-off-by: Liu Shixin Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs