From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 445B1C28B20 for ; Wed, 2 Apr 2025 19:02:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 655EE280003; Wed, 2 Apr 2025 15:01:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6043D280001; Wed, 2 Apr 2025 15:01:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CB1B280003; Wed, 2 Apr 2025 15:01:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2A15D280001 for ; Wed, 2 Apr 2025 15:01:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 185FE80523 for ; Wed, 2 Apr 2025 19:01:59 +0000 (UTC) X-FDA: 83290023558.22.3936898 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 2793F40013 for ; Wed, 2 Apr 2025 19:01:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MxBVpRqN; spf=pass (imf27.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743620517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nb+Gpjg1JmZryqku7pXG2hw8wj2Q2vTluqT4h8F5GS4=; b=L0X7OnTIfAgkWku4Y1fzHmCYPwDknsIViW+P8WP9BSFu/bK6zRZ1Ip/8dWVcmWxfg9UpAf sQGuAmI33lXF9NquiTXi+m0hFISS7VolnpO7CGtC8N8WAfXSsuWwDwymIyd4KlBQGxj5sW gkTv8692cm85cjPE5VRaZ3y1Bl3jGU0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743620517; a=rsa-sha256; cv=none; b=PnRR98lHjQ8eIA5XG6mApLNvHve3bXCniCDTMXpFC3Pz42B5V7031DxuNK49NkLEhi25k/ gfvuoONCkTg6X4dMI6I6ConLARmgiPOvoe2Yzg/2lxU+9SBoMXWd6txEqS0GeaLi+kCPFT YuRniD2uIOPbbk752iH4Fuon0RIALps= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MxBVpRqN; spf=pass (imf27.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-72d3b48d2ffso112969b3a.2 for ; Wed, 02 Apr 2025 12:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743620516; x=1744225316; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nb+Gpjg1JmZryqku7pXG2hw8wj2Q2vTluqT4h8F5GS4=; b=MxBVpRqNLPopK4+goUvPiS6wG+35y+bc9d2O0BagjGUP04zVexiXov/zO6xGqlvKPN LLTTuukEGk84kGgb0hVWByD5z+GWCNGcyWE4j01V7T12VSKBkxdZWhpCFcVb870gSnMt Pg+VFDAcNrscVTVdbM+g7rftv4w7o7/vEPW3SJJsbDtQWBtUhyCHebuyMEXxb9Fap1za oXVLvP7tKyX7jFQIbjsJVJUKOi0wpx6Xcm6FHo7DhQmiRl4dVKsuC9sgH/jm0+/sSNNw pd4e1lQ068Z7vi7lA4NRN0EF39q5KIERoWn4W9PtRXMzLHkk5d9uEQDAbehtCwk6/ZRF v5/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743620516; x=1744225316; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nb+Gpjg1JmZryqku7pXG2hw8wj2Q2vTluqT4h8F5GS4=; b=RjCpWHE6neZnXanbLOw0beEaUdtQF6SxEgFZ2NBBDxF0Li5f9/tIdQZcHCVtY17jTn +XYCB8bUQgnHaaYvHSo5FsarzY4lzD9Vw2QjGD6vT2sVWpfCl5SaiU3kjCFc5DEWu3ce feQVEoja1JLX8yQHQKjfNNT3DAeB5x+fklvWVFB95kQy6h5BAarZIE+JqcMmCfxRndTG oveFUOHA5LD6DxQYmNHnWIpJ0UOQSY9VcY+rIrVtb7b3Kz2xZOjXWxnYzFRQMe7gZSD6 t11dq6U7slSblAesa6Ax3d7nS3wHpeNL8p4LRsvbI/J7mknJFni2KlfGCK0Pdj5lzFid 3w1g== X-Forwarded-Encrypted: i=1; AJvYcCXqFdDTBB1O8KR1j095QqbZkdWZIYF89h5rLhYR2LM8z/C5imj2+BYD2c6iCXTd84LWztVnD5vi6w==@kvack.org X-Gm-Message-State: AOJu0Yz7hDx0vlgFsbR6PE/3zFtgDs3tbzbyXVJE1WUH3Ikr2YtZ2prd niKG89erIoHE8HDpMD1ghwNUjJTIgQD0DiRVsi8A6Fi5XzYJqPnE X-Gm-Gg: ASbGncvXMEF2PMSb4YqAS71r7z0U8lF53M16ng+eEKm6wf71n/Nnbguqfhz99vI4NWp wLGdRb9ypubATHyK7kHKkWCIvgRxqzc42EzGpCu8bwSVZi/NXwrzyAGHkHpdYPTq4QPxFB6gPxo iFVaVgRYEZksddE7Bq2v7kkpkiSrzntj4cPa2rxoR2AfcdNESArj8ub/kUzffYEkNDQdrXyuL06 Jy7aSoodRPOoanG9H2+h6iDGsJ2ZWfiZPlx2JNtg7dH2tRg7YoOpw+6sBVU/iZ/eZPP0oXdOkrW ovHsFssm3hnp1+ygAeScARhCHHDFzrJOT+v7w/m4Tj1VZJCDft07kFwAyzVKb+C98xJc8AXHjWB G X-Google-Smtp-Source: AGHT+IFw5BHeHgoe/2f1XCTVp8zBEE9uULeUw0xNTUTDyx7n85Bk/+ooSDGmjDTYpc9RcDsrxy8V1g== X-Received: by 2002:a05:6a20:9f99:b0:1f5:8f65:a6e6 with SMTP id adf61e73a8af0-200f73694admr58421637.27.1743620515909; Wed, 02 Apr 2025 12:01:55 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af93b6d57dasm8684672a12.33.2025.04.02.12.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 12:01:55 -0700 (PDT) Date: Wed, 2 Apr 2025 12:01:52 -0700 From: "Vishal Moola (Oracle)" To: Songtang Liu Cc: akpm@linux-foundation.org, ying.huang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhengqi.arch@bytedance.com, songmuchun@bytedance.com Subject: Re: [PATCH] mm: page_alloc: Remove redundant READ_ONCE Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 65y55ade7gfzq1nkkgez5jinhqn5cn98 X-Rspam-User: X-Rspamd-Queue-Id: 2793F40013 X-Rspamd-Server: rspam08 X-HE-Tag: 1743620516-69925 X-HE-Meta: U2FsdGVkX18lzr/+QPT1mxEffRwiAjhtniiD6A2vwYJEBYWzvA5zdyNOJxJc7CKfedurgrP34HUH0GZYueNsh3s15tA0cV/vZq0a2meJunosncYQ68pTvaYU4ZqkwoekOnvOxB9gsoKOwnr1ASfRal67UPFamK8JEUKguGUbPwmfok7xBToFn5rsrAX9sDNqp1BXZzNva1U0pZ9VyCYBydro1MawJcsiosvsVesC+kpM2T2dnSfD+os0g0ETfsppPjzZ3diTT5wXCp85MMXTJsxK70vyOvwbFZ1+j+NC6NJcs1iNw+Gq29hf8vM/4UQAUh1uOOUsddftvzja+VATY++hSN1V0FKzEtpkYh5ZGQKQlReFVXwa/+h70H0+mRCgie0yE4X92sqUWgnS7rWj+rht3Q7MrAxMnbROUsI9MKZyKMo2YDIGEStTiF3E+TmHaTSaJeVpOXdsh0YadjrR3YfF81EtXLGKkmqWT9yHIfu9gV7jvHrdDs852I4zmn5KlYAoKO15NIQR9O4IjfeHkIMFphb5n7DVI2aA4Nk2n3z+HAxetTDCVFjvLUexIay9im3BKLBK97D0K7IuePspM+VGG+1qElHZxwEB5ONyTzkveKdGyWKHQw3UjDyk12s2WMQYiiBM4q8/8HK+a2eN2fSq/9ivV7LjsS+MHBKxT/ngrIT85kNOCqh8DvQOresngDOm1loihQeu/F5Irnngh/lnid2NI5n3cDyOP1NKmilRLtNhqWVC/BWcA9AdlYMokDWeHrRYRpDWtxdo2Hub4SnYB1GKKCMCismrmawVRTNiIQuRkPjlDClsl2GcPRdHa8EJagd/ULy5AEzhdKrt3Wz3mXuAxtb6NvYmBNWBHI5b0wVJfez7zDLlOkrBAoZjr56kk1vLzejstBkUnCYi2T7qBCgE/UUYgsCIYrJbm0lDy9NtQR+fwIbHKevmRdYfwHlBAKTMTlcG8Y+72PI ngFwjRje mCSPm3oDnlvgSLOleVp3OVc5KdjTRza3uhoA7mIn3dJEZ/vKOTmXK/QrMi9l0FVOu/Fq0CYCcRFo1e6d3Yw7E1gZ02I+xsbOdsNlS5iBrWc3Oh8S7ykBSLMt9FS9jC3fNM1U7S9JHodTbrDhR0QMgD7ZrPz6NnTVBs5/XyoAVkocAO34Rdry53wN399dwQgPq219hNwBrK8VsYgUxOKruKyM89eTsrKaKNw+rq6ApJbInpF7sEeNbYZ/scP07cJNm1BnwsEU5JH/i7b3Fq3QRi9Mskzez5B3FcUusdCriA2b8+kpgRqFd3brpK2hIlEYZzNLySfUW8Wb/DzMit/mTbs5EiOc9g0matHAhB3MRn793dNmRvxe3FT77yjgLS1WEBFQ8YTycWa+K6cQtwkp9gWlqtBInx31FWbTKPxD44ng7P14kNtbz4GQzz8HdqhbLlz6EsOF1Y73tbAZFxsgim2Hn44BLRHa+krQf9cvH+QO24X3Sex0gC0DPZ6W6kQMYUZr12htnnAzUfxY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 03:41:16AM -0400, Songtang Liu wrote: > In the current code, batch is a local variable, and it cannot be > concurrently modified. It's unnecessary to use READ_ONCE here, > so remove it. > > Fixes: 51a755c56dc0 ("mm: tune PCP high automatically") > Signed-off-by: Songtang Liu Reviewed-by: Vishal Moola (Oracle)