From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEBCC28B20 for ; Wed, 2 Apr 2025 18:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CD68280003; Wed, 2 Apr 2025 14:46:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87C50280001; Wed, 2 Apr 2025 14:46:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74445280003; Wed, 2 Apr 2025 14:46:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5234A280001 for ; Wed, 2 Apr 2025 14:46:36 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 79EA11A01B3 for ; Wed, 2 Apr 2025 18:46:37 +0000 (UTC) X-FDA: 83289984834.19.B66B8D6 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf21.hostedemail.com (Postfix) with ESMTP id A6E791C0008 for ; Wed, 2 Apr 2025 18:46:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HRaUuztW; spf=pass (imf21.hostedemail.com: domain of mcgrof@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743619595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e3cDb8sKTjvrldkHk4Zseb4zxeMTA5w7dsRt5XLb6Pw=; b=RKpnX12jIKAbaZqfW9UFKCJAYB55bLfagcNewZO05iDcYWpzqApz+sHc6O0O/Q8ed+eZjI 883L+vrouxSlm0gI4w16FCwCpdmEDA8n3HBEAuxLAU5cv0HkNMIt4Vz2c2BljjOpyqgy+b IvPAnEO+tF3IhjYmDeF/h4ovMAUeknA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743619595; a=rsa-sha256; cv=none; b=EIIdu5nKud7YFp6wRwQld6kI0ldgf+NVLtk6H7fn+hR7Fmz6BZKHJ4OX0hj2Kj44HGZ/Tq TlyYQhsLKtkT20SYei5SUmRHs3+atUw05+BJcVQEtxUVFaQ3FY45JjMy6K4lEDliQ3czbT DypVVMttv9G8ayP3uDfBSw1wgdSl+4I= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HRaUuztW; spf=pass (imf21.hostedemail.com: domain of mcgrof@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id CB5DE4386F; Wed, 2 Apr 2025 18:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA941C4CEDD; Wed, 2 Apr 2025 18:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743619594; bh=NNPty5+Jk65JZUZnsiMLdlKG62MVsZ4Q1CPSxTdXSVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HRaUuztWyrdPRc7bajAwH4tX/vtfwV6F+3BQsT2pLqVZDZUchZfUthg1Ftv8fH+j6 enThnkTPnt+DWtegk1EaWz5V1llQHVwd2yfZNvyhrhRC3Pnzw+8agSGyoqJb4QsOo+ jC/1WY91NHGWHkQTzcA8/iV9JAskd8+vJr7dy9wVyRO/SIRwBKbKpaPVMBHPAg9bJ2 bmch0zMqSkhrSPECsOzsemboDnNAh17ZONMk7GTskADvLSBMYwGs8mz7gbtXU8Jr/m +gO/SW239OjQ/rnr5cUgn3PZap73LIUDOXtIwMrBTmJZ/j637ljG+ED0B0FQl6K6AO Zx0+BflnqglpA== Date: Wed, 2 Apr 2025 11:46:32 -0700 From: Luis Chamberlain To: Swarna Prabhu Cc: patches@lists.linux.dev, fstests@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, xiang@kernel.org, david@redhat.com, huang.ying.caritas@gmail.com, willy@infradead.org, jack@suse.cz, p.raghav@samsung.com, da.gomez@samsung.com, dave@stgolabs.net, gost.dev@samsung.com, Swarna Prabhu Subject: Re: [PATCH v2] generic/750 : add missing _fixed_by_git_commit line to the test Message-ID: References: <20250402183034.2334125-1-s.prabhu@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250402183034.2334125-1-s.prabhu@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A6E791C0008 X-Stat-Signature: 37z69aamkrsbu5m6kkugkpc3o6b3hkep X-HE-Tag: 1743619595-954302 X-HE-Meta: U2FsdGVkX182hALzxTitBWOCSAhbVPN2FAUN5Sehjb21dxQs/XTBdbAt2jMPLSWL9EX72EISyClzXuE6KTZ/ttsRDUgJtXT1LxN7GVxQ9gMMPtUoQEqurEjRBsr7bQ8NNbLfpSsPTJXOzLOJjLEX+ENc1UgklSRq/WJAbTpeEdMyVyLCdLywT/j9YUmy2lrSw7eeGH2Br6G2olMH3TYbZMxZT+B3Bbny0eRAZ2mijcGVFnHJVr4H1xiJzcMCzhnbv2RccZ/U4ZhcTEPsW+bExSvAjy8EWKjwIpCHMbyyV2IxN4Xg0yW7IKM7whK3d7i90ZrXIaNYOEZFnwvdbalZCBJPDUDfSX4OGQ5rps1qgnwsCXC+2BhyQE1G3TbUkTth3PPCJGnj1ejJUqz523lpCMFbp6dQCWT/tj/ondIVZIAxaAkQC/a26dkVddVO40kXSCGSLwtnt4wgdGYgQW1HPYe8R7crsQXdFJvIdkJIoeP1GAzGkmwa36azeMv+kZVNVhNQk+by4PGHF+ytdxuWPdjcXcU7BXnRfngtMB5kUHj61Ei14cf887LRB8Lj4kC9HIyjlFjToCcPeXdMmJbvioyBDtUifT4zlW22IkETMOJDOPPPW8IssSI6coUPiEz+FdwvRlt4vFRQ3UC7IG3f9mbFpsIrZEDpc5CQwX3meFxieVq0vQkXG04SufTO+Pgiu/8qjDFiCQjKmd7KMzx/uVQKEDGBucUcWreAEausrVXRBklDxZQdPqUZ9qhHY9sYR0KkCBisxkDlFsWlhBpDzqpSaJlKUcgqkIt6HPMsxWQFF7ct6VyG4uOw8btHZD63ig3ND9p1vm1GSQtcgYNPGvuA8rmiUg2Uh6hG4ZCgsdd1EciDCHCTsfezwqM/dd4PObs89fN6Mij4Kev+6cciEan6ru8DBevpdTq5Xxw2R9g5vp5eN5IC0IZAdEaz+BQu7+6UAOcDTC/H1cGmSCG dEEvnbg1 2HUsyWUmwInaNKdV7RWeyiBJ2EiwW8zPqtNazoO6K7pGItG2uDGTqrb9+tc7BqyIjx3YpTif5M04MADbtsdoBRQHkSFlm3EEfElR37bMfQJLGKNBixCdNCm/kZ9m8uQCXmNNYL1LEbmLJZeoQ3bvK63tEXDgOTzgJ6MKK0aCJ0bvFuZDhYn2ZYOCOzYZpXwKJtLAMZM/Uckaq1ljZg2c2X1J/IL2gIULQgVxzESJ92j+86Zn12nKXYjBi8Kz+VEKW+LUmlLj5Nw05Hsp1iDBgwGLm0YyL80VQIRyOTPz6b8iOv5gomZPmsTuMbB578n2NUwQjNTRqkxYHUaiJ2YIATEg7kpmy/zQFGMaXEWayreNcxNVfYX12jH6D9/BY3CR7IdMM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 06:30:34PM +0000, Swarna Prabhu wrote: > Testing generic/750 with older kernels indicated that more work has to > be done, since we were able to reproduce a hang with v6.10-rc7 with 2.5 > hours soak duration. We tried to reproduce the same issue on v6.12 and could > no longer reproduce the original hang. This motivated us to identify the commit > 2e6506e1c4ee ("mm/migrate: fix deadlock in migrate_pages_batch() on large folios") > that fixes the originally reported deadlock hang annotated as pending work > to evaluate on generic/750. Hence if you are using kernel older than v6.11-rc4 > this commit is needed. > > Below is the kernel trace collected on v6.10-rc7 without the above > commit and CONFGI_PROVE_LOCKING enabled: > > [ 8942.920967] ret_from_fork_asm+0x1a/0x30 > [ 8942.921450] > [ 8942.921711] INFO: task 750:2532 blocked for more than 241 seconds. [ 8942.922413] Not tainted 6.10.0-rc7 #9 > [ 8942.922894] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 8942.923770] task:750 state:D stack:0 pid:2532 tgid:2532 ppid:2349 flags:0x00004002 [ 8942.924820] Call Trace: > [ 8942.925109] > [ 8942.925362] __schedule+0x465/0xe10 > [ 8942.925756] schedule+0x39/0x140 > [ 8942.926114] io_schedule+0x42/0x70 > [ 8942.926493] folio_wait_bit_common+0x10e/0x330 > [ 8942.926986] ? __pfx_wake_page_function+0x10/0x10 > [ 8942.927506] migrate_pages_batch+0x765/0xeb0 > [ 8942.927986] ? __pfx_compaction_alloc+0x10/0x10 > [ 8942.928488] ? __pfx_compaction_free+0x10/0x10 > [ 8942.928983] migrate_pages+0xbfd/0xf50 > [ 8942.929377] ? __pfx_compaction_alloc+0x10/0x10 > [ 8942.929838] ? __pfx_compaction_free+0x10/0x10 > [ 8942.930553] compact_zone+0xa4d/0x11d0 > [ 8942.930936] ? rcu_is_watching+0xd/0x40 > [ 8942.931332] compact_node+0xa9/0x120 > [ 8942.931704] sysctl_compaction_handler+0x71/0xd0 > [ 8942.932177] proc_sys_call_handler+0x1b8/0x2d0 > [ 8942.932641] vfs_write+0x281/0x530 > [ 8942.932993] ksys_write+0x67/0xf0 > [ 8942.933381] do_syscall_64+0x69/0x140 > [ 8942.933822] entry_SYSCALL_64_after_hwframe+0x76/0x7e > [ 8942.934415] RIP: 0033:0x7f8a460215c7 > [ 8942.934843] RSP: 002b:00007fff75cf7bb0 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 > [ 8942.935720] RAX: ffffffffffffffda RBX: 00007f8a45f8f740 RCX: 00007f8a460215c7 > [ 8942.936550] RDX: 0000000000000002 RSI: 000055e89e3a7790 RDI: 0000000000000001 > [ 8942.937405] RBP: 000055e89e3a7790 R08: 0000000000000000 R09: 0000000000000000 [ 8942.938236] R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000002 > [ 8942.939068] R13: 00007f8a4617a5c0 R14: 00007f8a46177e80 R15: 0000000000000000 > [ 8942.939902] > [ 8942.940169] Future hung task reports are suppressed, see sysctl kernel.hung_task_warnings > [ 8942.941150] INFO: lockdep is turned off. > > With the commit cherry picked to v6.10-rc7 , the test passes > successfully without any hang/deadlock, however > with CONFIG_PROVE_LOCKING enabled we do see the below trace for the > passing case: > > BUG: MAX_LOCKDEP_CHAIN_HLOCKS too low! > turning off the locking correctness validator. > CPU: 1 PID: 2959 Comm: kworker/u34:5 Not tainted 6.10.0-rc7+ #12 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 2024.11-5 01/28/2025 > Workqueue: btrfs-endio-write btrfs_work_helper [btrfs] > Call Trace: > > dump_stack_lvl+0x68/0x90 > __lock_acquire.cold+0x186/0x1b1 > lock_acquire+0xd6/0x2e0 > ? btrfs_get_alloc_profile+0x27/0x90 [btrfs] > seqcount_lockdep_reader_access+0x70/0x90 [btrfs] > ? btrfs_get_alloc_profile+0x27/0x90 [btrfs] > btrfs_get_alloc_profile+0x27/0x90 [btrfs] > btrfs_reserve_extent+0xa9/0x290 [btrfs] > btrfs_alloc_tree_block+0xa5/0x520 [btrfs] > ? lockdep_unlock+0x5e/0xd0 > ? __lock_acquire+0xc6f/0x1fa0 > btrfs_force_cow_block+0x111/0x5f0 [btrfs] > btrfs_cow_block+0xcc/0x2d0 [btrfs] > btrfs_search_slot+0x502/0xd00 [btrfs] > ? stack_depot_save_flags+0x24/0x8a0 > btrfs_lookup_file_extent+0x48/0x70 [btrfs] > btrfs_drop_extents+0x108/0xce0 [btrfs] > ? _raw_spin_unlock_irqrestore+0x35/0x60 > ? __create_object+0x5e/0x90 > ? rcu_is_watching+0xd/0x40 > ? kmem_cache_alloc_noprof+0x280/0x320 > insert_reserved_file_extent+0xea/0x3a0 [btrfs] > ? btrfs_init_block_rsv+0x51/0x60 [btrfs] > btrfs_finish_one_ordered+0x3ea/0x840 [btrfs] > btrfs_work_helper+0x103/0x4b0 [btrfs] > ? lock_release+0x177/0x2e0 > process_one_work+0x21a/0x590 > ? lock_is_held_type+0xd5/0x130 > worker_thread+0x1bf/0x3c0 > ? __pfx_worker_thread+0x10/0x10 > kthread+0xdd/0x110 > ? __pfx_kthread+0x10/0x10 > ret_from_fork+0x2d/0x50 > ? __pfx_kthread+0x10/0x10 > ret_from_fork_asm+0x1a/0x30 > > Started fstests-check.scope - [systemd-run] /usr/bin/bash -c "exit 77". > fstests-check.scope: Deactivated successfully. > > Signed-off-by: Swarna Prabhu Reviewed-by: Luis Chamberlain Luis