From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61816C28B20 for ; Wed, 2 Apr 2025 17:03:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86351280003; Wed, 2 Apr 2025 13:03:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 812CE280001; Wed, 2 Apr 2025 13:03:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B2B9280003; Wed, 2 Apr 2025 13:03:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4B5B8280001 for ; Wed, 2 Apr 2025 13:03:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2A90E1A040B for ; Wed, 2 Apr 2025 17:03:23 +0000 (UTC) X-FDA: 83289724686.02.F0EF110 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id DD86540016 for ; Wed, 2 Apr 2025 17:03:20 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rWFGI8P8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aha205K+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rWFGI8P8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aha205K+; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743613401; a=rsa-sha256; cv=none; b=vhritmEsTkQLo3evp1qCH0GZkcVvIeOT4dp2yzbtDEKh1qH/dqklbXIgPGUnJxotwN48PD LDb4swY91jcUUWrHs3PTewr0O2wGTp6mEfNg3vOw+9iCqJsyGwHtPXrmL/1L1APK6z7Pqe 5Cm0cftZN3Gj+7PhIg5I8Klh5IOuHTg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rWFGI8P8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aha205K+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rWFGI8P8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aha205K+; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743613401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fa6YlXKodz8uE2B17ypH6DPH4OLlDWUm8hFyF5FIY9Y=; b=3v1QteRgCforFDXT3zg45rV4M6SlJiBQlk2kxYuRldC5jMda52Smd+4xIpR2SB0qhEheVc bpRWuGV+JP6RxfU1/dFrjbT8rYM13qbD9NQTOAsZ29ICZ0NIC9/iQIZML6o+YJ7iFP/91f f0lf23uPVgySq5CBckTEwXo17N2nsss= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4B9BB1F38E; Wed, 2 Apr 2025 17:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743613399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fa6YlXKodz8uE2B17ypH6DPH4OLlDWUm8hFyF5FIY9Y=; b=rWFGI8P80VWPbDK82CvkzpgfMRqhsRT66++IButprgXUkvHplkNVR+XAfce703NyqRxfcm o2Mnvu1xS4IhZbCaKlE9zWZo3KFT7U8zBPJKZlJW82qj5MbU9BRPUik8tnzKz6atXEJ7wa 5jeb912wh//dS+1kIcc3XIVtg3IOkQA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743613399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fa6YlXKodz8uE2B17ypH6DPH4OLlDWUm8hFyF5FIY9Y=; b=aha205K+PISVQemmiSHd444KuIKNhvoqvLTkoXs+lESA7oYt3e01QexR7UdiM4dzX9Rahi zE4x/84orzT5wUAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743613399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fa6YlXKodz8uE2B17ypH6DPH4OLlDWUm8hFyF5FIY9Y=; b=rWFGI8P80VWPbDK82CvkzpgfMRqhsRT66++IButprgXUkvHplkNVR+XAfce703NyqRxfcm o2Mnvu1xS4IhZbCaKlE9zWZo3KFT7U8zBPJKZlJW82qj5MbU9BRPUik8tnzKz6atXEJ7wa 5jeb912wh//dS+1kIcc3XIVtg3IOkQA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743613399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fa6YlXKodz8uE2B17ypH6DPH4OLlDWUm8hFyF5FIY9Y=; b=aha205K+PISVQemmiSHd444KuIKNhvoqvLTkoXs+lESA7oYt3e01QexR7UdiM4dzX9Rahi zE4x/84orzT5wUAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BDBED137D4; Wed, 2 Apr 2025 17:03:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id d/qQK9Zt7Wc2XwAAD6G6ig (envelope-from ); Wed, 02 Apr 2025 17:03:18 +0000 Date: Wed, 2 Apr 2025 19:03:10 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: Andrew Morton , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, mkoutny@suse.com, Dan Williams , Jonathan Cameron Subject: Re: [PATCH 0/2] Implement numa node notifier Message-ID: References: <20250401092716.537512-1-osalvador@suse.de> <78c976ba-1eaf-47b7-a310-b8a99a3882e2@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78c976ba-1eaf-47b7-a310-b8a99a3882e2@suse.cz> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DD86540016 X-Stat-Signature: 1duj1bzxop6iemsuaormcxoxaon19a1j X-Rspam-User: X-HE-Tag: 1743613400-988617 X-HE-Meta: U2FsdGVkX18keQ1fDhNkSrtsjjdRAEUly2cTL8oFJNSdpCdj1ldYQXZuIAEoWFYBjnXyZYp9VUdut6TiWN9U3LI94PYpDTd+WJB7q3c0KUh20XPaB/tMLD6zlgkYlBaq722oi7Mh9skqyMvmRqgMrczO5Pw1A4INkjuT+/MID1aqyQ66d8hz+LitMKmSewtAbV2ClZcWiLo7XD1YNrRqK9z//7FOL8ljlDZQ6jFukCtc2iR2srnOiNJXQ22uND94qxoz5Azx8PeX2LX/RxEPlSo/iORLprQIZrNEScpbUjR+MIPp8fTKtZEY3hXxOf8tiA2ut9l9iyEUx1Te0qkvHlbTqklA0XoPiMYKNXLEDd1O1mA73+SN3IFhI4TyXXuRMEQ35Zxh+TlYrtS66RtRF2TSdOlciV+DfNLNT2MDav+0b7ybMZKy3ZssXAVPoDPR88ej8Gb6mqq7/msZaTGYU+eH5XAizAnj6MLAuDB1ygGppqt2U/WaeHmMBpRldS+4HyTOXL7eEIGatnSDZb/iQHpU/M0J2HOFL+SsQ8bhkzLtSQTBEAGaBSmfvvSYytcfryh3qV47OOyxJLnw8iyCgSdhJ73EmvzCkkjMWvDFhItjF3oyzIvv0OtPgIwFtXPLv5hY/LnlHX7Uj1K1D8zXrokr+f3vtFDbX17SDSAvzZsFL1cZ81RZWQF77kNuDUMW08ZVd1te7CuEWzWVVoBuHyrDLjxBezZuMJu3xrbyBIDcHqY7Sw+TgBElPNFWMq1ipzNojV0f7ftmqFEH71nJaXle419r5tNURzyoYTAE2qqY7K5JljpzBbG3TZzIk790/8xDDTERmhcmIOV1WqmtrPT1fpIHHYCIbb9/pf9hLrLmrTNc1FkWBalbGZ/DWd9+wCRwD4MO73LiLlIg08cMUMCN88kIkWX00DBFhXQNrKGNKWaZNoHH7NttTdAKtVviYmk7Bt21NPm15OnZfb4 iu2gGEmP 6fYC1eNzxCg7UHj9sriIiHjNIjNnmXPUQkG3LkiTaVwkZJUXPMb44lYRjQqqtJWce/R50YSxUuZ0FUKILcm/dWDeNUOaINdOflzWVbBvnKy9TZ7DH6h/VpB9Z65NNYSWJMcwlVUkDFbP3bryCIWSeZi8bZM+SgfpyxAxbwemX1tjDuIV+Ib8/5SK8nSnh2SKp6/oHG9XvAWJlON43U7JaljukNoFMytBNXF/sS+z7giVhe2551IEcxmER8UtA6shEmgjRoL+IJIoo5QgaoMM0hJJUJy602Nr1hBTUoyRNs/71AT7SJ8abCS+LP39lhZ4JaGAWmpG7Lrbuv/E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000529, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 06:06:51PM +0200, Vlastimil Babka wrote: > What if we had two chains: > > register_node_notifier() > register_node_normal_notifier() > > I think they could have shared the state #defines and struct node_notify > would have just one nid and be always >= 0. > > Or would it add too much extra boilerplate and only slab cares? We could indeed go on that direction to try to decouple status_change_nid from status_change_nid_normal. Although as you said, slub is the only user of status_change_nid_normal for the time beign, so I am not sure of adding a second chain for only one user. Might look cleaner though, and the advantatge is that slub would not get notified for nodes adquiring only ZONE_MOVABLE. Let us see what David thinks about it. thanks for the suggestion ;-) -- Oscar Salvador SUSE Labs