From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB24C36017 for ; Wed, 2 Apr 2025 16:36:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEDEB280009; Wed, 2 Apr 2025 12:36:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9DFC280006; Wed, 2 Apr 2025 12:36:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93E7F280009; Wed, 2 Apr 2025 12:36:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 73EA5280006 for ; Wed, 2 Apr 2025 12:36:29 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EC028C0224 for ; Wed, 2 Apr 2025 16:36:29 +0000 (UTC) X-FDA: 83289656898.21.ADDB65D Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf14.hostedemail.com (Postfix) with ESMTP id 0E8E4100002 for ; Wed, 2 Apr 2025 16:36:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=esnEgb3m; spf=pass (imf14.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.178 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743611788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KgpSBc4bwmCggwElKm6ARy8yOozY36WU1+SeYhhxYVo=; b=YVOOMYUkg2Kx/9wcij0flsQXoc6Rm/X2etW38FMSzd7YtKjzMDWCdP1zA72KQ/7O31qsE/ +BO0pVfPlFEFH/p2RdZIHCSB1kDmvVQvaEE0rTYoZBDQHSZid5AJWSOPOKV3VJcjc9vixe 7KRxgMN9kWMlICNrt7cig9vfAGGaXwc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743611788; a=rsa-sha256; cv=none; b=s18mUW94+7d71Oz08ord7vatDumy92Yp0E3Ifg0Zs8JRvPZU4vcc8JAiObkFbDGWuQINET H7hocwb4JdPZXuooZIdKhkvFsoW74aq6mDfOhD05aCE0rW4kBMXEwF0Nm1SM3IMFmjUYsS oftHAri6mzJ+I02sfq5I1VaQPq8wmV0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=esnEgb3m; spf=pass (imf14.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.178 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7c5ba363f1aso958373785a.0 for ; Wed, 02 Apr 2025 09:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1743611787; x=1744216587; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KgpSBc4bwmCggwElKm6ARy8yOozY36WU1+SeYhhxYVo=; b=esnEgb3mpV7Bls5NTpsAMVXDUUbsGu6HfhsgnDf8/QAmZwuJ14NzVOtLXX3yam9lB3 LTODWutpZWcmjspHAOlGM8naCjyl+rurkzjJ4OvxjtFTuIdN5RNcftRPG87SMWuDOJgG JwD41SfK5W0iZPIimzUVklBw6HMGv1AQn1KG1B/J1kk0tsFLUpIdWK1qCXzI2hmhFlID BxuAppSzT2RcdQrTXwc3LhT2aCM3jB5Ioy1+ISexSeDtwsvEjg+Rr78/30GgdQqIOdZv eBkj/8QvizLkY/ynau8C+uLO+sKX7aMFAPHctZngzF60XzYnyglub6t+5tKzdFEXDEZZ NjOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743611787; x=1744216587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KgpSBc4bwmCggwElKm6ARy8yOozY36WU1+SeYhhxYVo=; b=QHTdJuzghArlrr1dSFDDiCe8LhIuHqqaexg49fghT3j5hB/P7XQUHMZjfmms/c7nGv 6d5QqKr+EZvZQpcCWIowyX9NSSkh9KI+fjKGt2twMxi6z4INV74HAl9oD70a1qINcyrf IcN07ECb6R30hDlpKIQIj1Le9oDxmplW/rmgzE0814Anu9V5dt9zc1Xod3/60jPYovof y44QP1nmq2M9DMsuUz/VAZcbmUiYxvXUvKqZ+GMoqaUu6F38xKJxMJZwEGflS3OGyNLd NU8V6Lz5wMjIMpJf/6rBQs//ihqhl8BmHGkkgZNnoWHj83u0B281s3MfN6sPv/4qmZyj bDZQ== X-Forwarded-Encrypted: i=1; AJvYcCWn3NKeHgXMsi0Kwj0UJ6JUGw6ZcpwyCMZyfsRcL7nnZKn754S28UTA45UlTKg5PF6szaOJIDEqUQ==@kvack.org X-Gm-Message-State: AOJu0Yw3/ToorzfiOuPoASKFPt4jxdrJqmDgTglUf9++bNgl0B5sln5B KxadTchhcOZ9mbAd8blJ8SigmubON0ycpg6AAtmpPg+A0fEgK6dcEoyiYL8gebY= X-Gm-Gg: ASbGncvru2h+EIDBwuILxeaCyjdo9Wt8bV6VWWfWkpUGfXV44GsJCgkwlwOmg1KRi/v tU9FbbiOefxm/uk96WqNJS1Czh5ExL5waXs46AM0GNlxj32nl0pnj3ld+M3g+fHKIimnWuCW8Jc GMsDhf0XCpqtBBiRXx7qGidDInkdYVBhK9v1FnOmEkG1OAw+lR2aY1Sfj89djRJK2Jg34lGHkAq X7WY6AsA5WZOFYbFlcL+aMXAUVLBbMZ9x48oW5syi9IGlSu2giiXGOVtc/dQ9U0pqL06PXVOgS2 EUp0xqhlvozr050m9NygkIGSllRNrBi4FjKG5Ag9OoPL2cjZoKsUdaQFoBX/akX12unmBw4OsrO vZ3XzVdAVSDx94DGmZmk1cdkhP+k= X-Google-Smtp-Source: AGHT+IEI/0jyf6fklqg75GbTJdfuNj+99i5HXBUCPbxpHS67L4ueSNZOE2R7l2jQabFzIRLJMuhBOg== X-Received: by 2002:a05:620a:3950:b0:7c5:4949:23f2 with SMTP id af79cd13be357-7c6908756d3mr2557731085a.44.1743611786890; Wed, 02 Apr 2025 09:36:26 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5f779a924sm800564685a.114.2025.04.02.09.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 09:36:26 -0700 (PDT) Date: Wed, 2 Apr 2025 12:36:24 -0400 From: Gregory Price To: Oscar Salvador Cc: Rakie Kim , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v5 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Message-ID: References: <20250402014906.1086-1-rakie.kim@sk.com> <20250402014906.1086-4-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0E8E4100002 X-Stat-Signature: cqumgxoi979sd9gfa7cxjinmmbbxymao X-HE-Tag: 1743611787-693321 X-HE-Meta: U2FsdGVkX1/Jrv5d/2CO2f26ssx+NodNOGFvZ8hhMtlRsoz5QEyNLFabWCNC/bbEnXrADIayvzcwLJYQaiWtTFyA9LntcfN14/caWZBw5fK9H9hNnIsckmSyoObbI8Ht5rwfEAJzylFo5l17SiwSnmaHa8NExcYdbm/5lOVKxVGgRstHFInD+3/5oOCyZeGkZth8Xm5vwThlCt6jbT0Hzrv2jUe8U2BaZbNssMIBuwOOPEJKBNaMJMAHKSTdFSGaA983uF9s9oCRDMOhJw6G2AhVIU9RX2OKEj6Q7GFG+O9paGkj8Q0yf+cOqonxufgNOCwQ54zI/VH9xl33KsndN15PytdpvNg0dMf4I8yBavYT+BBZRRxc8cQMImZ3qI9eVWj/fuc2k02cJbeP5BtVgJld2mBo/GNDshrgkoZrK3ocIkMFI3hUkskG61Wo+0KGgCv8zDaqOSDLQeDHJLOppJd4zZLSMPzK+QHgtk/BFt5QGM5XJFE5ixVBL8pGWdbe2lfg8fi2qgFSUQs7bCID7VWhJEOYwmg3/BKeQH59LnAYoKhrbZsiyhgjtyxLmuz6o/d+/hMLv3Rse3uItLughalBxMYvC/uB1v7yKJojtG/5Ek3SNdUP8e0DOKL23yFiz5xXtTMnm708/QkZowMEU+o/stqtY2CPgQl8XJBWoDMvm2EotTVmMXULEQqNPdlCcoIJhmUNh4znt7NjTaxJPs4OgXAl6hvcbYSqJMrm45RKMdZ77FIGosPuPv5NHHAl0/TS1Ui1Iprre/f9BUezoY05FK6OsoFLEw/+6R6u7qnC01jjsm7zulrrO9Vsu0bIc0v+6azlfEZEkhTgPxDlm3TzMk+j2VMTRRJN+ugEyRap/tvj3DIeBC6+bbUHLSR7h8iEyESkQbnv7XG/0rPQhc+EajyqrJwyU2vAEch7y0zHt9PWuh+CWA6RN5LFr5x7Z4oxl1DET6lc+/W9WEc w7mcYJs7 OwQ5Mga/D2yWxJhSUWjBj272ZKldbiqqqMHy7B7aWLV/cuS8CdsJRSvM4tIwZtNueLF4iEZXy4eSqwUYRBq84bPPtzlWI3R/9uk2369BVZd/pUpNNHqSR6ndIPhxkRs9TnY7w9ytkrxgARrLw7G9rUOVEZEq+Fb5JWD79kAuaqkJMkBuQGPKMcfbS6vANpgZTHu8zdBT3/a4MldxtVOwiHOBbkS71QmoRJes2g+XFjhFvFSudLxWdZR7O0iS7ty4egLeFEWKnWfsKwWsD4SntzdHhO1qnvWpq8rHvSwzieVd7JTYvkEABup1Op9Mhg1JAYr/WGepziIkloB56RDyEmKPT45I2UPnnEJWu1PQFhOEtoRJkPl9MZ24pj1DwMKVfCmFoJpLNy7wYxXVJJhQxIgachA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000086, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 05:41:57PM +0200, Oscar Salvador wrote: > > Yes, this callback will be called whenever {online,offline}_pages succeeds, but > status_change_nid will be != NUMA_NO_NODE IFF the node state changes. > And you already have the check > > if (nid < 0) > goto out > > at the beginning, which means that all {offline,online}_pages operation that > do not carry a numa node state change will be filtered out there. > > Makes sense, or am I missing something? > Ah, you're quite right. That was difficult to see on the surface, so the check in fact superfluous. No need for an extra version, can just add a patch to squash and drop it. ~Gregory