From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE9DC28B20 for ; Wed, 2 Apr 2025 15:42:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCB8C280003; Wed, 2 Apr 2025 11:42:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7B77280001; Wed, 2 Apr 2025 11:42:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1A86280003; Wed, 2 Apr 2025 11:42:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 911B8280001 for ; Wed, 2 Apr 2025 11:42:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BEEA1141BE7 for ; Wed, 2 Apr 2025 15:42:03 +0000 (UTC) X-FDA: 83289519726.25.B05149E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 9A6DF40006 for ; Wed, 2 Apr 2025 15:42:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DEKUU0rt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="yX3/I4fR"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XOAx7ptH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=v3igOhzZ; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743608522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EG22P7DxCo5cHt+oi7u2ba0p8PnBOgUBOEtLQ0J4nE0=; b=kdHTwUhoj2zqYGerrFkxemLI/j3iivzbyMKTqTLLcfq7b2ndj9GB+9Bwi7iYe86az5clJw TDOzXejB3UcMiyKfzmZ82O9aI3g2Hsdjte3ccWu08FrGrCyrXyhpkf9/qGM/27B+1q7JSb XCC71QG4YHS04WaM64MZ7sTULDquFYc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DEKUU0rt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="yX3/I4fR"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XOAx7ptH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=v3igOhzZ; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743608522; a=rsa-sha256; cv=none; b=NFT8V0WxErlV0iZSavFJ5BokEunZjhvWpH0NGRbFI8dKag48YpVndOlonOv12vmmxIKyQk gk8um3XLf+wOMt50iIqTSJIUeDpm+I0T1nreoRFRXK9XNWVuHskVI8UmvePWHT0lh6UKfN +sR92muKSEcy6y8kNBPRqlW3tF1DMQs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DD7D721190; Wed, 2 Apr 2025 15:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743608520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EG22P7DxCo5cHt+oi7u2ba0p8PnBOgUBOEtLQ0J4nE0=; b=DEKUU0rttV2MWjSJQi/gwRKIJ5aaZhFrc0wM6CjWsGO5NseAUgs0cuE39SSB5HcnF+psVn 8atC2B6ExhJZIwbObAk8M6PUfezbR5fazlU4i6EbFwpzfObVKjldNzTk14JSetjjO0ZWLN aYv9aSY7ECYbVjglHjHsjxGqMqyPP5o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743608520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EG22P7DxCo5cHt+oi7u2ba0p8PnBOgUBOEtLQ0J4nE0=; b=yX3/I4fR3q2cI9nV6PHYWaZNTRXkS8Cp/HA74t7DOxUTb+W02zoBbGYKMGvUPo4X3fqoyX FHD8LjRaWkzeqQDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743608519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EG22P7DxCo5cHt+oi7u2ba0p8PnBOgUBOEtLQ0J4nE0=; b=XOAx7ptHfzSQXto+VYp/gSOwLXIKLrKqD8HxJze5Jplt0OTllgPk32ynTKx2ZrgptsiSWV qbOTaYDWiLJJwwgxw/p9X2iOIBxmwfIoJIQTwFiXhOtwI5B9xY+W0a9cQg28GGDuQgG9jH gUlTAZFn63uY01aSJPCMMNJvCbJggK8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743608519; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EG22P7DxCo5cHt+oi7u2ba0p8PnBOgUBOEtLQ0J4nE0=; b=v3igOhzZ1nZP1cBe7tnGSAYt9rDg/L+O/ZpDPdnB5poTOkx4o27Bp9od7y4jJug3DpovSh TiWWJb6bwECRsBCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1FD8213A4B; Wed, 2 Apr 2025 15:41:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FPX3BMda7WcmRgAAD6G6ig (envelope-from ); Wed, 02 Apr 2025 15:41:59 +0000 Date: Wed, 2 Apr 2025 17:41:57 +0200 From: Oscar Salvador To: Gregory Price Cc: Rakie Kim , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v5 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Message-ID: References: <20250402014906.1086-1-rakie.kim@sk.com> <20250402014906.1086-4-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9A6DF40006 X-Stat-Signature: kmmyjzqdw4zcfpgs918x646c5mbkw3n6 X-HE-Tag: 1743608521-38821 X-HE-Meta: U2FsdGVkX180JZP+wyAq2MwEG0YR1Toeb6881a1MMRWoOQzxdHHEKtGNCLhe1P5uru9VBjV6FAefL7f+lSjj8GNtO3EboklNysp1P9Bpti/8QomBZH5xKtHcm32J8NiRDulyQ8kqymzo4q3MJ8BTFugdZphoMa5OnbEd2rR9oKC3cr58CN1QCtxksq1oYrjNPzMcCH42EoiRq7/LOVOxIR9kzYie7AGtDXyBwMsq19Vtrpk830W2ABwV6CxQS5aWF3dbiQudxpYyrNCuisHxLUZIKlrllTbL8JCaQ5ciQEjet4GzGa4DFyB2FNKol9X/IKczDY/YahqXSfYmPIpxFVo5jrJ4/Zv1AGRuk8akhH6/HnlvjzD8OUnbs2dgavHi7tQnb8wal+fcBvdCuYZEMxT8Cpw3fO3OeCiOj9DKuG9CEuJYbdK9Ht2oHw8bzDDAW9WtlkQlghe5t+PxqeyZvyY8ssl4ezJA0tUkFcAyoU3THwfo3pEFGAQ2LxgBI6VugMeKYjYIRZAWqZwWit7yg3VufLBWMeBN6RhjQIuGgN+8E44+9+qiM4PDu4M8RTL3YEc8MPFPcahTwMwid+ablxEd3IWYlKxcbGk6uG4kwphrSxNVon0x/2H15SsIKPdNbz7NMkE+jYoyu+CCgc9LBDm1IoYwIBkhJTIGlHbBnr1SllO6uecPHLF8yFm9lCe6d/Na9Yee49YFHywUsdAx8QSAHv+W8RSNAQgsABonhZQAdqJYNEXimN1CwBpOd75SUltIeEdj4zaNcZ5FAK6dE7QRWibSH4hMzFmaac4lbmNkMEC8L3srWow8BSVmfaZ1DiL9NkClnUT0+BeQmO0LkLloUYcAQY4p09vS8suPNOLb2fi25tSq/XCiiIn6vCeNAdB71YIRUzpo8DToceS7D+T2qgLbrOf0u1EVQpmjwPi5rx4nudqi1H66MgMBiBQOdi95atwH3qECcbsFvSF igNzqRNI 2dJuQALXSYRclXRA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 10:14:42AM -0400, Gregory Price wrote: > On Wed, Apr 02, 2025 at 11:51:17AM +0200, Oscar Salvador wrote: > > > + case MEM_OFFLINE: > > > + if (!node_state(nid, N_MEMORY)) > > > + sysfs_wi_node_release(nid); > > > > This check is not needed. > > > > If status_change_nid is different than NUMA_NO_NODE, it means that the memory > > state of the numa node was effectively changed. > > So doing: > > > > case MEM_OFFLINE: > > sysfs_wi_node_release(nid) > > > > is enough. > > offline_pages will call this callback unconditionally any time it's > called (and succeeds). If 2 dax devices online into the same node, it's Yes, this callback will be called whenever {online,offline}_pages succeeds, but status_change_nid will be != NUMA_NO_NODE IFF the node state changes. And you already have the check if (nid < 0) goto out at the beginning, which means that all {offline,online}_pages operation that do not carry a numa node state change will be filtered out there. Makes sense, or am I missing something? -- Oscar Salvador SUSE Labs