From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52662C28B20 for ; Wed, 2 Apr 2025 14:14:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F643280004; Wed, 2 Apr 2025 10:14:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67FA1280001; Wed, 2 Apr 2025 10:14:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F857280004; Wed, 2 Apr 2025 10:14:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 307F8280001 for ; Wed, 2 Apr 2025 10:14:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A3A3C1AFE for ; Wed, 2 Apr 2025 14:14:48 +0000 (UTC) X-FDA: 83289299856.07.DA66850 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf24.hostedemail.com (Postfix) with ESMTP id 2096818000E for ; Wed, 2 Apr 2025 14:14:45 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=q8P6UBke; dmarc=none; spf=pass (imf24.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.177 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743603286; a=rsa-sha256; cv=none; b=MHmgbEWWtZi401JiRV1lFqBTNVTZP0+0kJqCD91Vpyat/N460GaDkJoXPq+Yb0g+mI/Uu6 qasvHcr9CIv4uZOnUhlRguc7d5fxsBcmMOoUYets6m1MIVgcwGFwdh+Atl9SerKiNZ0+hd B5rpUYmNU4OkJ8maf3Z4MsRW7ets3cU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=q8P6UBke; dmarc=none; spf=pass (imf24.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.177 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743603286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UkL808QoOagxPn1CA7CvE/Yc8W+p4mA2vccj1YTlzs=; b=Hj+ikr8mIoJjLmvAwQjbrQp5CamJmpfF/zNjZWI942R233+lXIRfs9eKtjmUP9UcYKWz6f 25rOqxdjeSv0WULjg652bJNM3W+Rw5KtHq1KVR0RJNHF/X4KBPoknBR60ildMkFvcR51/w f1APi/LAjRQimYpmpEA2VBNs6Xh48os= Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7c55500d08cso599591185a.0 for ; Wed, 02 Apr 2025 07:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1743603285; x=1744208085; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9UkL808QoOagxPn1CA7CvE/Yc8W+p4mA2vccj1YTlzs=; b=q8P6UBkegQ6kRgeFsf/lYgS7HtpwFCsYymNYqJZuZ8F2jf1du7WxFxp8wY4JVGsmTi Hn4SWz7orsXWT9E23deNuChdbq3aZbq7Deke3JRWDy5nN6l1UJjVVkq4zM7CsYKFULwF pxrT/WPcud6EBkQ9NfjiBoAEG7B0/SBDQxWsdrzhgsmLAv6lw6JYX7Yv/IH5rjsheKfW b9KQ/zMtsLVPtEIJaqwU/xPsFbKdd469Q0XtpVf8Llcn9GNMSVWNwHKSyh54lJvp/dgg 93SNKrvp16AXfzoxjKKJq7c4GSgF2jhXO4KtP/jeIiwuoXrAICIadz2Yl66lHytYPvWd 65JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743603285; x=1744208085; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9UkL808QoOagxPn1CA7CvE/Yc8W+p4mA2vccj1YTlzs=; b=BFDl9MRSXBwc9H8WthYQOYC9+DgvcsbCQxcKEGpHpbKQclsukJt3oSkY0B6OwEnuEl DVWxbofrxudfpDgs3PjRn8KDvUQK3UV0engijXqQJLe1Ce+C2o361gyRm/wQZhO7EXhu UumsLe3fh9AQtzrKHKmDTmvRIZUQ0gMy5LPg6tYZ9grOxWk4NJAFhCljTA1EIqDi122i EK4e0SW4kDDE2GKXl2Rv+mY0Au439KTMvOGW2FbOu8ikcc83R7zBiQ1rdFKrR3uW1nDm ezLZKORBMx/+XhW/NOY3vIKN9bkUTG0Z554uBYZC0ROOOSQEmpliVW2N7jyCuNucpO/w z8mQ== X-Forwarded-Encrypted: i=1; AJvYcCWxeWWUja8Xt2FFGq8DWeK3NudF02Lw01qDdU1G8Ot2AM8SaU8xl9aQcTnw2a2AGHBZwoVIqlTz6w==@kvack.org X-Gm-Message-State: AOJu0Yze3s1HdLDqfQHK4dit57/G511yxchElvxqcFwwA5w+W09Rw4up oSSTTpqm+r4Hm4g9AXvsQReqcArRlWTUnFjgRDAx3QJw6AqlzC/a95UtsFglLpI= X-Gm-Gg: ASbGncvxKq7b27+yAtHb13NnoVx5yalkkvpqNVPYdOXI4OhtUTmFFvOxRwSHVg7YBkg Y6xR99rBupVw0GnqTOw1dDvxBMk2KG0Y2rjJpDYB8uknZu6SpxZTQ3v0VgJfCfu60fV8JAtD64F ehGRFK8qH2bT2Hwz9ik9beE+bqs5reOFefaDFooGtnOn8aKFnaaXMCIFNwR4T4acP0aFOqwQIYc bJDXNeAjvvPjc0FhwCQyo4yGidtXN3t0oyk/1BCEoV2KoMO4sfK7rBLYGHiR1m6AYn9PQqoDXSi tdffpOQJ3CyCN07NUKyqVm5P8O421B+amIc+7qDJd11MlsO/78RT8PzoB3QOxKjIGT60PFTm302 atZ2W7T61It/+OAIVzj01N19bWuE= X-Google-Smtp-Source: AGHT+IF+VKt9eqjk1q7w411mxoZKToWyH5/YzFwvHa2gfGrBQuMo82PAI2uSF+0IBasFLzRff+rDuw== X-Received: by 2002:a05:620a:19a5:b0:7c5:5584:dc1b with SMTP id af79cd13be357-7c7664f4655mr417448285a.54.1743603285123; Wed, 02 Apr 2025 07:14:45 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5f768e3cesm786174085a.46.2025.04.02.07.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 07:14:44 -0700 (PDT) Date: Wed, 2 Apr 2025 10:14:42 -0400 From: Gregory Price To: Oscar Salvador Cc: Rakie Kim , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v5 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Message-ID: References: <20250402014906.1086-1-rakie.kim@sk.com> <20250402014906.1086-4-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2096818000E X-Stat-Signature: egnzab53bbi3snjoc59s6e3fud11neie X-HE-Tag: 1743603285-418722 X-HE-Meta: U2FsdGVkX1+/zrJxcGhC6yTlBjuDha1PAcsPjM+ue7F8lIEAeaIEu9hQLkv9iKV370C6GLatA50eyBC+YcQECblt0fd63541zKvpH1YSYIt44RRYcxmQuW/rP/x8oESiZRXy3TzNBe72d0Vezmq/RQXkLPU8RC+Wi8GGNqgZcAz/X8ITxtAkpqXsJ5w1O+BkSjLpROfNi3iErT0RFCFWtHtv7a6npekrBZDLih5SoVdG7sxBxRjPeFGW7agg7/9AFthtKjJaUzmC5NCQX4M+JtGWNUT+fBvhXkhWDNhS2x5z/IVSYmoTir5zqil3NjMTigVNfzr9VKtB8kPAIRKCT219jo0R1tjwME9an46Ry2Iq2gS0BgcDFMfLJT6jcnp2a0pBpjnmnfakBYWRE+GHnA4pGxTk9J0vESL7Bw0scOJ767OVJEsQTpyERWuY1ctB4hUz0QGJoLPYwwx/2NxFCfIJ+cbT7WJb/o3pJehgykB2j9p4XM0842OGP6kKzPa9Q2p6gYLeya4/B037St+btrBu9mCC7cCVkfkuJjiCKarbEwhriZTnbWnHxSjzzh7VJbi+5Cor+/u5E9A5o8VXLyrrDyt8h+7vCuPWGj6FwnDqnlT8KVDe5nP9ySHRgl8Yz/hswUzAcCgCTmGBbN1IbXbsUfmjA6yzfUsbYYh8RGcPSrKCBDULn0XZvpWTFwdbiD9X3A61wlI8KK/pmMKfIK3e7ZItmMCcP0S/YNWqByz+AfurLtcksP7YlpH5rDS8Ih/AcU/SXoGJhs6yelTNINJdg22tNkD8U2yMlPwhdgJSfZCCyoCzML0elCKDgnYZhF7N8UoP3Al9WR1Te4D5IiTVGlrPyD4S8vVwFCF70ulI9zhMmaRsJLjrzR/pt0Cu5gz1Sx0vw+MGr5/luaUieZXwfD9g6y1eHSPr0SXYg4YeL3uIObtsDEeVNYg0hqqUZ3jzXMvGb2330qm6l9P FhLqXxT+ FyderpWzEy3vc/Q7RBhRPf+pfujMfWVUmDLlMBs9013+HDQ0yFZy4jqLWqgf7jeRGt8NbDBgFSyR4F79U4V7XWc/dTKWRhDNgcHZEFSbh+r0WLEkO8wRdtzG/TwZNjbt5JD2ynSXhHDID+tO7ViiAqmKNm/meAmM1bH+h0eRyByR7R91KPBrpw7qonQovjHHQqQgJqy8HThJjODH1kQvRqyF+UhVV7dOy3u9Qv6n7kbp0Q6lZVbubHWjCP/UL7cXw+bG+G35qNPPz7pKUSUYOw+DkKtDHOhYS5AzLMalYppBMdK0u3JU0DvXxp5vvcKswNkDqYl970OIApfKrFazitAsWiP8pNffCsuvzFLgQcu7COJTN5aE8C/K1dZb4O0yGijCAmPWLUZ1O3QRgmiP15s/X6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 11:51:17AM +0200, Oscar Salvador wrote: > > + case MEM_OFFLINE: > > + if (!node_state(nid, N_MEMORY)) > > + sysfs_wi_node_release(nid); > > This check is not needed. > > If status_change_nid is different than NUMA_NO_NODE, it means that the memory > state of the numa node was effectively changed. > So doing: > > case MEM_OFFLINE: > sysfs_wi_node_release(nid) > > is enough. offline_pages will call this callback unconditionally any time it's called (and succeeds). If 2 dax devices online into the same node, it's possible to offline one chunk of blocks without offlining the other chunks of blocks - which is why we did the additional check. ~Gregory