From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2AAC3601A for ; Wed, 2 Apr 2025 12:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4279C280003; Wed, 2 Apr 2025 08:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D47C280001; Wed, 2 Apr 2025 08:55:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29E67280003; Wed, 2 Apr 2025 08:55:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0B4E5280001 for ; Wed, 2 Apr 2025 08:55:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A7EDE599E8 for ; Wed, 2 Apr 2025 12:55:47 +0000 (UTC) X-FDA: 83289100734.13.E87B2F1 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf09.hostedemail.com (Postfix) with ESMTP id 14FDB14000D for ; Wed, 2 Apr 2025 12:55:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fNFwyfgJ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.13) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743598545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TdLDn5ebMoi5IoRX1UfNhgFBupSSImHmHddQcCj5OlQ=; b=Ldt92aaKV88I5UXNjfJNwauoeT1/Lh1KmFy/1tcUGHI1n54qdTnLYYjNaBebGUrjOm1sDI lePXRPx9C2nUEQdo/0k8KDoD0xdo5FYmhxpfc+fqlC9gQljhsQO+LWPeeHiBcmoSjEPAac 8nrfPCPqxeyYJYPaCvR2euZ7c+jpznQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fNFwyfgJ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.13) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743598545; a=rsa-sha256; cv=none; b=4UB4sDePVR5qST0czzy8g1NiFwVEIwjZP7jp8UlU+zvDstBSRthI8FGcrCDOSkDOVGXeBf ACXtkRXf6KzyQExyiprFWrV0DWfJ67Q0DsdEJQzfH8IgfvG2p5dL9ZqI3xQjrgpPz8lB5i +LvUdDQ4+nyhB5qZtqHNk/Po/3J5aHY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743598546; x=1775134546; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TXtLquoRRAqtrc02VbnTtQ9X9BjOAMh9LtUpk4wHJVY=; b=fNFwyfgJ2a6mthLIz/uhS8g/qrGGJODDEsan/EqoAXh08GKIqN5O32dl t3Cop4c1usdZaNPJTF7TPfGzXn7cp/bnL1uHFsKnbHKoRIbh4m8hG5hkN HlZNTfS5jaFrqcRL/m9gunHwtkUtIZhZcok4zJ4EZfujHGHraKeSpRduF tyrx9kCRRkZMYRTzSIt1vIh0W3OkSI3rBPMWjKhpj/vq85j3NtZ7Tpv2C q6onxcAg1dJMvCtiXtvqkudwviHiLpwKA7JkDLMEaiCDXRj3E9CqBgCBV bWgs713rfEMqISTlMdCdwALr45qXCXL+HDzWFsfuElSZqWRk9Iovr9iU9 g==; X-CSE-ConnectionGUID: pmnt72ONQlqC53pxV14dQQ== X-CSE-MsgGUID: /djQyb/YQ/qoyqodKlzi+Q== X-IronPort-AV: E=McAfee;i="6700,10204,11392"; a="55955136" X-IronPort-AV: E=Sophos;i="6.15,182,1739865600"; d="scan'208";a="55955136" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2025 05:55:44 -0700 X-CSE-ConnectionGUID: zOjX9rwPToG2JDLyvrPKUA== X-CSE-MsgGUID: LT6rlRGDQG61zNwAkljtKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,182,1739865600"; d="scan'208";a="126650218" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2025 05:55:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1tzxd4-00000008ToG-2Zb4; Wed, 02 Apr 2025 15:55:38 +0300 Date: Wed, 2 Apr 2025 15:55:38 +0300 From: Andy Shevchenko To: Peter Zijlstra Cc: Przemek Kitszel , linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, torvalds@linux-foundation.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [RFC] slab: introduce auto_kfree macro Message-ID: References: <20250401134408.37312-1-przemyslaw.kitszel@intel.com> <20250402122104.GK25239@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250402122104.GK25239@noisy.programming.kicks-ass.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 14FDB14000D X-Stat-Signature: 7oyaiemwmw1m8sj3wztt83btbj38pssg X-Rspam-User: X-HE-Tag: 1743598544-394352 X-HE-Meta: U2FsdGVkX18W2x+tVqnuU0Y9WkQCngYGMZUxxcQgw07++vUZlYGgXb5Xu4mN7wEWWGOHCD0kd3I+MONTlj7u6QTMaLX9Em2vFsH7mw+df2mHJTa3Fw9AD36CHW+Wf0AtVg6ZINV8lb9ELlxQjEDcBOS1QeeccEE3qMd1r/rhNbzmbmnaxwjwwrgoyFWMqmyAnHKVM+o0pLZt1uKLVEsXoAADt0WjD3yCN+ESK4S7tHW77gsYdo0LXxFMdRCS0QdenWJSREiDsLf2694LMUHRXuubhO+QmTmRxzJ/0W4Mqx+Ijo6OJhysxEwt7UMano4J/ngZzwWBAj5qBbh8ePlwAU7t4S/SUu03YBfaz99Zms3MZDm011Ng978h8AZiGEtHiIrWkPqI2+vPDv1uoTVmUNL2D0yhjufKMCVMBSSSjYUIm1+akZzS/Y521/N6L7asybbeQ8mwzV/MIfs23Qk3jxyG/oGOxKQT8XT4b0Pf3qKyNEjjanFBnIDneeW73jKOHwl9LY9wxXJYEUZRlYKd16EEXRs9tRma3XCFnqp2YK8CMBH2S8M7DuC9TcjrG+Tzm2yn0UY53N/SXU8QeY40eGyEalnBUVCfTzii+HMUyeoo/ckFqRTMzVchE6mp3xajPlPFxVXemuxGgWsw8ZP/I86v7lLRxV+BKw5p4iJjtFlDTa2wVSEpmE1Y/Yx4/sUeoMGcP/JZlkLZQs1ZCFOcLE5pXBF/d9t6BxtM/DDOf1MWvnRNpyizqJmZhr4RoAvJJNkaWMej0lUXufu1DHQFzzuoScxk6MoOo7Ko/vGrmtixs/fnEFB1g/We3t8rSqBhOWe7Pq2+CBxdOCv3EfBpXWvc3f83U/B/NV5Cz61JVp6rmHoeyNkYWcnnP4I8lGMzIxKknV5XD+lk5Ua5ZHto0pIr4AYfJPnLMMEJYZNfzFcipuISJPDUjOV7iAOvv4+buahBB0uFXI6R1pAZ0+D yJu1WuPG lw271AjX7GikStdScJJ4iDtXW61OPRG1iDgotErHfuyr7M9uUceoTMneu99FIWWHhV7DzvNN+cprpavW11+XlcCVxuTKe0YFI+pbRu+s6n4cIrjzvCY6mnLneGD4hgEDs/mwVBfN0m/PJ8Nab648AOvvBct3d/kma9plrc0J4LuVLfYooY84bKidbUor584GGYT69KFBGs8kguRi7UxQk3Tlf5ELxH1eS3QL/FL+h5Hbd1vNKOY2ZI2nX76vGwz5yK7r+4pZwYwRtqBs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 02:21:04PM +0200, Peter Zijlstra wrote: > On Wed, Apr 02, 2025 at 01:32:51PM +0300, Andy Shevchenko wrote: > > What would be better in my opinion is to have it something like DEFINE_*() > > type, which will look more naturally in the current kernel codebase > > (as we have tons of DEFINE_FOO(). > > > > DEFINE_AUTO_KFREE_VAR(name, struct foo); > > Still weird. Much better to have the compiler complain about the > obvious use of uninitialized. That would be ideal! -- With Best Regards, Andy Shevchenko