From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2DA7C36014 for ; Wed, 2 Apr 2025 09:33:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E4D9280005; Wed, 2 Apr 2025 05:33:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26C2D280001; Wed, 2 Apr 2025 05:33:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E466280005; Wed, 2 Apr 2025 05:33:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E13F2280001 for ; Wed, 2 Apr 2025 05:33:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60644BAF6B for ; Wed, 2 Apr 2025 09:33:03 +0000 (UTC) X-FDA: 83288589846.12.C651CF0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 297D9C0003 for ; Wed, 2 Apr 2025 09:33:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aqEl2BOc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NoAuqlcC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aqEl2BOc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NoAuqlcC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743586381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZubpHG5fc3B2Tl8fN4vFMieoIJbfo3Q6Fgo56Y28uB0=; b=b6UyJW18/QgokpPRRDGy1zmuTFGbyoVSEN71mAj5FiRfnImeFM/gMe6U1pz2B9SjgXgAtu CPcrYAQ3i5+WSbGZVnWElUaoNIYOMky3nBN9bII9I7lU5vxnnlRyBJuRUa6MD/NCHcLvqD BMZjfpIqXlMl4AktwdVLGDSX7hSenDQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743586381; a=rsa-sha256; cv=none; b=ckzuqGsiuKTkcPiOqbGC7YwQ1sFo+MWfqBY2FK96Eec5UdaJ4HtF+I+70+bZ/vYFwMmvF/ Rl3hojyS2yyk/J12+Eh31G3wxYowtG55pU9DjuJsQ7p1zB9KTuW3+K2etpgr9LhppKEBLH oq35CN6+60yYvzAHxgwTWN6dw4mnuEA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aqEl2BOc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NoAuqlcC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aqEl2BOc; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NoAuqlcC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7BA8E21166; Wed, 2 Apr 2025 09:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743586379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZubpHG5fc3B2Tl8fN4vFMieoIJbfo3Q6Fgo56Y28uB0=; b=aqEl2BOcRncVLmDYO4BIDBYJLt1v3CXoJeR7MzpX6tN36mra9x1dAiuvhxA7Q3G0tNF0x1 TTlEcovpu3pV1upl2pkWiv3HyrJdlJZvpoSgqt/kXhJVBD+ay76B5x9cN8TagVCqe6knIQ NHVadcPWlcSSWolYhJlCvjea3RkRa+Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743586379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZubpHG5fc3B2Tl8fN4vFMieoIJbfo3Q6Fgo56Y28uB0=; b=NoAuqlcC1J5TLQQIrWEqxygwnebnnTekS3RbpdtiYpZEKe/l+vrIHcSOuTLTe8tT4KNLcQ qyJd7S3K4RbrHUCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743586379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZubpHG5fc3B2Tl8fN4vFMieoIJbfo3Q6Fgo56Y28uB0=; b=aqEl2BOcRncVLmDYO4BIDBYJLt1v3CXoJeR7MzpX6tN36mra9x1dAiuvhxA7Q3G0tNF0x1 TTlEcovpu3pV1upl2pkWiv3HyrJdlJZvpoSgqt/kXhJVBD+ay76B5x9cN8TagVCqe6knIQ NHVadcPWlcSSWolYhJlCvjea3RkRa+Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743586379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZubpHG5fc3B2Tl8fN4vFMieoIJbfo3Q6Fgo56Y28uB0=; b=NoAuqlcC1J5TLQQIrWEqxygwnebnnTekS3RbpdtiYpZEKe/l+vrIHcSOuTLTe8tT4KNLcQ qyJd7S3K4RbrHUCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 11FDC13A4B; Wed, 2 Apr 2025 09:32:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Vwi2AUsE7WdGRgAAD6G6ig (envelope-from ); Wed, 02 Apr 2025 09:32:59 +0000 Date: Wed, 2 Apr 2025 11:32:57 +0200 From: Oscar Salvador To: Songtang Liu Cc: akpm@linux-foundation.org, ying.huang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhengqi.arch@bytedance.com, songmuchun@bytedance.com Subject: Re: [PATCH] mm: page_alloc: Remove redundant READ_ONCE Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 297D9C0003 X-Stat-Signature: jyjukdbdm6cwuyzb4s6d8omu18uz5mk6 X-Rspam-User: X-HE-Tag: 1743586380-79061 X-HE-Meta: U2FsdGVkX18tKivzGnYalqrMs4Zq+wHETc0NKOymkjKyf9CRHzFjlIbU9T0/6oF+U3R2jsbYvJPMF4hW+449o1Yb8hSeTY+aLIh9g4wgqt2VKRzXNMmWNKas5POH3Z1Myj5+PcDfPORRocOFKhCyg0YaBS4jH2liS/FmnOwpTf/yALVvOykJBFkgl0T+iAxT9pasiEEYyGWNuHZZlcCYV9BDXpErWBqZgkp7dzpApHkBiyEn9lfhiUkALYa5Qf+GCNF/2QCDaEexiC33ShbZLwYdAlBoGaJ+T/PFho11dz3Rv8K1mVsbiLU/Dv3YCzhMxGKiipUGMK85CTrdpJ7ca7qu51chWt7KyT934sT1cDshhdk+CsrmOPoL7ot4W0mncPw52r5Bm5PVbCDZ+1eG3CIgMoP3MU6yYIQ/Cd+wLSQStDTWv9+1N0/TjSTAoUG/MnQway5unF5zIH+GL/kSVlfzIrrj/gQcB80dPD3oSOTo8VbU+OmnIi1D7LwUjKGTjUmeObc2v4nRC/2/QCM7pplLvW5XoQp8tsDIqeOgGzrAij1kQ9IaZbNe+8ptM/S9F7hZuwGsnmaZpAQzqAAHmWioyfMOCow/6/w/3WuVUeA0bA2aWmxPH278/RzFZ4W6f2R9E9d550KlbouD9AXZIw8ESkZ957OrQOBHCGmyOueIFg9enI5IqQtFF2JJgGcItHHdw7Z7QiUTWqKSnHCRdFsY0xUHgQZuVctiBX9zBGiE4ynq6FRFro9jtz97JZ/YhPSTbbLouCFicNMDPAWduc51LF6pS1JHZDSNuF3Qug8KvU4u9fLBj6gUvE9mgngv8m6kxjEcGrUyM1DZmPS2P0rjryULoR8MWSdFcD+ADnIHfZrIQMBE/WNaXsMhwPrFhdgty6A0OX6rBDQo2OgOnNLabBCPOeJnBiwB0cehvJPuhVv7EoCo6lS6E3xp+hxEiH07fQIjiYslLz3ABun tw/GRWTG IFYYUkc31FekBnpvYB8QC4YhZWBaJS5x5czlQsUhxFM3IG6XbTcD1/u54CiFbTbX5o7Rf4tO8zQdhTeaH19DSjm5dkIfODL73lI99nGeF7p4gmtOzo70/oPN+HZaQ4Vz6kQZ2bu25XVdrlaFSi9idLqrdeUnFUgWaMkcrEv0iqSaLBd7E8ovkOhtOW06v3vRgM5OGq8BZ8y999Xjg0FX2jrr3RUK2WSY9b6HSO6DUNHinMEROCzrVnNj9Gnv1w4hMTgpg/WrgXdAb4GG6BMAJvDfOJRoGNrYCLI9lGZg6y7HTTwyd0Mqx/CT002+2sNsSOEW5XDDJQO4FrTI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.014759, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 03:41:16AM -0400, Songtang Liu wrote: > In the current code, batch is a local variable, and it cannot be > concurrently modified. It's unnecessary to use READ_ONCE here, > so remove it. > > Fixes: 51a755c56dc0 ("mm: tune PCP high automatically") > Signed-off-by: Songtang Liu Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs