From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3607C36018 for ; Wed, 2 Apr 2025 03:40:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47566280002; Tue, 1 Apr 2025 23:40:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42317280001; Tue, 1 Apr 2025 23:40:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31224280002; Tue, 1 Apr 2025 23:40:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 14212280001 for ; Tue, 1 Apr 2025 23:40:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A31F658602 for ; Wed, 2 Apr 2025 03:40:04 +0000 (UTC) X-FDA: 83287700328.26.9933026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 5B03EC0007 for ; Wed, 2 Apr 2025 03:40:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DhXam6IJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743565202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+J+xEtJMcJlG1ldYz5T0Nt1741RSZ9+l6RJzgdpSXmw=; b=DxStKE8oBrOHLveyd7W3ii+ev0sAK0RY/6/X+fhhSYc+0gzU+XbcyrupJ9FLhDyYmiYNQr mNMWWpqGnJvmoQx9TAs2ptgGROwCLRw9PMvYF5TXQLgwFo9Qq1qHAw9sGp56LhuqiKGSAI aJpicjPtcRPdJvwzyYaDWTKEJxoh8os= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DhXam6IJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743565202; a=rsa-sha256; cv=none; b=kIq4US1lYFSUKHJFal6dIJVjkiQzalTb48JJkjdUx2Xicpb73xbJ1jN7l14+z2VZy7GzM9 SxE7r8OsY1P0iadR6gND7X2E1Ut5olq/840WcecgfvEx6qonYA0z4tT/CGskWziPmBdbpS +jdQ9RGB0w/hz3Gg8AxTzN8L6ISmy4I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743565200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+J+xEtJMcJlG1ldYz5T0Nt1741RSZ9+l6RJzgdpSXmw=; b=DhXam6IJWv8mvh3JfVIqe9M6N/yPC72iAMKYs58mlnZCVcDR5u+VUSakIe5vTwFaEjhc2c e1bJ14353sZKuNpPezXo5XZm0uBMDWSYO0Og1fENDxK0xIY1cG14SYhVKTgWlN75OK/OHu /hUVCxDaKgVwnPXUm/TBqRRsL9ecMhQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-r3AzAC98MI-jAJuxIry70w-1; Tue, 01 Apr 2025 23:39:57 -0400 X-MC-Unique: r3AzAC98MI-jAJuxIry70w-1 X-Mimecast-MFC-AGG-ID: r3AzAC98MI-jAJuxIry70w_1743565196 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 33A541800349; Wed, 2 Apr 2025 03:39:56 +0000 (UTC) Received: from localhost (unknown [10.72.112.12]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A4CFD1956094; Wed, 2 Apr 2025 03:39:54 +0000 (UTC) Date: Wed, 2 Apr 2025 11:39:49 +0800 From: Baoquan He To: Oscar Salvador Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev, x86@kernel.org Subject: Re: [PATCH v2 5/7] x86/mm: remove pgd_leaf definition in arch Message-ID: References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam01 X-Stat-Signature: sa56ukpbtxhwaoiohbntmzcfi46ornaj X-Rspam-User: X-Rspamd-Queue-Id: 5B03EC0007 X-HE-Tag: 1743565201-786115 X-HE-Meta: U2FsdGVkX189GtpYDp6XFhqqpT+60+ZenTQrDvocumT7SmJL92Tm0uY7SIv+HNjwguOqZf4txeVBtrbwoJ2JVUwiUq5l2aYUaR1mhGT+9ipKqdUabLEAxBWU7Tlt2NjBCX3KMZ77zuKdnKZ8cXtpv9kDOxERuhuDzo8jNfMYA4t2tr1i/XhlxPDG3KmCR2H/Y+Dxqom3232EDBOE/vZ78AXOUnubL9y+TLV+bItJRDvz+JVlER4pXGZYo5mEhJr2jgq6Iyl+wMQxZ6ebAl/ytXqaK2A+j9DbsISVNOMp53SXpFOMgpscPDnCulB4/+14oTH6j/N3Sxad1HCwGgkREKhlK6mJHzF7lQ4As4kYc/9QgidXzhGPgsVxy0Ya4Lhnkwf3B5V/4p0QIo3p6VKgwlqpzEx5NAfXdqrmj1yQmzlnMo8XF6xS2MuisAgF9JiLIKKj77eij/NlFIpXanRNPacEF1gaP3zuefzfs+Xd3x4ktQDnl0MLq1YqbFmPVRut0byb+2iXlvXrFq9Fgzyfo3O0bkHXpyBMFQr7DyYF+0bLgRycrzF4ii9xFuhEMTVs7xRyBgVUzd/1GeU3+sLBbI7Gbo9fb+oNCLvlwopG+5eiLmF8uPzU32c21vo5uMnHWthv8FfIkSArqkGjrJStQsP4c11EMr8MSF8vNx5yOIj1NbRP9hxZK/AVz2qDuJtEdFhEovfAOG0nv3VLMQlsI4EJL4AFKbgSYBSQPCdwDL4XIEtzI4SgtbN3xKypOGwBqj1lFyZbyVonTaAyUiw+sIllzKF4JWGr2k13qNlx8uDEZ661dVuo8/TUOkBrF4kGro7WnQ+plpkVrgUQRmApP37gHpRtdnog/8cUdmukCL98DhzBzkL8GtArhrEZJh0OFosHM5CsNUdQ9w6EEb7EfwBm/fwrZKdLgzpFQ+aPYNN5ko/OS1jWCbt9/lfqfsQKnYvdE9sz74iS1Loq3HG 2Xh8DVqV Sdk/d2H9/h5rQTB7X1FmV4aLjwgbxpmPKrlarqUe2mH7Rdup7XjMrry10MMMJI3v9VO+hpHd2oIgh2sowpLyEbF6DhB1ITPMLtPU4JwEFwRt3IVcWu0piNu2J5dQjUGJsR0xmib8yBmn16tx2BtCfZnAAm8u0DZP0PuYW6JKeDWsNHyjGFI8CiLONjdeFtO+rCtTQ0SuUU/yqun5PW4RkcUgESRFXCMAdRtgIoBlu/7RWifngf3SAPBPQX0N5XRclLPpgU5u8q5WPdY3Rb8+FqleRMdSdDM78v06RU22Npvx1fSFqYuxbbLp/I+JX5I69DoRy9J3aEz/n9bGK9COcKT1vh8Rbj1P/OTaRBr2tQyDb3UflgJQ4oav1LcllUf3IiQcjiA+xFqrVskTEyyXNuUpqZFeXYlG3DIITsV2KCoFeeNESTkS+zhJGgjHkhGMLbdMPDwvXjmODpv0F+U+nsClmBQf8JUKNJ30UnPST1bf0bhtng7sEU4oixQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/01/25 at 04:03pm, Oscar Salvador wrote: > On Mon, Mar 31, 2025 at 04:13:25PM +0800, Baoquan He wrote: > > pgd huge page is not supported yet, let's use the generic definition > > in linux/pgtable.h. > > > > And also update the BUILD_BUG_ON() checking for pgd_leaf() in > > pti_user_pagetable_walk_p4d() because pgd_leaf() returns boolean value. > > > > Signed-off-by: Baoquan He > > Cc: x86@kernel.org > > I have been carrying a sort of this patch in my tree as well for quite > some time now, and I think that Christophe also sent it some time ago, > so glad someone finally pushed it > > https://patchwork.kernel.org/project/linux-mm/patch/20240704043132.28501-2-osalvador@suse.de/ Oops, I even commented in Christophe's patch thread to ask why the patchset hasn't been merged yet. Later when I focused on mm/gup.c code reading, I forgot that posting completely. Hope you don't mind I grab you and Christophe's credit since Ingo has picked it into x86/tip tree. [PATCH v3 1/5] arch/x86: Drop own definition of pgd,p4d_leaf > > Reviewed-by: Oscar Salvador > > > -- > Oscar Salvador > SUSE Labs >