From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C2E7C28B20 for ; Wed, 2 Apr 2025 04:03:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1371280002; Wed, 2 Apr 2025 00:03:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC133280001; Wed, 2 Apr 2025 00:03:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93A4C280002; Wed, 2 Apr 2025 00:03:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 72DDC280001 for ; Wed, 2 Apr 2025 00:03:50 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 14F9EC0F36 for ; Wed, 2 Apr 2025 04:03:50 +0000 (UTC) X-FDA: 83287760220.04.2ACE191 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf07.hostedemail.com (Postfix) with ESMTP id 358B940007 for ; Wed, 2 Apr 2025 04:03:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VxHLY+Op; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of yan.y.zhao@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743566626; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=83ZSG4HIQm8maPS2nuj0za9TA/Z8SPhs3dA87D/wwbs=; b=fhUTN47Pnm/AkJh7ejxLOY+4M3/fU4ZK+VVvxQwhn/ig6rs4mnGpoSMbfPjRki2DEXsLUV 7SdX9F8feq1iH0CjK2ha0L39ne3s8KzKtlrVUDihb1vtlWpNf+KTonkbdI4OjCrW3ZmRnt ZyeEV7Ccs9/4pXVGz1yztDAKSohAunw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1743566626; a=rsa-sha256; cv=fail; b=u7G6zRHKfaJVKIErlAqkxjRlFGbTKXRfHf12mBWQKyU8UJRtF/WyUhN4/veEKPxanAfefC d/vcyEh7CG+RTQRUoldC//ci88Er8czDq9ogOzDyIgnXX9v4ayAq+1geLXsqd7YsuqwC8L 1TMu/qiyrdzLKihGVF1rRQrBNGnBb4U= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VxHLY+Op; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf07.hostedemail.com: domain of yan.y.zhao@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743566625; x=1775102625; h=date:from:to:cc:subject:message-id:reply-to:references: in-reply-to:mime-version; bh=HQvHlTHpZPC+cfqVpclDll00gY30nql94j0wkybu/QU=; b=VxHLY+Op2ohDs10+szKWhfe3awcwl0jy5RD1RxXT4Rg9QHVbNCRA+v50 Isrh+Dwl2i/50rDubr4mj/4sqok+QDZKfwXDEMUJYrBzZd1sensgSeGFv NzJ7+oTmYAmMVn1M2ug5UfosUQEnVFtYMl/GKajgdNuOQC3QkrQmuPxS/ 2+9tWgXC9e2dvkbKm/onoYQXTKmyPdb8487vVPwTa14v6YDwrkgfrJi+G ZfAqJ8WYaD68X0q+Ky51ANHZoYmdoRpiLQtl2chMqMYr1HR+hEx0h7SMI cU7wKMWCP4c95MGrxbkAfRwUeoeDcm51lEb3AY/Rpd3Lk/8zW88gxVtSn w==; X-CSE-ConnectionGUID: ySOrXXfPSWSfYWnbLdKduQ== X-CSE-MsgGUID: AzjDXnRYSnKPPgzEcew8mg== X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="45035473" X-IronPort-AV: E=Sophos;i="6.14,295,1736841600"; d="scan'208";a="45035473" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 21:03:43 -0700 X-CSE-ConnectionGUID: nPx0QAbYSRKZ4F/LcW5e+g== X-CSE-MsgGUID: VMGiRLyTSLWJgclwvI1BdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,295,1736841600"; d="scan'208";a="126558431" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2025 21:03:25 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 1 Apr 2025 21:03:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Tue, 1 Apr 2025 21:03:24 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 1 Apr 2025 21:03:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kmILxfcwxi93paDR/697bHZSI8wLYV1OTkyaBJOz5KSXVK21Togrm7+ftxip5R7RZurZfDYvkOiQJnWilY8egX8c1gw0Yq8ieqgV1sXVDUvsSXwRbey5zSpjROLGHt9owwdm+hBNnmsJvMI0AG4GHvbLtFTbTEfxFJE/O/GKXieDZ3GtOSLMtQUYypqn8Y9LI1gRQ/fa6+mPD6we+cedo+Q2zDlp2nuav3CAbT8VCx5/nouBnnBydA1wao4mbkkf041/w9P80gkOqjDJOxZd3t21b45OwXFs9B/U97RgEVPD90Pg8kW3Qtbmbopo4xpbERnYnJzeeIg0C3yHOuvK6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=83ZSG4HIQm8maPS2nuj0za9TA/Z8SPhs3dA87D/wwbs=; b=LK8ZgQjGqRXeQTgup4GbLn32B0u4FfvW5t1ILyVo8QkQXllIyg7ic20w/NRfvyED83FP41PH/v1CSYdJcbxm4TE2+rKNCE3h0Dq2ojrS2ftGD4gJEm4zl9rZ10xnab+7toZ/dRbs9ckBlxRUs/lKo0pd3/8RTyt5rwMwpo+E5fR+oGIjIc2n29GyEqwpY1SFfqVQub/93RqxevSR462wec1Casn/ZtrmNbNl6q07ZxL+6dpWAkogj/d5VwAWAuN67xyd19hjZmDVtUr/kctiUvLk0vgQjVCaC51b2e/rh+dlOgKqDetJ0chvOJeyPXtg6TAvLcQjWKZlUbNz+yGpfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) by IA1PR11MB8863.namprd11.prod.outlook.com (2603:10b6:208:598::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Wed, 2 Apr 2025 04:03:21 +0000 Received: from DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::e971:d8f4:66c4:12ca]) by DS7PR11MB5966.namprd11.prod.outlook.com ([fe80::e971:d8f4:66c4:12ca%6]) with mapi id 15.20.8534.043; Wed, 2 Apr 2025 04:03:21 +0000 Date: Wed, 2 Apr 2025 12:01:33 +0800 From: Yan Zhao To: Ackerley Tng CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH 13/39] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes Message-ID: Reply-To: Yan Zhao References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SG2PR02CA0045.apcprd02.prod.outlook.com (2603:1096:3:18::33) To DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR11MB5966:EE_|IA1PR11MB8863:EE_ X-MS-Office365-Filtering-Correlation-Id: 6572a3a6-457c-4ea9-e059-08dd719b4eb2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MyAD6eRu1rVDAfy8AHeaH6wv0wQmUtUKED882l+rdx1noe1mCtXC7omZsPEs?= =?us-ascii?Q?3pYJ25wOU61atCH4uo4Y/L5pAvj3JDRmFnI53HNmKUfpIadPsnm/yZznx1ey?= =?us-ascii?Q?qnrLS6OZqgUbcLfzRgePu2CA2ygr1FmDfwd5PWk9NVbBN46bsDj1OBFO5Oj9?= =?us-ascii?Q?6WAqS8iUDxn4Vu43yY2sYT60ddW17sbjt8QTQh6knpcLI5xgOmfEL32ZzewG?= =?us-ascii?Q?jyrQ8NWlTJor9A+neO5YXusEtmovXTAiVMjFRs89SNvPWF/iI1Z3bW/M4GS7?= =?us-ascii?Q?tgERs70XCpqWMizS9nH7t5dc6JXRYrqWtZENkIjHQudn5wMvz7uPJdGo/1lt?= =?us-ascii?Q?/Q3SB9YE0f30P6dEWEbFS8AB2pL58Yk7NK4vWY2N8VPbHQYIVDvBGaJ019Cc?= =?us-ascii?Q?g7XXylMOeYTd6auYxCqdGMK65joJwKz7UJAUDmoWdpx0s8Ui3uh7SQhhFQ9C?= =?us-ascii?Q?hOQl3qtoZ1xBkHWYAR2q/C0YkDZaIi4aZD9KBzUlfje3sFC7nGP4tmHDBYSC?= =?us-ascii?Q?Tw8W0IB/lxE8/4rvT/zbyv5qq42W8lMoavu8CV9u+6X0WxE4mLxYQkOY1HEo?= =?us-ascii?Q?4RAvifKQLdG0FA09kf+zZweWokkMC4Znq6/CqFiL4P0EyKGsL0LHVr9+acSo?= =?us-ascii?Q?fH8RGdKVvhKK3ezB0oV68ZVVGxo0unv2eR2SjqQh92gL25TcvgLcxHq5frl2?= =?us-ascii?Q?0sO248b+AHemcq69TsZ6B9c5+2fyvWPJ8LAo3xBuhxqZ1apcs2pO8qRxnQ88?= =?us-ascii?Q?MBdHetBmGdObB2+LehaAVGxP3hBCYfA+pDX+fHItgf0/QRrMy+j5WPtN+XmS?= =?us-ascii?Q?qnq9JKc1jpIRZ9VFwyW+12Atf50Klk7reLb/9itHXT/Wv04h4xUcvUukcYKf?= =?us-ascii?Q?emQNv/BGoJD2Z5Uc3KEIFeJcdgDi6wo5zwAEWF7xMcoj2qT4onnqq5uQgpM9?= =?us-ascii?Q?InB82/S2zrVVdf7P919gzn+9mgfWEaxtenX6RvxHT75yg1jdruWQoBDt1i1J?= =?us-ascii?Q?20z3MDlPg8qoElewRnfWbtaBlvTWJ78Ty0CJaj4qVK42CVFchYTa7UIbfWZg?= =?us-ascii?Q?bfE4FKUKOeHV+InqcEzAwDcg21+uHxCN9mExTtqcUw6k4771HzNcTWeuXKvo?= =?us-ascii?Q?KNP1p/GxT+0c7vRgGccDaOWCzdIUcpklvO2icQMVycogBtNNpwNGvJiUQnhe?= =?us-ascii?Q?TWuolVOA/pNhfCymmzOQIoIg6jpmBGmrgA6ZMX30+n0BW6WKtCU/sc10D/yV?= =?us-ascii?Q?PdIPV33ihSgte8nXU9ogU9eH+WYoSigopDtZuijgI1HdxakbbAmTM77Q+GbY?= =?us-ascii?Q?y0i6YjmEpNQKR8BW16FI4clc+BkAmeLNX7BBFwjwThR7X0tfKiVnEgTX2WVK?= =?us-ascii?Q?qylAPKq9qxnzvuzhwBps5szdzMuGs5zc4cxzTSArkkbCNPRfiT1ROMKyzaOp?= =?us-ascii?Q?ogbGLpvhwk4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR11MB5966.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AY5qZ+oFlGPu4cXON/amNgF/P/eZNiWN6MKfSq+bOV9/zHXZluHDK55V/695?= =?us-ascii?Q?gw6+unqojZnL8qj8JB/GYNDXTo+71pGrC/YGfah3UEg482IeIBBwDrOMdTnW?= =?us-ascii?Q?1Qvysvp36IaI9q9CnBmsvMLO1b4H9RB1WNbJdKkMx/fH6goY3LEyow4JjKls?= =?us-ascii?Q?sDZ8zEiw2ST0XYEXgTXPL706xYLbrtxnZO/5imBm24t3qzTw7bd2fvlxMrR0?= =?us-ascii?Q?vKHGJVbkIDyxhbSnlcmL6VG/A/RqCduK1Px2BBad14iA8Y4yewWAFwlquokj?= =?us-ascii?Q?g18H5fSkgEGx2Q1hfalUKoSv+evTXq2Z5fag7HjbnffAN6mMVKUy4HjKHn7V?= =?us-ascii?Q?x47Eq+MrKt2YDOEFYQ+sRsriLMwhoBquHoZDq+VI9G63bcWmSZKgFBXtr1QC?= =?us-ascii?Q?hqC4mDNxNhtdOkL69qsh3hMOOPjpZBbba0oI9KGt7rmT89b/E09kdZWkNL48?= =?us-ascii?Q?WdUz6QAsMKlplAgCbsArcmGjWW311ydnqW1jqM4+RN9pxYcvC+ukXlfKtMmE?= =?us-ascii?Q?QdbhPtS6sET5uIoKXEBHZJQLXWWUjyeFyvT1BEkZw7+B1zSvuc/YSOYKruxI?= =?us-ascii?Q?lFEVsSnuRwz+S6dtejBZnyXIc04cBe4b4s4d3kcjL4yTijq34JAS3BexWa1e?= =?us-ascii?Q?wKTMNRwW1dm9rzTThALs9F2TZe70BYXatMBkIZhajCyMpWtJAm3m4XInwuqb?= =?us-ascii?Q?HVaqyMW5Mi4aM28uETwaoWJ2/O0BHyHtW9DRQbLjFIuE/kB6K9dyX1vf0eqd?= =?us-ascii?Q?BXpATbfHaADgcJmLJ9VxixlXSeSCTvBEUoeEttxk/7ccif8tG9F1C6f8xZmR?= =?us-ascii?Q?K4ZZ7d7zGSuXVVpBNXD0KvMj2zT3Vd/9QSgntmdKnAPy+pq3pQY/GykFqbVW?= =?us-ascii?Q?0DPdMfUdT3aSs5pBfONVHh6BuVtTklrM0xK1AtuXTDQTDvg4MvbDmNFmsC0J?= =?us-ascii?Q?Bb+sN7YRsUSRncZfkA+zIUtvqHaEng0OihE5r/zSMg5Th+M7vWTaTbEwSSIK?= =?us-ascii?Q?hEW9EGN5nWIBxelkk6LmzNpZ56CqwIlTbZo3YfSTnQhtaCn0EAqjmrAHaQNw?= =?us-ascii?Q?xuIOhtwTGChiHKLql/erhC35N7iKxW0YJT7rq7PYbKIR2/wL+4KOv+/+hYQJ?= =?us-ascii?Q?dYmCVkY6TdCm8uKuALrfdLy6HJESoqf4a0O9Gs5+7nN5CLbobfgeA6epNitD?= =?us-ascii?Q?ZGKFEWPyeV5FL/MnD4oZry9CgKBFCqKc1l7IYhMpWvwscQI/OIBb2kOHcz6b?= =?us-ascii?Q?WvRKC7yTVuH/qudz5TLKATx6gW5IXO3bOZyGZmxip60ktX2YYatSDTmeCDaa?= =?us-ascii?Q?W2+dwV0IkgWB3ryyYmm8lY28vmLepJSkiYF5Ko0EUgvB+YPUQavTrjmE1eIt?= =?us-ascii?Q?YJHM29OFo9mowNJ+0tE9OR01MJIxJKN7huII/IFplJl9Z5nDZGGuvH8sN9YV?= =?us-ascii?Q?rnMOGfUb9Htw3+lUQ0hbwmYfgCV4WrvZ7/ifqsWX2Xm4iO3XHGWW7rcNTExo?= =?us-ascii?Q?vgMuSHEMFBtikwbTbf333eGotmCof/WXAFYeg3C1YuTqE+cON1nS/Vq9GlaI?= =?us-ascii?Q?EOpMgm+D5jN5yd/rdD7UX4it0GopW8x7o5clE4pI?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6572a3a6-457c-4ea9-e059-08dd719b4eb2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2025 04:03:21.2323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bChjQPRGswoCu2PGpH4dLiJGUMLy1U0yQgfDoIaZRV1rilOcHsCVN7E6ZXw6SOLWA5R5rl3ga5rt8q1ats0Qdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8863 X-OriginatorOrg: intel.com X-Stat-Signature: y78zn675tgticgzjes7y9egd674jp45g X-Rspam-User: X-Rspamd-Queue-Id: 358B940007 X-Rspamd-Server: rspam08 X-HE-Tag: 1743566624-997605 X-HE-Meta: U2FsdGVkX18BoeQlkZh8jHx7fLKqC8fjUIf4t3KQcXgXjJAvQjWYqpCAFUev7cMjLhcLTPtri3FSq6cwDNOo1Zy8U9bBDbQSyyXlrWv5fYsXkbNyOJfStd4Ns7FTNlh97tuQ3CH40/8F2YkFZz583vdvGbum2lJ9MHu1ZdpBZT79l6oddniYbJ/Q5NzsIvawCxQ46eRclmQfR8De9nfYinniEalzpYDuns+lzjuJDzYGmu6AdtM1/omJB5s7Tr7xsGPsXny++qot0+2O7TjBSRouUlimZrlz7XQsV0oZiCWk+vD/mIU5vP7GVB5oSYfqW7S7r9FhZfc7RwQmOreDAvD0qAlDECx3gVrJLm6c5IzEdRYNp9MaMucxmdfI2y6tl/Wdj0Y0lCM/2OB60DUjDKkKw8ECdYzPwU16VKL+XSKE+xt7vdCdVf0uWoHpFM1xYwHa7drRkHiC/KlaaonJCZjNwkAsYbtjzWlFR2z8/4wRgx6Ifg3vqpx6lvK3gcZHxjyuFCCoCC2i3N4qNOKlWoLSjuJvEuQmo1xQQFWRRGlF9AxGUNMC8HPlp3ZizdNKSvCApa/jrlzKrOSIcQFPMhWrhGgkjJGozUoFOqnNI7G/LL4bz54cvNWPhPmZkdTahNrSHb0gkA7P/WLLxFnApmhjFgcvZwWRScPIKYmATpdtIB3x08QH/mauwlaTJOUOPLFcv+qDe8C/327Xb8z4mFS+Xc6y3JYjE3hZgw7GWgXdayfhaAnXNOOkrXMWoJGi0aJLJ+rsOImfrhdXwsJTwONDLVZzRx7mXhfrhF1xKxLzuNclpj0eeNeh4xYo5MTh6K7hjtYqd2cTgvgFX48zaDd9h9zITJQBaULsyURSBjqjcM8Zy4R9pZDkWW7cVV4ms1hM3MctrWSbkULRghH6wyuE9Gfcg69SZNFe33RFzJAFHRw3sRx1PW473yWb26IFH/bNHzLruuEBa9lRVZd AWJeWTEs 7eBD5UwPI+GzbV87Kv0Zec1aq9HKb5HRjqvb3iSRxq4YcKYrMagRIPip+tfxKSoS/sSgF3I5LvsvZ+ekG6Ujl3EojhSbSNphjdju9XRxRnsqgl9ODC2R315fEgHbRGNm6fCduhYSfEWttdrG5jldnNThG+ZJWPL2eBpYQnj4MYYtVM8bwpvJiDFAH5VGfunMkRNfOpVYMtYe+MMRKJXU53nnEvFGMlJmbI0ZXAPBRzvVS6JbPXUNGAz8dHwk5bXzz47gfOxsN290Wob/aR82uv8K+x+JpdCXtdfDres35gd3w+etMgkS+Opl9cFIzw7FKHkHQUtmk97nFmr9oKQJ7vv9aQrHTHaOz1VoKnM4hZH38xj/ZEeINYQWGak/fA6xp9mPoj4OTGOPofDvxpyK+b7J0YeowLa/fjjLiFYguoJ6eqyg/s8jkmUzGkL9WaJ7dmOgvfvVoDVQ5R5CE0c6K+tb4bBGo20IpU3+ViYkJDnvG8654OVQevAwDF8zz4Zez47hlnrCq0BkSBZfJxyj6h65ayIEKG82ZooBLWMLRhrGFR87nOSvSzPs5vGQ/4GkIwN5pXd8JE721P1SPjG+FUo1rSzpZuoGEHVWSyeIZoR0aAO4MeQ1R+bwVZdRrlHET2V8MtQmcGtLuh5okOPF093N2O7BeUZxpBbqKjn758qLBKuOma3k/AAdW4LezKNMHraiW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ackerley, Not sure if below nits have been resolved in your latest code. I came across them and felt it's better to report them anyway. Apologies for any redundancy if you've already addressed them. On Tue, Sep 10, 2024 at 11:43:44PM +0000, Ackerley Tng wrote: > +static void kvm_gmem_init_mount(void) > +{ > + kvm_gmem_mnt = kern_mount(&kvm_gmem_fs); > + BUG_ON(IS_ERR(kvm_gmem_mnt)); > + > + /* For giggles. Userspace can never map this anyways. */ > + kvm_gmem_mnt->mnt_flags |= MNT_NOEXEC; > +} > + > static struct file_operations kvm_gmem_fops = { > .open = generic_file_open, > .release = kvm_gmem_release, > @@ -311,6 +348,8 @@ static struct file_operations kvm_gmem_fops = { > void kvm_gmem_init(struct module *module) > { > kvm_gmem_fops.owner = module; > + > + kvm_gmem_init_mount(); > } When KVM is compiled as a module, looks "kern_unmount(kvm_gmem_mnt)" is missing in the kvm_exit() path. This may lead to kernel oops when executing "sync" after KVM is unloaded or reloaded. BTW, there're lots of symbols not exported under mm. > +static struct file *kvm_gmem_inode_create_getfile(void *priv, loff_t size, > + u64 flags) > +{ > + static const char *name = "[kvm-gmem]"; > + struct inode *inode; > + struct file *file; > + > + if (kvm_gmem_fops.owner && !try_module_get(kvm_gmem_fops.owner)) > + return ERR_PTR(-ENOENT); > + > + inode = kvm_gmem_inode_make_secure_inode(name, size, flags); > + if (IS_ERR(inode)) Missing module_put() here. i.e., - if (IS_ERR(inode)) + if (IS_ERR(inode)) { + if (kvm_gmem_fops.owner) + module_put(kvm_gmem_fops.owner); + return ERR_CAST(inode); + } > + return ERR_CAST(inode); > + > + file = alloc_file_pseudo(inode, kvm_gmem_mnt, name, O_RDWR, > + &kvm_gmem_fops); > + if (IS_ERR(file)) { > + iput(inode); > + return file; > + } > + > + file->f_mapping = inode->i_mapping; > + file->f_flags |= O_LARGEFILE; > + file->private_data = priv; > + > + return file; > +} > + Thanks Yan