From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FAEC36010 for ; Tue, 1 Apr 2025 15:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 113AF280002; Tue, 1 Apr 2025 11:29:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C138280001; Tue, 1 Apr 2025 11:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF054280002; Tue, 1 Apr 2025 11:29:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D0909280001 for ; Tue, 1 Apr 2025 11:29:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05DFAA9AEA for ; Tue, 1 Apr 2025 15:29:26 +0000 (UTC) X-FDA: 83285859132.09.ED9CB4D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 294FD1A000C for ; Tue, 1 Apr 2025 15:29:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UnV4nJMj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743521364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HH/4JQ4r4zo0wso3wm4glOAGXjIB2EKvoza2FcZ9PAI=; b=ZyagtQQQMBjnCyJ70qB1TK2aZl5b1luNobrBLssXCTyHpTGDhPvnRB8hO47NE1JEGD+Bgm /bCJ7m8kDM9ttx5kwmqqzjfocLBVeZ276WFNk7OkPNfLlV7jSVTRrfCwR6Y8anKADO9HqM fMvTvL3rzVLTc5VGpWPNgSQhebGT5p8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UnV4nJMj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743521364; a=rsa-sha256; cv=none; b=n69pMQwrKJR650gBc7fKqon0pIo+jxZ4Re+UyCGRMbQkjVvlONK2Okn/NJ0S8SMJWbQ9br bY5ceMTpPEl1oi7+9+e2SktKmEBeFosch511pFYKez01bBDoRc3IBkQZJlMCPk4MTDwbTF Tsdow1dZaFkiTZZWjQg2g5yuygSrViY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743521363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HH/4JQ4r4zo0wso3wm4glOAGXjIB2EKvoza2FcZ9PAI=; b=UnV4nJMjC4QDRQdfy5Gi3he94YL/svi4NwCjoIThWG7ST9qyKV1UV1BDpQCW/1WrSgAp1j Czj8PpXK9m5/P9ZyeqEntAuFhTpyAUugFL/HR9oPSJpluMDjEswQgSsxey6+n5sdsXGRik abEby3DvVa3MGTjG9oUtt2OVsyHwX5U= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-UhwevaWENMCms20j00qm_w-1; Tue, 01 Apr 2025 11:29:22 -0400 X-MC-Unique: UhwevaWENMCms20j00qm_w-1 X-Mimecast-MFC-AGG-ID: UhwevaWENMCms20j00qm_w_1743521361 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D4C471956080; Tue, 1 Apr 2025 15:29:20 +0000 (UTC) Received: from localhost (unknown [10.72.112.12]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D4DF1956094; Tue, 1 Apr 2025 15:29:18 +0000 (UTC) Date: Tue, 1 Apr 2025 23:29:14 +0800 From: Baoquan He To: Oscar Salvador Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev Subject: Re: [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked() Message-ID: References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam01 X-Stat-Signature: xkyxdu9t951xm4ws6sqqnw3wacsbmox6 X-Rspam-User: X-Rspamd-Queue-Id: 294FD1A000C X-HE-Tag: 1743521363-886349 X-HE-Meta: U2FsdGVkX1889AGf8Z2WyBLER3c0QwUG87bzqmkslUTOasJjGJf6aONehh3iXeES6hhqF8gDV2WKhJkG43V1RrKjO8206bdYPJUBz0QEf2Tx/ErabWOzg9RjEMC+Kq0GXZ8GuOso6OCbpNNtHzhyY8P8cnixebd7TKEypt3tPhboEYfcy/6Pb5VSUfgDgzgSOOqURYRt5PiWcjbZThRDPpFCco0nMnLEiAoJy0Xs2AGBh2DFctr6jFyFNS1zCZa8Tkc9gH1mnFc4/5jArq4RcQQr+pJc9hq1CZx62Fl6LoZbKPJUI7gNh93giIS7wJ8PbIP5shEBkM3oe8TAr2tO8HYSpjjmW/W56jVop7lATYmtNKPJn6kV2RqMcslnvZz2h+3i7cD9m7qjXuFX/GWNxwKmNfwG/v3/1m7YpgTY2da3H/UJE99O7udd8InXrVarNkRKxjO7/ikNgiEseBVRk+B+OhB29yoyygudLfmEwHgVYmR4exX4wKbKvmw8qP5oW03BUcP/IZLH3v4pk5i41N83X7aYcw7Tudn9nQBMRllrQKU14hZA6k3gCfAhHlkgEF8+CAZF9l3MZWY+fA0MJJXbiTlDYMgm1Z0JQcILEKWJHbTowaTy8Dyl50KqOhdl+NHdtrmqI8sCA4RJisB822EJ+SrL/agB4yPaFUrR/AxnvGhdjbU8B99xGSiFVJK1eJptXz55TDEQRemIUopuCSjuGmVi6l+Yg652ldMxUeEgcdfr/C01IbR2tca2RUhTSmCreLrNrWli6TAzk0zjlM3/8ILJgexGiKUzHoUHaEXZeSaIN1jCW3NpFuEjcV/QWvaPR+5S95JcQ/crPHbOOMcIwAHgNOYIrkpymcuJPt2a9vYJmxxu3Hdm1R2NMGlInCZ7vstfWbBBbPkf7dzQOSb4UebiKeP4t1nCBLirh8h3BvyEGja3Ypn0GZawai4hlih9h50j3hUOrCkUnmn izni8z8R Qpa0AbFLQrpgJ3WxbE/4WLztTamUPnNro3Ey50Nxtgn+FWGJ6k3WV3SRJp3vXiWs6L/7XEAsgevlfUlkHzwSFKFTG1/oybLaFxQqlHHAjG5Qu0SNsxh0UTnfT9kTesKF1VXLFopJf6cO+04JxT5iKqS8RdjKug4ptGltVOW+93nbF3HCfGeGAaalpqaoLT5hN1rx3xpA/f0Q7CTVm5/WsmAkuTSxm1BoDF+lIScjnCBzP/rYp4n0NC8DOlyRJawMvipPey5Pd5Xy9yEZnj60YCShkA+kfh96ds9xkc4tYsVefn1ihBsiPbV7ksPw2xfE1w8QdlvYqfSrzzzyLh4j88bsjlbsRcv8JFUappmBprg0rdhDcOnni8KY3Kz/l74eGzGz9f5oJzvdFoNVDKBlM01y68Ie2B6KYXb/zhMx2vWYmkyhPbcPs0tidkiPoIOpQKmCfkedLmRv1MFX4zm9kML2wV6ocSePBPpg/xYPqoFgH5/ySorjmzyiLGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/01/25 at 03:51pm, Oscar Salvador wrote: > On Mon, Mar 31, 2025 at 04:13:23PM +0800, Baoquan He wrote: > > Since commit f0818f472d8d ("mm: gup: add get_user_pages_locked > > and get_user_pages_unlocked"), get_user_pages() doesn't need to have > > mmap_lock held anymore. It calls __get_user_pages_locked() which > > can acquire and drop the mmap_lock internaly. > > > > Hence remove the incorrect code comments now. > > Uhm, I think this one should be dropped according to Yeah, this v2 series was sent earlier than your comment in v1. Sorry about the mess. > > https://lore.kernel.org/linux-mm/20250330121718.175815-4-bhe@redhat.com/T/#m1aa161016ab98a6d85bcb657a729e01cb98763ec > > ? > > > -- > Oscar Salvador > SUSE Labs >