From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 881DFC36010 for ; Tue, 1 Apr 2025 14:37:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04109280005; Tue, 1 Apr 2025 10:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F317F280001; Tue, 1 Apr 2025 10:37:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFBAD280005; Tue, 1 Apr 2025 10:37:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B8AD7280001 for ; Tue, 1 Apr 2025 10:37:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 54FF6A925D for ; Tue, 1 Apr 2025 14:37:00 +0000 (UTC) X-FDA: 83285727000.26.48B8513 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 80201120009 for ; Tue, 1 Apr 2025 14:36:58 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DNWZou1U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743518218; a=rsa-sha256; cv=none; b=7BI3XH5ur5rLO/kR5CwLlOIBV9rIKkCtsLE/o7wry93frSQaNHLvlw9IN4o9r4ctXtnrrU 9S5Vv6Qksi1nakOPj/zjPWlESM2daqg0UXt8kVYNpZ12z7HrrkUKJ+cTApjlluluJFOA4b FQIp9h9fePk4qFaeEeZQH+ADXxowwr8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DNWZou1U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743518218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p0nwEbr1i5QCHW7pXFRPuMLsqc1sHlt5ggcgJOehko4=; b=WFJ65mS6Z8xC+yBdjXIX0iaXi2niHrqB3ZQGcpx7L/D7rGq5qHwIUECZflW1G+/XZMPOkb JyCkw3it3+hlpnI5oPIC8qAZw3nus5afJwfeB8afQwZ7IWj7QROiDaQgGcbGIAKOr0jJ5s dJZ16URrcEzfxGKi8nB63h54UClIgxU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743518216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p0nwEbr1i5QCHW7pXFRPuMLsqc1sHlt5ggcgJOehko4=; b=DNWZou1U2AXpqAYecyJtjf+6rkwT2rRybZD82Si3Ffq7LJJE2ij1rhQGxKbxkkYDmVi90+ zUbLBLtdlUT8lr4Tu1BoT/AyDt63JlxM4mDRBNBX1ju90txk0izxY7+DDajPwvdS1z01TR xeAJ6ra9SiFuJerPtiZp3LOHcrIMF4s= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-sBap7uwiPFaVUbpy8Rd-IA-1; Tue, 01 Apr 2025 10:36:52 -0400 X-MC-Unique: sBap7uwiPFaVUbpy8Rd-IA-1 X-Mimecast-MFC-AGG-ID: sBap7uwiPFaVUbpy8Rd-IA_1743518211 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 123D71800EC5; Tue, 1 Apr 2025 14:36:51 +0000 (UTC) Received: from localhost (unknown [10.72.112.12]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A5A931955BF1; Tue, 1 Apr 2025 14:36:49 +0000 (UTC) Date: Tue, 1 Apr 2025 22:36:44 +0800 From: Baoquan He To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev Subject: Re: [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked() Message-ID: References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-4-bhe@redhat.com> <6203a9e6-8dc1-4b36-aa2c-41c29487812c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6203a9e6-8dc1-4b36-aa2c-41c29487812c@redhat.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 80201120009 X-Stat-Signature: 78etjbfdgqgaji3xh5dj9i37nfw57kps X-HE-Tag: 1743518218-794216 X-HE-Meta: U2FsdGVkX1+x82Psk4zFUhslSXedyu1sQxrjzbQV8PM2eNctiTD46sBGrwAZauGRxX6dKq8jctSq9F6qNtJg1vFBjEK3oBPEaNYwE0GRpRYGnsiCokcQjVP+x+yh0AmkvXmPzdAjFK+yleArH4yW5nefptcCKPFBotFBit/a/lMdbjmmV++A4nNhnEdKatPKudULFTyYqjx4mVA6sjmyJlENUV/UGnbWGYuxfSI0nk7vuorv4z07HrH5Hhe90bhMTNRcNJuGBQrOb8bjXmx8sBK8T9G/9XNhCZIiticYjwJdjSdBuxsAy7n9IbEXvG2KwxLMt8gWB5FZp683fuAyawpyfYb7JPDbqQFXFwMM6nLsyvQ42ZChk4hUFDnaFsmArMAE1I4HvoBe4Xv36ei80qxqkUjp2b/Nx7Slx3Xmm4uiXC7/vCwS8iQJn5dtFsODouSfj7y+d1OIRluGVUzWwzv3HWEUMyJXdRAHf/kFf7aU8pO+rwNbC2IGZe5/A0Ot8Lu52kwO5l1Es3c5sewT9NCvlVbaaVID2gshdpULshaFV3N9Mhpi3HN8zStP4djdv1Vk63ZUbp10P5J/AL3Z6ChKR3FemVcuQyAMgBe0zqZqt5yeZfgz00j14BqTt4VTQPIdUKspmF+ayJC373SjOxwGd0V9OENqPCfiTU9sA7cko4+4KgCPdySWSlxid1yjxHwNHXzVKqgQ14ajk8MzqpQsJ3TAx7snRHigkzypzRFWwyAgk66nTrdXsw+P/fmGUEpUfUB2naRAl/89miEb/hMNx674/SifizBwcHAWMXAw0AhUupMN2Vah0yoL82aZ0cKADak/tHj6CRomF21D0bf2e7z/u9uI9EkA8tcXcZvrGFPBe/IFgjhFoWMwB0lqlyJfYBWJdNFIsOUwd1HzIHqMQYiKg7UkAqEfHlTy1kTeP6ZExiqGWFd2PVoIazCX+KwaylG5Y5fRZ5lqRiF QNa3j3gc I2ch43lPna3d2YH5sK2WJ2Xhsh4Qf4DpJYU8QEs6smVpe3HDJSGx7EdfP9hpqKeNcSSVEfNZwToAHeva4UbmajCZ1JU9f61uCF66RPflE3POVihFBbTv2gS1zBCnHnRSJUSo+DUIH06XgM1ycCaemRGNotBXNvOJz9MDgfN+R7oDoOXuG/1xAfsuFIKlKNUGErYAc/XD4GqCfCRjcrlweP3tSL7g8Uo9aZ+8l2Df3/Qjd9G4+65rF0g1KnOj6irF6o/Prftv1bzSOg1etcryX3mM/uojsIi8mC6960JsxROzd8JQBseRYz1thx1lYhhWQtlBiXx9HZC5PTq7p8CLjT9q7/udcK6Dzdcya+/iNH8ywEoib90GR/BgFRes8JPGZ5l/URo4J7yl6KWH/5e3C1ntFT+ctZa1mz4a+21HyhMuzuwp8r1CYy9F80VFriP8Xi/p+q67R4GomKsv1fmGQ6ojUVM//HY1EjxbT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/01/25 at 10:14am, David Hildenbrand wrote: > On 31.03.25 10:13, Baoquan He wrote: > > Since commit f0818f472d8d ("mm: gup: add get_user_pages_locked > > and get_user_pages_unlocked"), get_user_pages() doesn't need to have > > mmap_lock held anymore. It calls __get_user_pages_locked() which > > can acquire and drop the mmap_lock internaly. > > s/internaly/internally/ > > But your statement is wrong. get_user_pages() must be called with the > mmap_lock held, because it sets "int locked = 1;" when calling > __get_user_pages_locked(). You are right. I missed that line. Oscar pointed that out in v1 thread. I will drop this patch. Thanks.