From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F36C3600B for ; Mon, 31 Mar 2025 16:06:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56285280003; Mon, 31 Mar 2025 12:06:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 511D7280001; Mon, 31 Mar 2025 12:06:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B305280003; Mon, 31 Mar 2025 12:06:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1A225280001 for ; Mon, 31 Mar 2025 12:06:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DAEFC57BFD for ; Mon, 31 Mar 2025 08:59:37 +0000 (UTC) X-FDA: 83281247994.15.F27A4C7 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf28.hostedemail.com (Postfix) with ESMTP id AABA1C0003 for ; Mon, 31 Mar 2025 08:59:35 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="P63v/gXs"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743411575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/02MeeTgr+edfUre6+XCDI7lrRPKBNs5wpBz5Bd11FQ=; b=aLp1rnQHxnQ9PR+j+RVokD1gfI2CSKjIgipsYrNwFOQCFaMU3CGSv1YtIYQlysy0c7Qb2n 70yChbtWasCg3UliGjbd0ZgUXQ1hZ9Ur+B6GYReP8X+lv01QRYEJIxNHb419CTxKAMeE7T GoPbqDKD27RkoF7lPAKYWm0Kclf07GY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="P63v/gXs"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743411575; a=rsa-sha256; cv=none; b=tu/YKrlO7cB58o0RkuaNYFWcJa47zuTarqM8hxS5A5sNnm//MIJh8xSFeXggEXLS9DqW6+ Ukr2wKZDBKS1EEUbsslvUsWsRAqCa3mM4pZwY10/nBU7hLeA1VeQRhrDUV07qX3oFXvpEL pyemlZ3cJDTNkQknEm4LEPzu/MOx7oE= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52UKauVs020777; Mon, 31 Mar 2025 08:59:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=/02MeeTgr+edfUre6+XCDI7lrRPKBN s5wpBz5Bd11FQ=; b=P63v/gXsRF4hDLy7ssEBBwh/kzsyGiOtp0mumcM5+A/LNj gdY0eBuzdPTmuXOhURZupJ1YyCReKhjV+btHVIxdh6bjRaJyvFsMnji9ym0MycpW FQ/tEiPUhIT3tmZjgUk0k8RfDGEkMM5umV5et3jPN0aBemzHNEpTH7otsAqg2D2s IgiQKjGXwzD3QmqVQYFZ00JQ3UFfmml/HrvUYzWU2spcPKwRznX4azB8E9B4uB+1 1QpX2jha71AOh/TNdKabH257Nmy0qCW899l9HxKC4fFcsNGdaAqFdrftLmaLGGiG 2KPUxEHGLnOeqqSwgqWBfYVrpnKHZUpIb/RQpJew== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45qd4q286v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Mar 2025 08:59:20 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 52V8pdhP010589; Mon, 31 Mar 2025 08:59:19 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45qd4q286t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Mar 2025 08:59:19 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52V5GId8014560; Mon, 31 Mar 2025 08:59:18 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 45pvpkw19g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Mar 2025 08:59:18 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52V8xEMj54460792 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Mar 2025 08:59:14 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B244A20067; Mon, 31 Mar 2025 08:59:14 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7D62920065; Mon, 31 Mar 2025 08:59:13 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.74.246]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 31 Mar 2025 08:59:13 +0000 (GMT) Date: Mon, 31 Mar 2025 10:59:11 +0200 From: Alexander Gordeev To: Anshuman Khandual Cc: linux-mm@kvack.org, Catalin Marinas , Will Deacon , Steven Price , Ryan Roberts , Madhavan Srinivasan , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Gerald Schaefer , Heiko Carstens , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 1/2] mm/ptdump: Split note_page() into level specific callbacks Message-ID: References: <20250317061818.16244-1-anshuman.khandual@arm.com> <20250317061818.16244-2-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250317061818.16244-2-anshuman.khandual@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FB8uw0hSchlofFmG1jPA1lzwCpmzLf0- X-Proofpoint-ORIG-GUID: 3iKHP7Q1z45fUexTKfPdZicsNHs_J4-s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-31_04,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 bulkscore=0 clxscore=1011 mlxscore=0 adultscore=0 mlxlogscore=741 malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503310063 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AABA1C0003 X-Stat-Signature: okp7b9b6us5kror18uajf6t1aphxgdrm X-Rspam-User: X-HE-Tag: 1743411575-949802 X-HE-Meta: U2FsdGVkX1/L3LBBvfYlNo7f7265Z4nLGVq/9Q8IEiK+xRlgFa0+jZJ9vUSypDyY8EupLM3vOMDo7M6wHVwFL1Utl5ODfDLTavDkLFNgqezXBb1aE6SLjOmoJF7z/Kf698r+spQO0zp4vywVJhYhvOCVWGiAESYuvNgtgvkjOQloNQZHVo0ZRwPD0XDIJU4ENRpx0Uq+7FV2aicuA7nqXCQCZNgTXxmg6LtVo2UjliGMV1MYB3P0HueXTRuKUuaYUl1oHxrC3m6H5Ukk96DVHYJmJDAyDq60bFP1hyop0UFv8Ig8mDkI3OXU7qWRDvFOw+YP2jX7BwjUHPJDNIt8bXURD0Fz+FNeTbH6bJcZZreOkaZwO086tAb8JfviBD9AIkXS4lqhtPsAtkngq2E8DH4fx3UGr6J30VvmprE6YhZiAovTRewhuuhB7AocNnNpUPwtpQmh94VP3qF7WlrZiDyoVSOKwC6sQr+J7W30urO8JVTf61EgVi3Ii/vGqisqWWljYydKJLcMiIaQ1CiA9TVvRQYlrFQjDcjWtdT8l5rmxk1/ZjbPSrMUFFMjt5MkDw/cICRmr80LuB8u6Vzh8yw6aibCZ1NfEAUNIaI40XQpnRJGMgo3sgkCKlzogoirhFqfPA88FTrhe7uO9s6+f6TNBjsftuZmHcUKuG9WDzL/0/GixAq4pEhKUSBhzfPweeAi2RN/iLHL/z6KgwkifMs+W5EM9ptfMjKG0USfBbkxGOulzwRZFwuCHkXDusOalV6Zj90g3MNMsI1YVMiiR0Ass2CKKGQMgpmTqUA0bYs3R7TSVgcl0177pF2kf9KwniSQaeERJ7U02nHxNYl4PSSwKzgVKgPpTqEekjVuBsYyPkLca8QNz8oz38aAXdxdXZaYpYLS+d9A3ATtI6EdUAPBNKa+5c/YnW8/Gzmmn8YLsytz3aJLUj5pODWzMnAvqeMimS6SvxeRf72Xdpj oxDzRdaI hP9ghhrogt5nFyjj4QR/ad6XQCikL3/3OHcho+yDzgdihtEAwPnz/Qe+PvGRxzY/pDJvJX5ypwEo5qCgRszhnyfwt0rLJGroSSh4+Fbp6i3G+EE0hc5JUI6Rb77SRxqn3tzj0Kl7s2JgQzpnT5xzKCP2WSG4DcbZlPuSrvI/vb9zY6H+NoDO1av6CPvVsMilRgJo1KB/zpWmQb55oeulcLsGaj3SZ5PreDodNJqPiSIj0G4mVBt1wmvQE+Whqr2CCobrakn+vBzM6M0MiHIeJAD5f7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 17, 2025 at 11:48:17AM +0530, Anshuman Khandual wrote: Hi Anshuman, ... > --- a/include/linux/ptdump.h > +++ b/include/linux/ptdump.h > @@ -11,9 +11,12 @@ struct ptdump_range { > }; > > struct ptdump_state { > - /* level is 0:PGD to 4:PTE, or -1 if unknown */ > - void (*note_page)(struct ptdump_state *st, unsigned long addr, > - int level, u64 val); > + void (*note_page_pte)(struct ptdump_state *st, unsigned long addr, pte_t pte); > + void (*note_page_pmd)(struct ptdump_state *st, unsigned long addr, pmd_t pmd); > + void (*note_page_pud)(struct ptdump_state *st, unsigned long addr, pud_t pud); > + void (*note_page_p4d)(struct ptdump_state *st, unsigned long addr, p4d_t p4d); > + void (*note_page_pgd)(struct ptdump_state *st, unsigned long addr, pgd_t pgd); > + void (*note_page_flush)(struct ptdump_state *st); > void (*effective_prot)(struct ptdump_state *st, int level, u64 val); Should you treat effective_prot() similarly? > const struct ptdump_range *range; > };