From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Steven Price <steven.price@arm.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/ptdump: Split note_page() into level specific callbacks
Date: Mon, 31 Mar 2025 10:59:11 +0200 [thread overview]
Message-ID: <Z+pZX2QmFnNnnjZ5@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com> (raw)
In-Reply-To: <20250317061818.16244-2-anshuman.khandual@arm.com>
On Mon, Mar 17, 2025 at 11:48:17AM +0530, Anshuman Khandual wrote:
Hi Anshuman,
...
> --- a/include/linux/ptdump.h
> +++ b/include/linux/ptdump.h
> @@ -11,9 +11,12 @@ struct ptdump_range {
> };
>
> struct ptdump_state {
> - /* level is 0:PGD to 4:PTE, or -1 if unknown */
> - void (*note_page)(struct ptdump_state *st, unsigned long addr,
> - int level, u64 val);
> + void (*note_page_pte)(struct ptdump_state *st, unsigned long addr, pte_t pte);
> + void (*note_page_pmd)(struct ptdump_state *st, unsigned long addr, pmd_t pmd);
> + void (*note_page_pud)(struct ptdump_state *st, unsigned long addr, pud_t pud);
> + void (*note_page_p4d)(struct ptdump_state *st, unsigned long addr, p4d_t p4d);
> + void (*note_page_pgd)(struct ptdump_state *st, unsigned long addr, pgd_t pgd);
> + void (*note_page_flush)(struct ptdump_state *st);
> void (*effective_prot)(struct ptdump_state *st, int level, u64 val);
Should you treat effective_prot() similarly?
> const struct ptdump_range *range;
> };
next prev parent reply other threads:[~2025-03-31 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 6:18 [PATCH 0/2] mm/ptdump: Drop assumption that pxd_val() is u64 Anshuman Khandual
2025-03-17 6:18 ` [PATCH 1/2] mm/ptdump: Split note_page() into level specific callbacks Anshuman Khandual
2025-03-21 3:37 ` Anshuman Khandual
2025-03-31 8:59 ` Alexander Gordeev [this message]
2025-04-01 2:51 ` Anshuman Khandual
2025-03-17 6:18 ` [PATCH 2/2] arm64/ptdump: Replace u64 with pteval_t Anshuman Khandual
2025-03-17 9:28 ` Ryan Roberts
2025-03-18 4:37 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+pZX2QmFnNnnjZ5@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=ryan.roberts@arm.com \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox