From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F8CC36002 for ; Mon, 24 Mar 2025 09:43:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB92B280002; Mon, 24 Mar 2025 05:43:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C41C8280001; Mon, 24 Mar 2025 05:43:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE2D3280002; Mon, 24 Mar 2025 05:43:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8C114280001 for ; Mon, 24 Mar 2025 05:43:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D71AC1A16AE for ; Mon, 24 Mar 2025 09:43:25 +0000 (UTC) X-FDA: 83255956770.30.E951F32 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id C3BF31A0004 for ; Mon, 24 Mar 2025 09:43:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eJSzTV6s; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742809404; a=rsa-sha256; cv=none; b=DJUqDLFp0DEI+cQj2EXSOBJ43TUeXc9BDtktLInIdNafJX+J+Zu7+nVT+6ovpDjy4tj9FM H8SJOhSlxmBBO2Le+iCc0+isV1ovUztWwrso/GL7WkOtee7dzkXeyXOYG1I98wImdTCrgP gku9fuhsRZEHc9pRPmgvfuzCRkt82zc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eJSzTV6s; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742809404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sXgHgtcldaqEgL1B2MyW4inEnkIl1i2EB10yamCb83E=; b=lg+deJ80Z5ZF9OWmisnv+R5+9CqpkmRaotf55w5y2hv23Uuw6D+W0ZnYcyGTw31LsIAprn ckp89lySq8fx57esQpZu0ZFW++aatzG+Jh9tDrKgqtETEnBSxvIenz1iL+LKW4VVVHSA/D jrUISV4756gqZhIzGbHg786pTinVD3c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742809403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sXgHgtcldaqEgL1B2MyW4inEnkIl1i2EB10yamCb83E=; b=eJSzTV6s28yAn+zWyURqFqWb6CgmXl9qj1lD6cWG42sxqepIpWzJakZMGQq7qB+TFgoKOB Awru5Oyx3/yAtmCZCJb74bP9KSeWDxBX07t7eI+LtKfY66MO8BkRiV0dJA2YD3zN/MrIIn SLpuyAYk8FcFmbWupPBKjNwExLybiUM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-svbXV-eaMs6sb0RZzUgyDg-1; Mon, 24 Mar 2025 05:43:19 -0400 X-MC-Unique: svbXV-eaMs6sb0RZzUgyDg-1 X-Mimecast-MFC-AGG-ID: svbXV-eaMs6sb0RZzUgyDg_1742809398 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 46732180025A; Mon, 24 Mar 2025 09:43:18 +0000 (UTC) Received: from localhost (unknown [10.72.112.24]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5855F1801764; Mon, 24 Mar 2025 09:43:15 +0000 (UTC) Date: Mon, 24 Mar 2025 17:43:11 +0800 From: Baoquan He To: Kemeng Shi Cc: akpm@linux-foundation.org, kasong@tencent.com, tim.c.chen@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/8] Minor cleanups and improvements to swap freeing code Message-ID: References: <20250320114829.25751-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250320114829.25751-1-shikemeng@huaweicloud.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C3BF31A0004 X-Stat-Signature: k5tsfyppr91i3c9bpswxsckzxgo1nf8t X-Rspam-User: X-HE-Tag: 1742809403-264100 X-HE-Meta: U2FsdGVkX1/pr1G4q6hXi+YFTvNKdbN43wjLgwPHdL9Alk/j0gQCjGFGZ/vFsi9UZRq8RyYi91N7cSzafUkPOzOlmD3XCB9zlsTu0OeJpJ4ZRDFEVRV9zKVr7QMvjCiA/m/kpBn/HGtvhGqQDcbIf48FHano3KaiP4zglm0BPqArIsWOq6mkfcFkVQkfGLJzz55N5bUiN1mEE2DUc8EsOFJ42Lo03yvACf0kkGIlwhib5EuSQFFxb5hXknjOZLHjxrsDkJ6mrwhT868RDMv7RCClHg63hLlZzaKy7CP2y2khcjDqfjj0fLrXZ2Lt1+aTBubgO3QtrkYfz9wVRJewWrHwB2Gdo+hLiOe8My1D7jz4lK7HfdxtyKH9tdrbtvorbg5XVxw/XYrvFwO7zvQscf9izxxba7a9Bw7RlekHcUuTqtF42owL1QO+2C7A2B+I0Ap1s37OliLre7MKrwCfAWz3vrNjlCaew9xRqKwlxOk4MtLkn1TWWAFmwzjeEscoe0vA0ZJJIcZ4NWAaEitdeI64w+lx6QSRO5SdLSbqtof0EG8iQdhndtF+fVv1w6p01ubX5S1aUub92QQNL0m7NRzPaTSALSMW1aTPU3zQ7uE6upR+n76P7uvn2x2CGebx1UC4TLXECNW+O4CPuQzaLGEv6Ne+t5jZWEmnWYy7Sw1UdsYs3kkOq0J44Rehz5kcHc/UhN/98LY+G73vX0g8nXz6KBLznf362jSCAXXa3bjBpRfLO7SG4UgjEk17hUEISamSMhjO3mypbx4OvrQpgL44f6t/2Qsh40B7CLb4sP0OCA1XG6X1fpS+/IS5kg8T+IGWK3RmBqUeIRuIGPb4EOrEBgNSAiETAKJeueby9WyFmg6sGdOByD4ciez2wULjaYxrVJAYZYTrmnQ95oI59Pw9noPIWXZQsPds9U7tbsRjH7XsWhXCglNXNG9sNL4EL/5NpXCmferVl1k5a+f ByVERqYX dhz7m11SkUomhFFfr/fDuwGGDBe0WF60wbe3ZThBWlKKu1A16jvy26n7b9KYfz/UnbB+5ms/j6R4mQxx+QlC/+nxz6y0xcX2xCUKdP7I0ke6op3lQbYn6ScGamgzZwbQJ4RAQiXE3SfhOdOxUj3Bu8jTNBU4C3JxRMl6HuOeu6Y8HcngSt3NgyGjFx0OOxt3LMZ6brgz+5YPqb/iiREmuBvwMmySDGm0ImMe6ID9yEvRZ3hR+K/yoyYQgMNgZS/ic+xq6nJuXoP6Y7yvIt65SdJksbrhbsaPiS1lp3X7S9AifHCnVdX9aHhaW8I4zhV464ONTZXyRkeiRjnmV/MqODVaDkrYRs0M/gd8BZogpgDvKHT39tykM28XxwgnQDwX+5RRcIvflCAPVWZ6rzM7U1ORkTvDD26NO3VYLBrHNdIGpjhUA4pFY77krDRlCB/smmhXH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/20/25 at 07:48pm, Kemeng Shi wrote: > v2->v3: > -Extent VM_BUG_ON instead of remove it > -Keep bracket for more readability > -Collect RVG from Tim for rest part > > v1->v2: > -Collect RVB from Tim > -Drop patch to factor out __swap_entry_free() > -Improve changelog and add more comment. > -Avoid unneeded lock re-aquire > > Hi All, > This series contains some cleanups and improvements which are made > during learning swapfile. Here is a summary of the changes: Nice improvements about swapfile.c. Those kinds of swap_free_xxx confused me, I planned to clean up them. Thanks for great work. Reviewed-by: Baoquan He