linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: akpm@linux-foundation.org, kasong@tencent.com,
	tim.c.chen@linux.intel.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/8] Minor cleanups and improvements to swap freeing code
Date: Mon, 24 Mar 2025 17:43:11 +0800	[thread overview]
Message-ID: <Z+EpL2zXWP2HM+GX@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20250320114829.25751-1-shikemeng@huaweicloud.com>

On 03/20/25 at 07:48pm, Kemeng Shi wrote:
> v2->v3:
> -Extent VM_BUG_ON instead of remove it
> -Keep bracket for more readability
> -Collect RVG from Tim for rest part
> 
> v1->v2:
> -Collect RVB from Tim
> -Drop patch to factor out __swap_entry_free()
> -Improve changelog and add more comment.
> -Avoid unneeded lock re-aquire
> 
> Hi All,
> This series contains some cleanups and improvements which are made
> during learning swapfile. Here is a summary of the changes:

Nice improvements about swapfile.c. Those kinds of swap_free_xxx
confused me, I planned to clean up them. Thanks for great work.

Reviewed-by: Baoquan He <bhe@redhat.com>



  parent reply	other threads:[~2025-03-24  9:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 11:48 Kemeng Shi
2025-03-20 11:48 ` [PATCH v3 1/8] mm: swap: rename __swap_[entry/entries]_free[_locked] to swap_[entry/entries]_put[_locked] Kemeng Shi
2025-03-20 11:48 ` [PATCH v3 2/8] mm: swap: enable swap_entry_range_free() to drop any kind of last ref Kemeng Shi
2025-03-20 11:48 ` [PATCH v3 3/8] mm: swap: use swap_entries_free() to free swap entry in swap_entry_put_locked() Kemeng Shi
2025-03-20 11:48 ` [PATCH v3 4/8] mm: swap: use swap_entries_free() drop last ref count in swap_entries_put_nr() Kemeng Shi
2025-03-20 11:48 ` [PATCH v3 5/8] mm: swap: drop last SWAP_MAP_SHMEM flag in batch " Kemeng Shi
2025-03-20 11:48 ` [PATCH v3 6/8] mm: swap: free each cluster individually in swap_entries_put_map_nr() Kemeng Shi
2025-03-24  0:52   ` Baoquan He
2025-03-20 11:48 ` [PATCH v3 7/8] mm: swap: factor out helper to drop cache of entries within a single cluster Kemeng Shi
2025-03-24  1:07   ` Baoquan He
2025-03-20 11:48 ` [PATCH v3 8/8] mm: swap: replace cluster_swap_free_nr() with swap_entries_put_[map/cache]() Kemeng Shi
2025-03-24  9:43 ` Baoquan He [this message]
2025-03-25  6:45   ` [PATCH v3 0/8] Minor cleanups and improvements to swap freeing code Kemeng Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z+EpL2zXWP2HM+GX@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shikemeng@huaweicloud.com \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox