From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D3CC3601E for ; Mon, 14 Apr 2025 03:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BDD5280039; Sun, 13 Apr 2025 23:44:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56D2828001B; Sun, 13 Apr 2025 23:44:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 435B2280039; Sun, 13 Apr 2025 23:44:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 23A6A28001B for ; Sun, 13 Apr 2025 23:44:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 053C780449 for ; Mon, 14 Apr 2025 03:44:17 +0000 (UTC) X-FDA: 83331256596.08.91ED4D7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 17A2340003 for ; Mon, 14 Apr 2025 03:44:15 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZTQ2w4gC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744602256; a=rsa-sha256; cv=none; b=a4BSKz9g/GkIrKxiHn0DuV923TwjxXpoGdmMqCx9n1ZDJfY0qvbnB6yrudlSWXwZEEBY6W oUm0j3sE6HzIgX2YHoOfqeH8asB5CR0SJgK39Aro6jlB0gj0JsBiCQW1kD0qfQ5Z0sxr7U WUP8D8Ngexizw6ezewv9BGEhXZKiU1s= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZTQ2w4gC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744602256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5uiZWt5jpGYGmxTchGxtObL/N73C3WDD8I4HSPsLcjo=; b=DJ+kcHjXzMCgP0gTlLYT08pwnl1L52vn9dJFx/9XNSexpXG9relSItLMzlQOZ/WaSJRELH xdgNtABYGDfb3+zmqQMmYi4rJ4jxFzeaiAMdzfrFD3GqdvBR2+7idi3a9ztJN6w3tBwtSG yhm7YN/pGMvTIpbqQA3btHMiPvtTEAY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744602255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5uiZWt5jpGYGmxTchGxtObL/N73C3WDD8I4HSPsLcjo=; b=ZTQ2w4gCR1vbnVaDMtbljBjQfUCOzj4B2gGUrwkL+1cJQblXvrxcyz+ZjbX2dfkyF09VsA hgtzRaYmhMTLei+G6kFCDjmS+zJQii8oud2bunwlrYBZxirVC2bJhLBC4oMjg+qWo9I7Vf roG31YCIXDB4+aQDXwwEhRJ+6aj1M+w= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-XkFGVTbIOqm6wuHYWD-L0g-1; Sun, 13 Apr 2025 23:44:11 -0400 X-MC-Unique: XkFGVTbIOqm6wuHYWD-L0g-1 X-Mimecast-MFC-AGG-ID: XkFGVTbIOqm6wuHYWD-L0g_1744602250 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 37976180AF4E; Mon, 14 Apr 2025 03:44:10 +0000 (UTC) Received: from localhost (unknown [10.72.112.37]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9E8ED3001D13; Mon, 14 Apr 2025 03:44:08 +0000 (UTC) Date: Mon, 14 Apr 2025 11:44:04 +0800 From: Baoquan He To: David Hildenbrand Cc: linux-mm@kvack.org, akpm@linux-foundation.org, osalvador@suse.de, yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/4] mm/gup: clean up codes in fault_in_xxx() functions Message-ID: References: <20250410035717.473207-1-bhe@redhat.com> <20250410035717.473207-5-bhe@redhat.com> <35a93c36-6e97-4b33-aae5-efd1c907518a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35a93c36-6e97-4b33-aae5-efd1c907518a@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 17A2340003 X-Stat-Signature: 89po43f344zsmrerpjmnqozumup531pt X-HE-Tag: 1744602255-4764 X-HE-Meta: U2FsdGVkX1/H9kDNzobMYk4horTUcZX121n+WNtUSlpTAc7VA+7w8wv56R35e5PLX+qnHkY7asMJ6g+H0st/PQIQw6n5zA9rxp+NwHb7lRGaZlSgg/L9uicGRLVOLT+EiFw0UlkA+uZ8t6nQ5+XSXE7olBhyP/m1JaWgr7jp2JhvMxPN0YUi4MRB4ltpIvVcViC1sbAZSlWAdzoJY72BRlVR15RZrIEdzVmkMys6sCNejb1i+wQ1LNQjvcqKmzvZA7KUZPDmTxQ0vs4KT564fjdGGe661w0yUTBAwruYSL6M9ALtajQfnTOiaQcf8aNxTVz9HAUrXu5W8+pihiI8rBYMaoHmUIxQY7wMjAXkpuenplzd0TGpChdDShOHDs5Kg9b9YOS+uspGOx9TReeARodBgf8yQKDazN7Cx6jZxW/EfBnjl8mL9Ga0shWIjyiRPkvvZ3CXDEYPmv3db99xTggJ6kiOVhwLniz/s1oxKRgQtCcSbAO0knMqxwjY1eWY8Nq8tOveeniWSHDSlzt0CIWJYEQxGbjqdEAfHA5Dir/sZEEDjVfMNtW0mjyKSqJory9Z4QYqE0ZQdLQKhSpv/XaBua9wJ8LxJIndkaso7moUUk25e/71oGnMiKiSfWfNAfYo9DdWYWDQ31cYo61Y64lEQFKkXxyOvqq7ogJoEl6vBJKwZ5/PQo1Rn2L6kMTXmY5S7RX2gOvALolEw4QQ2l0IptyLbKp8I5/ZRXcKE411aedgLo0Rkz23kXwZM3Ej9b+rz8C7w/omuSVRl5ryjVmhilrOJfMDS635wzzJtZueA8u6lYfmZ5IXXwW9IhXlzWdW1Q9KHMoUJ86tp4+bAcKMdfJ0T86sYVQT44MZI2V7vx7drcEujyn5UlKTobqh3sJqhCou3TgEdUsTM3r9u4B2zjMI84Lqxg63tyE28LsbPylNNVv4JnBZMZlM8C6EtL4E0exQ82aDPqGltg9 4x9HRp1w PRVb/to1+XDadHc0tLbukPZNsNRXu1XKpNAWRa/Cq95VPvQU22J3VKWuJENKmnWNtoebgY+I+7Gfoeq/V2eihNE2zWWWivKi4HQaSSdYgrwvCInY22Vm0XGDx9FXe4kgrcaDVyOs6oeFwgeUQftlLA2go3SqKEAd9OTdjUwz3V8a+HxUYfSHyuqQ06Rrld8jo36ND98+b689jT//s+rOK1p7ViVTtNoo+cRtElQ/RBhk7O1aUG5kmGdcBd+kYOjZTE0jtA2ID9J/w8pf8/J8Uo2SPZB1bT7Egv9BGGSdI2uSWRueO6AwKX43oagg4dHUvV1u0bcqwriCJ7HhZON7iaCrabB3sO21/Pe6Mp+vYntHVQCQ06muMUGifdnsuatFUg8A0nCMlYY+ZxOfiiOdHjnZ5BH5XhJPL/xTQOB1TyI+vVTdPuTCDWv9rngv6BUQ3N84KSSZCHxN/aIWmXfvStrjLOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/13/25 at 10:09pm, David Hildenbrand wrote: > On 13.04.25 04:04, Baoquan He wrote: > > The code style in fault_in_readable() and fault_in_writable() is a > > little inconsistent with fault_in_safe_writeable(). In fault_in_readable() > > and fault_in_writable(), it uses 'uaddr' passed in as loop cursor. While > > in fault_in_safe_writeable(), local variable 'start' is used as loop > > cursor. This may mislead people when reading code or making change in > > these codes. > > > > Here define explicit loop cursor and use for loop to simplify codes in > > these three functions. These cleanup can make them be consistent in > > code style and improve readability. > > > > Signed-off-by: Baoquan He > > --- > > Hopefully we don't introduce anything unexpected ... do we have some unit > test that could make use feel better, especially regarding end < start? > > If not, could we add one based on some feature that ends up calling at least > one of these functions? Seems no existing case. GUP has selftests, no test codes for kunit. I will see if I can add one, maybe it's not easy. > > Acked-by: David Hildenbrand Thanks.