From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A0DC369A5 for ; Thu, 10 Apr 2025 15:24:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62ECB280115; Thu, 10 Apr 2025 11:24:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DE5328010C; Thu, 10 Apr 2025 11:24:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AAED280115; Thu, 10 Apr 2025 11:24:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 294D928010C for ; Thu, 10 Apr 2025 11:24:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EE851120F29 for ; Thu, 10 Apr 2025 15:24:57 +0000 (UTC) X-FDA: 83318507034.20.BAFF550 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf28.hostedemail.com (Postfix) with ESMTP id AA45DC000D for ; Thu, 10 Apr 2025 15:24:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qqlAspbA; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744298695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oX/bUdv4ulubAeUp4kEtb13gSWpHCjCweTWlfyCzCwk=; b=ifKRHXcY2x7jU7OO6aAkb4lNUXBBby9y/Q48kTbr3Ihhfk75YW+of3EIlYV5f6iE7WgEDC +22BC/duqYzUdZSysT2QvPjjAlPlql+Fn3a2inxY9DOH1qT+BtQH7211QoIvN00mlnTbjW fXHG1Myw17EQEGjsCkFstNGVVzqlO/M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744298695; a=rsa-sha256; cv=none; b=GV/CCYVptueffUwU1Fmw2uryIyJwAPZz6myX6Oudv9PZYrgPtDTH704hMpaXk0FKs2+Y2v lv1Rwha0EV3WdczoEzVNofmIjD25AZTYrHgAWr7IJy5HyXlsA6oQsEjgqfvwsYLxxTC6gv NWMjEf1pkNlMAGPqboIZmJWkqu9w+WU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qqlAspbA; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf28.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53AE3LUc010696; Thu, 10 Apr 2025 15:24:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=oX/bUdv4ulubAeUp4kEtb13gSWpHCj CweTWlfyCzCwk=; b=qqlAspbAAVWK4gbwQwaQj2nIIBmUtv1aci6HspxQxg/kHB 2TOL8bbRr4UtmMDL0fRCPwUIxgzTl4sVcYgLWQhzFbg/oG3mWPAdq5i3Kj71Nxmg ozeYvPqE4elh06vTS8hWkChRbngBgw+x7u0N9IcFT64WIsvQbYAu1uDZ7F75GYVt sIGl1F9tMv+/ThvIZR4nUI19XbS+11LcJks+LVq95POuhSfebLtcGXZqQb46Wnbf Z5/ms3JDK5ZbIFj0DIPH/Iphos7wFSuelwaMjjRSEYpV1VSIMU2vUSIGz3nkorSU 9mE7ZHfhc5kocR9HcpdRrIGZ7VwTUaTc8c0IJ21Q== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45xfdqger5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Apr 2025 15:24:54 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53ADGUXx025598; Thu, 10 Apr 2025 15:24:53 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 45ugbm6j40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Apr 2025 15:24:52 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53AFOpf434538128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Apr 2025 15:24:51 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ECE2420043; Thu, 10 Apr 2025 15:24:50 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CF2E620040; Thu, 10 Apr 2025 15:24:50 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 10 Apr 2025 15:24:50 +0000 (GMT) Date: Thu, 10 Apr 2025 17:24:49 +0200 From: Alexander Gordeev To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v2 1/1] mm: Allow detection of wrong arch_enter_lazy_mmu_mode() context Message-ID: References: <18bf936f63e0d1e53d8291a3bc2ee2c577876d9c.1744129955.git.agordeev@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18bf936f63e0d1e53d8291a3bc2ee2c577876d9c.1744129955.git.agordeev@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: -FkBRIrGRA2h2cwc0q47YxegGQLhwxPM X-Proofpoint-ORIG-GUID: -FkBRIrGRA2h2cwc0q47YxegGQLhwxPM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-10_03,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 mlxscore=0 priorityscore=1501 adultscore=0 phishscore=0 mlxlogscore=770 impostorscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504100109 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AA45DC000D X-Stat-Signature: kbu6bqsjx83kxbwp1nxcgowys6czgsy1 X-Rspam-User: X-HE-Tag: 1744298695-629177 X-HE-Meta: U2FsdGVkX19PScEMU71cY/68DJ3a4iy2d+LF0A/RXptmA7x8Tmsdq817MOpGe6yqXxjJgPOGBsUXDDeJvCqiAAkKSytSgxCDXwv96jSE7+F/dKUY//scc0NmNBVvlrGn/T8OMaIRyct+rtK21IgXwOPZ3d0uUJuAlIQe/3mdpLTEo02Wm7i62+pFdHKYZPSQ34VnzzSzLmleNroZTM1lEXhZSLfWp+6WmfUoPoSXdoJM/Ar0EIAX3r6T/eU9fxOQmveWnnuvm+JaxlMxV/dRCkFa5VcSdIwHo4IqftBGQjq9VfkHCgRj+Ga3mvdHEcAQaktoQYT7PMMb/Tc7b53XKgiuHGylkY4Hwpnpd7n7eZreBrD6fLcEecDHH7UEa8VO2oJoYZI6dD5cgsb07LepRi51Cx4NO7FwPcOeorq76OB4nk+JUVUPkz1hGBwUiZSBpz6IUxme1UJ5gNvZQDBQAH6tTF/NY6O7cZgoTm6OztGf6fwUjjcKdddu+BiuyTpg98ndvSOIDtdhviTW16NWOpkehoIfVl2pumuubv0xbAe+nKrkH0H66EWWU0m+yrAe+jaiRANr+G2XCHNBMBUxwwx7NJ8ulXG+9U6PI3LTjSz5eEJC3ViYKkMwxIu58Tj89XrqE0QesBbk7FY57Q1UaMHTOPbxj7gCl/gEF+k4d0Nna+Ke/V0gYKY1HuWCQt5x5+/BDopBVC21c6N6+1+5YSO20dllbfCAIwnz4mUhzdUWYzLqaV/FCdie2GHnIWUeRDASh2NN18ZfM6A6m1cqHSkLGuOSW15W8dB6mDhS3fWUp5UFtD3Y6Dm8Tmmust14hUmLntR1xUEhCnAPyT51AnwSd2/fq03K5MEwBCz7NaxMulklJXs1jxrN7+sI5dSTWGzx9vE/9y95SpH7wo+ohKF+9R4Mm27mfcqrlJQKXGGuj63h7QgdLxO534ranVNPQGdE6Jj20m3VfZcqbEw BiUIJRzI idGSFTXsFwS3w5HbqMOMn/3bZR7rwEDmpWcOCWxzl2VA9C2B6Vbvf5G540hIVoSfq3kQXjOnUaZXO2Ue1N5C9AhiVaHrWTmAyLChfc9fncPm/x//QVfSX7HeCN2OXJxPTmaSKzMv1LzTqZ9HePMZd+W5wDEiqLPlMmAyiYpmaPDywV0BraPRYBCJDN5Da9s9oDD2rl8SfzYeD+iqwIH7+jcUCKw1MUR6m/B7WgA6vsSu4Ku6kZrLc608qzne8zPX4xRIPHdTrj1MwIXrk6sDunywbq2P9cf3McyoFV8bkDKpDEonxlRKbFQ1tPPhAMCiXfWxT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 08, 2025 at 06:48:31PM +0200, Alexander Gordeev wrote: > The lazy MMU batching may be only be entered and left under the > protection of the page table locks for all page tables which may > be modified. Yet, there were cases arch_enter_lazy_mmu_mode() > was called without the locks taken, e.g. commit b9ef323ea168 > ("powerpc/64s: Disable preemption in hash lazy mmu mode"). > > Make default arch_enter|leave|flush_lazy_mmu_mode() callbacks > complain at least in case the preemption is enabled to detect > wrong contexts. > > Most platforms do not implement the callbacks, so to aovid a > performance impact allow the complaint when CONFIG_DEBUG_VM > option is enabled only. > > Signed-off-by: Alexander Gordeev > --- > include/linux/pgtable.h | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) Andrew, Following [1] comment to "[PATCH v2 3/3] mm: Protect kernel pgtables in apply_to_pte_range()" I think this patch should also be dropped. 1. https://lore.kernel.org/all/Z%2FfauW5hDSt+ciwr@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com/ Thanks!