From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB68C3601E for ; Thu, 10 Apr 2025 15:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E64ED6B0348; Thu, 10 Apr 2025 11:18:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DED6328007D; Thu, 10 Apr 2025 11:18:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9C3E6B0348; Thu, 10 Apr 2025 11:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A67886B0348 for ; Thu, 10 Apr 2025 11:18:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CCB53140DEE for ; Thu, 10 Apr 2025 15:18:29 +0000 (UTC) X-FDA: 83318490738.22.15869F7 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf29.hostedemail.com (Postfix) with ESMTP id BB14B120012 for ; Thu, 10 Apr 2025 15:18:27 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="XFA2NdY/"; spf=pass (imf29.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744298307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8yZK2G8CEMH6GwaqesHa1lpHB+Zat5CGXDOr1+EXSC4=; b=1mCYyLU/wbr7jkXKBsyPspoCY0rFlS1IO/o5ezqCICLjJmYw0RdTcksFeLCriIWO9u1oXg XkWouN9lRUyNpg9wnfmDCMqMF4UPO7B1PGxCT8b48Mv0dbwJTP9Mj12xf5Z7zbLjlxXrKk FoPrK+YROhMo36SkvLCvHTGhB62Rdr0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="XFA2NdY/"; spf=pass (imf29.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744298307; a=rsa-sha256; cv=none; b=RO2T/Ade0MzQC2tB5/wInJP0whd5JT3FdAbne66xrRN7MWBkI9FaCmi6QLurLd/UY0/Btv h5/UmZvGaDjU/Yh420knZlscdH0O6xXFzSLbhIrxclKY9qms+zb24JB5hdJvcN81Unh83z +MhSQFNNzlccuyJm58anR9b70sMFq2g= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53AEK7vi022679; Thu, 10 Apr 2025 15:18:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=8yZK2G8CEMH6GwaqesHa1lpHB+Zat5 CGXDOr1+EXSC4=; b=XFA2NdY/+9mY/FXZshAh96j80DyvTbKTueTNVZhU0+yxab LQAS6lEJM05MHO0qcxITWU3AUuUwWhbR+rH5gkM+i5KY2ZDS+KKPgm1w0TTco7lI 1ejRJgDisSwZgBF3F7/68V/hVDGKZc5EEq9Xbxm5cvuOYh4E30FthuwpbSU11IR+ iDHdgVm8V9yC0zoCKXcaGa8GjQj57F15LDzr//DrGKBhJwZitM11zufCoRjeljn7 kao0b+0vHjeDd5MF+VPhYDC+2gDDWrc+hl5DxvXUunM3PNAcgrnztpsj+jwiIr5G heQFmmMTR5ltMcYN1TVWdpLd/G4AaU/rogD2SyZg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45x02qdg47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Apr 2025 15:18:25 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53AF8TYT001916; Thu, 10 Apr 2025 15:18:24 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45x02qdg44-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Apr 2025 15:18:24 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53AD96gI025537; Thu, 10 Apr 2025 15:18:24 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 45ugbm6hc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Apr 2025 15:18:23 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53AFIMnK41025908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Apr 2025 15:18:22 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E809920043; Thu, 10 Apr 2025 15:18:21 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 95A3620040; Thu, 10 Apr 2025 15:18:21 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 10 Apr 2025 15:18:21 +0000 (GMT) Date: Thu, 10 Apr 2025 17:18:20 +0200 From: Alexander Gordeev To: Andrey Ryabinin , Andrew Morton Cc: Hugh Dickins , Nicholas Piggin , Guenter Roeck , Juergen Gross , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/3] kasan: Avoid sleepable page allocation from atomic context Message-ID: References: <2d9f4ac4528701b59d511a379a60107fa608ad30.1744128123.git.agordeev@linux.ibm.com> <3e245617-81a5-4ea3-843f-b86261cf8599@gmail.com> <02d570de-001b-4622-b4c4-cfedf1b599a1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02d570de-001b-4622-b4c4-cfedf1b599a1@gmail.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jHtw6lgVB7srP7G4ujZD7xCcxXdTfHSC X-Proofpoint-ORIG-GUID: fFGj102REu_S4ew0_ixvtgn6rzege4GH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-10_03,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=961 lowpriorityscore=0 spamscore=0 clxscore=1015 suspectscore=0 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504100109 X-Rspamd-Queue-Id: BB14B120012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cgdjy5gutdhk59xyac68hqwypqeb4dit X-HE-Tag: 1744298307-663844 X-HE-Meta: U2FsdGVkX1+5bPQMMsZlgMY1mTga2YIz5+5Yo9Q7Xdxyo5aBWtdtfwtP3lAWc3d8nBjbyQcuEEeSYRZBknvzjNnY3dSqwp7Z51FaA2uL6CPwm3asJk281uU3HX3MPFFJV6k4npXEYTqCUV5hOQNoLAxDWmNiXVId+AyC8xGXMi4T5g/qzX1eiJW/OkgmPKF6ytvc5Oa8vmP8Pj1hU15hwHQvq+kkgtYnwlvvIZ39ZcDD2fM83SCKQvJEaDb0qcqWRvKFZssPxyWOHRq9oIXsgk+Djgn/XMsIqKoisOPkm9jamD6C9KZO6/CTr48IuU50oxU0mkL3Lbt3X6BwMI0ww13abOSdwMSS2wuyw+TSMhbdUcsHJzgfihEVNMntEuX4NAI416PsJVzil+iy9fNE0GHSyUXhx34ozUPsJq7upCyRY06JNYyL/jhkFJ3I8iQZHs+a3xWnXbNiNv7hy5jPejCi8Mxbj/LA8xwlx5UgM0m9XISfeyL1DYO5epVjrvBQnrJHE8sEH6sP+DGZgifInLzC6d2+KMAEzDkRMF1pKGGe56ypVTZOztN1M9oZsMifECZQhMjk1K+fA6InYWS7m7CXBOB3KqRulJNha+prOOj7cKWgNNzljrrpCvow0sfLt9NDRCqIsetkF9LY3xwPtR0QZsoP9Cj4heWJQNg3ukh83oxM7jAMhk7+O7zXQ4dkCooiTkpEBTTt75rvLoojSgHJ2aepy/eSGKKOQoUBP9U1g/i7C65GAV7kneCvxTD/iQuy3zSGkpvY1TMyZjoDeE2TClI4RKfVQpegUPwrfzi3xUj9qAjDJPMxuE/wBXGqEV0HXJadT37vKvj/45jLxzjfqCv//79xpS6QHP6k6nFUbOpMB8OZjFSiJ6uNFeg1l24ObjdUgf7g/vLCzD51KZ757ROtvaTWyd980eXVm1/u/E7qGlS1v/G61TbFszt5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 04:56:29PM +0200, Andrey Ryabinin wrote: Hi Andrey, ... > >>> - page = __get_free_page(GFP_KERNEL); > >>> + page = __get_free_page(GFP_ATOMIC); > >>> if (!page) > >> I think a better way to fix this would be moving out allocation from atomic context. Allocate page prior > >> to apply_to_page_range() call and pass it down to kasan_populate_vmalloc_pte(). > > I think the page address could be passed as the parameter to kasan_populate_vmalloc_pte(). > > We'll need to pass it as 'struct page **page' or maybe as pointer to some struct, e.g.: > struct page_data { > struct page *page; > }; ... Thanks for the hint! I will try to implement that, but will likely start in two weeks, after I am back from vacation. Not sure wether this version needs to be dropped. Thanks!