From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C740C3601E for ; Thu, 10 Apr 2025 08:35:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F7612800AF; Thu, 10 Apr 2025 04:35:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A61E2800AB; Thu, 10 Apr 2025 04:35:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 595062800AF; Thu, 10 Apr 2025 04:35:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3BED32800AB for ; Thu, 10 Apr 2025 04:35:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 39F3E58999 for ; Thu, 10 Apr 2025 08:35:29 +0000 (UTC) X-FDA: 83317475178.30.8DE2136 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 6E82A4000D for ; Thu, 10 Apr 2025 08:35:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h1Hw+3sU; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744274127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CxHaTazFkHPO5uhaMckeowRpsl34ZLTSQwo1R7YrUH0=; b=lKsyCUsAv4Wer9BKs1KaGaFmpTygXlc41/BNnJBEH4bJfV7ufSkJS6YpxKP1PF3FnHB7IN S/kjXp2oXhGvq/T80tGEwWPm15IGQJ07Hg7sbG9ycecl47lmtxp13YYUWxCIBi2e4OKgj8 1pJFVb7UxeWmd43Y2WeyquV7YSD/+dw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744274127; a=rsa-sha256; cv=none; b=TY2TBMKF38kcMNLHkYiMWYE4G2DcKZtnyUv+v0n4eFK+tS1EFVj9sdO22yglYS1073iqXQ ATmipdL4HMww0QtsxDEfvwan2J5jgzWA+HJuZW7nGEYAqiYZ5FZFH0L1Gt+joFHXpS/3ZJ HazGwMn2fbEwHFltYBSc+pUIefscyIM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h1Hw+3sU; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744274126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CxHaTazFkHPO5uhaMckeowRpsl34ZLTSQwo1R7YrUH0=; b=h1Hw+3sUu6RKlAh/KqAmZ4CwpjRaEaSyFDCmDtXzxzG8nFHX0aEQJa7VApamn4WkW06vBY USmcRJo/gmKX1R+7N5R/pJ6uxobU79VRN3q1AZNdlRCUBgUaVkzXNdc0NN76u45uO6euUT F7wvFYJG0i8qvsVRuhaktlWafenwa7A= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-vXEc_BuaNT2-A0S-b0lwlQ-1; Thu, 10 Apr 2025 04:35:22 -0400 X-MC-Unique: vXEc_BuaNT2-A0S-b0lwlQ-1 X-Mimecast-MFC-AGG-ID: vXEc_BuaNT2-A0S-b0lwlQ_1744274121 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6680F1801A12; Thu, 10 Apr 2025 08:35:21 +0000 (UTC) Received: from localhost (unknown [10.72.112.38]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE3683001D11; Thu, 10 Apr 2025 08:35:18 +0000 (UTC) Date: Thu, 10 Apr 2025 16:35:09 +0800 From: Baoquan He To: Kemeng Shi Cc: akpm@linux-foundation.org, sj@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch] mm: swap: add __maybe_unused attribute for swap_is_last_ref() and update it's comment Message-ID: References: <20250410153908.612984-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250410153908.612984-1-shikemeng@huaweicloud.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Stat-Signature: 7izd53d777578aatq5uk5wb5n6tg6yk5 X-Rspam-User: X-Rspamd-Queue-Id: 6E82A4000D X-Rspamd-Server: rspam08 X-HE-Tag: 1744274127-228597 X-HE-Meta: U2FsdGVkX1+UWdIaykZlCKUOhnpM2aNw5luHrZTT09AJX7sB5MOUVYcj3ghW4Q9xC9qtpAd9Ii16e3TcudEFqEvbfFeVU5eekxSBs/zxFQhbdquMOkmRHpipKGpdxiiOumn6uma2J41JXhAfRknzhVPSkzVKyEWA1nNZd214H0Zj1z83NjpmsUx/XuKgzZCxMOiB8VkUiqa292/KnTPVzSWTSQV415BWtYUZbFApQX5tVlK8w6+E36x54OmyP2J0WSgcw5lozli8x9zaeJnIXv738uPN0+pyv1yDvXuSa7e3Mc0d6yRFdmmsKSd91UIA0xnfGtagrk1gx/WvAJ/j24N8nlIJoPg1PsE8BvgZ/wyllyThA2b8cNGuvXAZX1iDvK+G0VO2ZgEfPx6DCM/Wv6Gu+LVMAuASlAmcqHXVXSput7jpXBxTTJmP2joUxteHhDUhRJ4k5KjUW3MgEpOBLHGs3MnKlFsEk4u+qMIUAryqpdXVBbZrlnHpCt1ou+uT20/rT0H48wRkPA6yLRS8msFh0VQyeKONDQ+JFjb7IH6NUMwzQniFTqbKx2a95jtUD+4rsArlV0Gw3m2b4uefsgUcJCUfdgXYyDhnd2sjhLQeL29TFnYT3/nvJRDAiW2lLDIHNzlUEHiUfhZ0dtSzLKQWtRtAkUy7D8e0CepMFfQY6zCM351dJRhPESPp0M96nfVTfx6sHWPGO/rDHWcey2pNxrkunuRGtvfWFa4hXQ9yTOTfGklmbSfB02dBtJG3/4NvzxDg+vwZ207P+1Qq71gecvx/mzdOB1Y7bmgoShyjNZ66RQhFDtkhroLFVZyVN3ieRi1k5q2OelrjrxwZs6HLIXD9ImAnP3EcNkCrdN0k9B5s18ozZE22Waws3HqchbdOeAxR+GHBo3gdmOiAHKNePPnfCzj1chI1sWfpeMev3p8kCmUtkecgvlZSfRKicFfrTkthBg00rkqaJuv A8FX1BUM VJfQXikmADi6cmF1DNsb7uZushI++zv9LcxSaBqXibh7gNEpCnyNJ1vmx4AF4T9AKhLiiRl6oBFo/r+gZVTUAePeAFtLXrcH/bk3Ip7+AHnIBeQ70GUNuPnkt4GwWciV1VqKREuXRqfwUOdiLuR2BaOwcXpH+FVly7t2EzESTI2f8HR5/2DeYECck3wf30BYtPRp2UJLa7vh45sVM4kyQF/dTCne+5OzB3rBFQfMnB+TgifsTjT4e6GnaX+ZkJys6QGz9l9poofHndnZh4kSPQ39M5bQw2sc/GSphTAbl+TtY7/4LrK99LvE2+IZWR+a6Keock0dH9CAuQgaKglY9yweRwkpwuJDFikRTsO/BKb52uRf8jjqmZ/487Hb6ekON047J6tXcdH/5fsB06rjZ37HAlN6gLOu4AxLQxzP0eLLus1RoiTjdf6gL3IeHnbbFxz9rPfzF2ORD5PNRRaICMh8WtvrOizRWKGOkgTcGLCneeQyzyvYX1bD2pNjAmKyoWa9iFI+QCUg75mQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/10/25 at 11:39pm, Kemeng Shi wrote: > Add __maybe_unused attribute for swap_is_last_ref ()to fix following > building warning: > mm/swapfile.c:1517:20: warning: function 'swap_is_last_ref' is not needed and will not be emitted [-Wunneeded-internal-declaration] > 1517 | static inline bool swap_is_last_ref(unsigned char count) > | ^~~~~~~~~~~~~~~~ > 1 warning generated. > > Besides, original comment for swap_entries_free() is placed before > swap_is_last_ref() which may introduce confusion. Update comment to > address this. > > Fixes: 6bb001b6b64ec ("mm: swap: enable swap_entry_range_free() to drop any kind of last ref") > Suggested-by: Baoquan He > Tested-by: SeongJae Park > Signed-off-by: Kemeng Shi > --- > mm/swapfile.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) LGTM, Reviewed-by: Baoquan He > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index c46b56d636af..4b5fc0c33a85 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1537,15 +1537,19 @@ static bool swap_entries_put_map_nr(struct swap_info_struct *si, > } > > /* > - * Drop the last ref(1, SWAP_HAS_CACHE or SWAP_MAP_SHMEM) of swap entries, > - * caller have to ensure all entries belong to the same cgroup and cluster. > + * Check if it's the last ref of swap entry in the freeing path. > + * Qualified vlaue includes 1, SWAP_HAS_CACHE or SWAP_MAP_SHMEM. > */ > -static inline bool swap_is_last_ref(unsigned char count) > +static inline bool __maybe_unused swap_is_last_ref(unsigned char count) > { > return (count == SWAP_HAS_CACHE) || (count == 1) || > (count == SWAP_MAP_SHMEM); > } > > +/* > + * Drop the last ref of swap entries, caller have to ensure all entries > + * belong to the same cgroup and cluster. > + */ > static void swap_entries_free(struct swap_info_struct *si, > struct swap_cluster_info *ci, > swp_entry_t entry, unsigned int nr_pages) > -- > 2.30.0 >