From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0803C369A4 for ; Tue, 8 Apr 2025 15:01:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F33C4280003; Tue, 8 Apr 2025 11:01:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE2F9280001; Tue, 8 Apr 2025 11:01:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAB2D280003; Tue, 8 Apr 2025 11:01:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BAB52280001 for ; Tue, 8 Apr 2025 11:01:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 901CA12112B for ; Tue, 8 Apr 2025 15:01:50 +0000 (UTC) X-FDA: 83311191180.25.59EA031 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 6364B14002E for ; Tue, 8 Apr 2025 15:01:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AUkgHRap; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744124508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VJhlibnoGKLKtO+j+4h33e2pnR8Ge+2erGKyKrpo/po=; b=s+Xdsne0Ah5gJLBSrqsghyeE79+qmc92BTQgBOPnF5a3IkpynfWiwGcjO0rJiMRnx4VpbH QjgTekX1MqcyXhjNK0Hrwr2ctoihM0mEPl7x8N8SCFO9srbe46y/+4do1Bk3D8d0TsnBLS eK96ymJv5gZ01VIjq9yzxpzm7VtedkM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AUkgHRap; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744124508; a=rsa-sha256; cv=none; b=uCQznd95cDhcWn9OTtXefK++jJAaqYM0fwleuvsdqB3YmBHlxAYAVqQVN1tm0FoqHVpkAA XDV2LqUsTQXQ1+rOt1LFu1SSjk6iyO8qUYGsFSGS4rLNW0wf/g3/RwD12yEF820352JkI2 anNys+VVUOMw2CWzfFe5deSN7wcRwCs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744124507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VJhlibnoGKLKtO+j+4h33e2pnR8Ge+2erGKyKrpo/po=; b=AUkgHRapHQN3+Q+QksNZn1CypPJQIpWySHzpqEpKCH9obP4GaxrU5PsvOAMM8f4YZRMs0f GgG5C7z7TN9aTgwr/FZeuGCx3/q/Cmb+JC77k+uRDR6SDK6D2gdiHZvylRWw7dmErQGX6P 3ez88KkwBcVitFpbu4evrjHgxhe8qA0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-dsSkjsuyNW-JITMTF5MWtA-1; Tue, 08 Apr 2025 11:01:40 -0400 X-MC-Unique: dsSkjsuyNW-JITMTF5MWtA-1 X-Mimecast-MFC-AGG-ID: dsSkjsuyNW-JITMTF5MWtA_1744124499 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 22C2D180035E; Tue, 8 Apr 2025 15:01:39 +0000 (UTC) Received: from localhost (unknown [10.72.112.61]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C239A1955DCE; Tue, 8 Apr 2025 15:01:37 +0000 (UTC) Date: Tue, 8 Apr 2025 23:01:33 +0800 From: Baoquan He To: Oscar Salvador Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, mingo@kernel.org, yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() Message-ID: References: <20250407030306.411977-1-bhe@redhat.com> <20250407030306.411977-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6364B14002E X-Stat-Signature: c5t9c4x1id3sgnra5gabptqtj9nxxmzq X-Rspam-User: X-HE-Tag: 1744124508-818756 X-HE-Meta: U2FsdGVkX1++u1hu8aC1iYgnLtoI8jOjCZL5D2uEdqpM0OLO7oJzVarXHyEmfMN8ktkFUuAO0oCaYPs99CSe9VYk1QNHapbSefaqmRlwqS3ofKe7TxsJrsYS/iKbTcpo576C/SLKuf4JKqjX5twIWda5BTfsd1XNwAYTxa5qY3XNTr7btl7jHcfbJ77517JpVNhQ6I54bgkq68njW7onv9DcruvV3lVpPILb+42y3QDsUFwwYfieuQtaE3SxlxpZFoSi5qg3OT8aD6rutLQy+1rm+gLodH83ggQBEq7Th7XLd5Bdk1AxZjd0IHbeHOuJ4m8HzEtpiJbkYpvwq3LngH1/5NC3gFLX1hPcyY7ocPsl4SCrqZ2CuI3LdyAiOsuO3iA2Ax8x5fzHPRIFk0a0rWRyF/ekJBP5OUokcg53jIv5pmjEtIxl4IT+c1H2gYPOt+0ydFveuxX1kJbKZH8X5Khg+uIgE0n9laG/EoCbEBmi7OY53cXg5HQKtznjvs6+0qHclnV0xszTqhYdRPf8yTTYVo3tsv1CG7+e04ujAMM2Rs0gUVsTHvF34E+XWWSc05IOitryiQTTc50zol5Z5AMP6i8D8oDKZv+Y+SwXtOEPmiu6BcmGCqbkhOUBzOVYumvnoEGJ+J9/X8p0b0PQi3linGcTlUlROZBbLXkkKXQpVmTtt219rEkSz+2UQ5q+5xibAYmzqFfdEbmJ8EiH7nRU1DAusFrM+SIlOGodV2//1zmUIg/ftPxJLLZGjlkcZTA8NQkcY5+xRMFAMAe9BlOywe+7QzlUcoRE4TYs58qUmlGsofz4L9XfQa6OtBhdvzy7K63NheyaSKVZgbHn7MS4unGdLpnk3orNscC4jMfQdMroppP59XbVFx0oqUY/xn/MJ4fN3EsWbdDwnGWlpUZnT8cIqhF2nNclNGKNMYYFg7y1mj33+/7sc6VabLbLWvKASYjyZRpt3GSvwGu vAoXmWcK Kv/IAEFrItkyZoXplXmXvHGfVGNmteEmlyGZJlT67dTB4U60RkfYUPu73ANBp6QMlQ5xxVJ7gLRtBIw8N3UVJFbp3LqfVUMA8V+2JnP/gbI1uok+QifK0MSE+q5QrLXxbZorBHsrymt28pLYSLpuw2n9Qm3oyJlWloIOkvNBKlb1FGrEBAXubOr+IhOfoTjN/sCCofF9g+tLzW7MnPInv3brUuHBQ7BmfwH4bMtC7PfioJvLs7LQYtQDRr5F6pjrwAeDH2MjHYl+D7mMFPzCdXoeJ6Wa6HmFe89qGAxGPqNig1Kq0RLswkQsnrsuROe0xbJPe4CMovIBaHx73tsfXEkLmI77PJbvLyJB1STFSEYujWYg52Tp/t15Xpu/mpmp7+B/dQvGww6cQiHOwPhgNORRIbYDjUYz0AVMMCWDVU1jZzzppzNNYq+8qqJqppWpEScWc6POX137b5eUqAcywlmqOMKWDRvIbwl6I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/08/25 at 11:40am, Oscar Salvador wrote: > On Mon, Apr 07, 2025 at 11:03:04AM +0800, Baoquan He wrote: > > Not like fault_in_readable() or fault_in_writeable(), in > > fault_in_safe_writeable() local variable 'start' is increased page > > by page to loop till the whole address range is handled. However, > > it mistakenly calcalates the size of handled range with 'uaddr - start'. > ^^ calculates Will fix, thanks. > > > > Here fix the code bug in fault_in_safe_writeable(), and also adjusting > > the codes in fault_in_readable() and fault_in_writeable() to use local > > variable 'start' to loop so that codes in these three functions are > > consistent. > > > > Signed-off-by: Baoquan He > > The fix for the bug in fault_in_safe_writeable() looks good to me. > But I think that David suggested the other way around wrt. uaddr and > start variables in those three functions? I think he had in mind that > fault_in_safe_writeable() follows fault_in_safe_writeable() and > fault_in_readable() lead. Right, will follow the way he suggested in another sub-thread, thanks for careful reviewing. > > Other than that looks good to me. > > > -- > Oscar Salvador > SUSE Labs >