From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 326C3C369AB for ; Tue, 15 Apr 2025 22:56:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D058280012; Tue, 15 Apr 2025 18:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77D4F280011; Tue, 15 Apr 2025 18:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6454E280012; Tue, 15 Apr 2025 18:56:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 47069280011 for ; Tue, 15 Apr 2025 18:56:09 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5F1DAB3F33 for ; Tue, 15 Apr 2025 22:56:09 +0000 (UTC) X-FDA: 83337788058.15.FEE6982 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 5F9DD40006 for ; Tue, 15 Apr 2025 22:56:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X8lPjaOk; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744757767; a=rsa-sha256; cv=none; b=PAdlrVm4B7UHR3ss69e104/ZzMVpbKMj4I0hkE84g+Oiw8HL91l5tknnI0LXCqZ8QpT5vx JM1ao928iN0r71hkJBevFEAVz0HeWwPF9SG4ZzVIgMK8gyNo5lQQ2RLPsHUJPWwab3hdU4 VmET8Wu5FHJx4LgiDtvnwETFj793pOs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X8lPjaOk; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744757767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=imz0uv/7rUHpG5Wek2+5ECUg21ZObIxgPfHBxFulP7I=; b=aFH55NE+IXzTY3QDV02avCo0TmlDaAxnN20B2HNiVcSxPZOmWcvb9GmgX66l33a2Mpmkgs zTbWHVIxF0E4RnwnqK5dy23HNFZjTS9AvX1Bbf8gbqN5ncQ4oogQ7y0zaxpcusYu/TwnYw kmGHVlwJZLXUamjTcvSDGtY0+txNoBg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744757766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=imz0uv/7rUHpG5Wek2+5ECUg21ZObIxgPfHBxFulP7I=; b=X8lPjaOkrHH6jgjMcvJFaq3SZYoXmsHw+9dUWrug70pb5Rtlf9REbSWOcG+QsXIISK6tdF qG2S4dWcd3g/0wsvp8i03/yz/GTVrwtOqN0CnQbjozgGuaOfv+cjAsYEJ0bDF2Xn7/+7wx pQGVCMUJSOs+mLJS0SbHFBm3Bwd/nnY= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-e5qYF_mWO66aDl3gjCpCaw-1; Tue, 15 Apr 2025 18:56:03 -0400 X-MC-Unique: e5qYF_mWO66aDl3gjCpCaw-1 X-Mimecast-MFC-AGG-ID: e5qYF_mWO66aDl3gjCpCaw_1744757762 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D4F6119560AB; Tue, 15 Apr 2025 22:56:01 +0000 (UTC) Received: from localhost (unknown [10.72.112.38]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A49F01955BC0; Tue, 15 Apr 2025 22:56:00 +0000 (UTC) Date: Wed, 16 Apr 2025 06:55:51 +0800 From: Baoquan He To: Uladzislau Rezki Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] mm/vmalloc.c: code cleanup and improvements Message-ID: References: <20250415023952.27850-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5F9DD40006 X-Stat-Signature: rbuamrag17ifp9359x8m8k37hgczt6kx X-HE-Tag: 1744757767-801972 X-HE-Meta: U2FsdGVkX18qjttkhiWHmqpec9xEpO+SF5KRX4gD6qSl+6xwot6bmX2u77KouXBAXDF3Ggk6cK7W4oas+U9G7bq8zaIOEnbHMvi9hLq1eg+5B9QE1mAC1km6g0+CWM6oB8O5RKrh2EWv4p1lSjECOTXXkJOsL1a6eIR44M+h0VoRRl1hviS8oOnDuGx5KFJzeGw0zWBmFOPkGwrNmj30bAS1VFYk49baZsULKe8HfxVdhY5LvybCooGl9N0oI6PQwbT73l5WZ9og07sT5KJuAxol5QzRpEqmOSkkxYgeNBqRdXqi8boZAyYIJBohaGvpFk2zcgmsNma/pVEWcsuIuarz6LP5NZDMFtVt1fGo/XGyywTZn/dPXE5PLwMpGJpKXcZyl1tgYBA0gZuJfUM94woY3089cNskBr8XE7gYV6dq/sKc3e8GycH6lpQ7reu8yJvs3ozLzv4gZQB5C0Q3i4DQbKw3Z+bQ/v6dLJfcV9Pj2p0HHQ6SKAx2z3QHVM0TKtLsdlYxREtqHgvfRheLl1op5oAFetI/yhWNSrKDlYq3v29HsGyTUXnozppcIP6HCeolLiyJD7cw3lpcVJzOnwr5f5UpdHa98AVI0GD3AOMUmlr00iEhAqrumRCYTg64j1ROijD5SvM3B5oK13b1Bq0FUTLoAYmqQ3wQ5Ww/ea/u80VhyV8mw5enBxR5BZJ7UhSXFRo5kExBVaUwjYJ8SQzvxViev9nErKWB4al4l8OS7GInXpuVt9sp9CHpqeLKjXmQTmvimKqkIPrH2mSE+5D/QuI7KuB+foKtwr3IqVddZPNnUJU5MuqsFUJKtYy6KZIip0hh6RyokHqqnUqhpF500wL2PJbaAVd6y8XYc5ir47NW1ZSh/WXVmG28EFW+pR6IHloXFBkTJilZFPW/Zjb6OhPNgshFrm5F+CIGS1Y9oS9aR9ykWPzVbEwdMhSoTRqT5bN1lpn+LLb7GwH gvERtut8 cccx1viCXXe43+6s4UUX9dERb7oUcsT/NzpOXYbnlJoyHYiQKHwAOwdDGyci+lnXQpa5NMshngMgaYU9jV0wYTaXKBGOO7C+q2TS9cUXHZZumfRl6wEvxTWy1zuZntKwe6sxO0YV9BUcaKJVooVuvLvG4kogBZzs0YNtmFSjbSj3YkGuK947+Rw8dn+kK/xcXyMCIfX5Wqa9JwIobJNgPzy94O+G85m+6CnqvHo00wo5ZEfs81YrJLiTpnd5cxLctbhj02AHlK0VQP8eldg1IrUPL9QgV6TZYCwOQ+n6zB9E8rH1WXGyc6r93gaJwlG+80ZyD8trdPbu1MIQG4fYpWVn4HNxsxA02/BEPDlIgeGDvgW/p1xvGloCeP/6U3ySUkun0uyjSrd2Ilod1EMFPJOJyPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/15/25 at 05:29pm, Uladzislau Rezki wrote: > On Tue, Apr 15, 2025 at 10:39:47AM +0800, Baoquan He wrote: > > These were made from code inspection in mm/vmalloc.c. > > > > Baoquan He (5): > > mm/vmalloc.c: change purge_ndoes as local static variable > > mm/vmalloc.c: find the vmap of vmap_nodes in reverse order > > mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit > > mm/vmalloc: optimize function vm_unmap_aliases() > > mm/vmalloc.c: return explicit error value in alloc_vmap_area() > > > > mm/vmalloc.c | 68 +++++++++++++++++++++++++--------------------------- > > 1 file changed, 32 insertions(+), 36 deletions(-) > > > > -- > > 2.41.0 > > > I have review some patches, the rest i will check tomorrow! Thanks a lot for your quick and careful reviewing.