From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB432C433FE for ; Tue, 4 Oct 2022 12:59:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CAC66B0072; Tue, 4 Oct 2022 08:59:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 379916B0073; Tue, 4 Oct 2022 08:59:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 241396B0074; Tue, 4 Oct 2022 08:59:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 13AC26B0072 for ; Tue, 4 Oct 2022 08:59:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D1F30AB26E for ; Tue, 4 Oct 2022 12:59:13 +0000 (UTC) X-FDA: 79983272586.04.2D2544B Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf16.hostedemail.com (Postfix) with ESMTP id 696E0180011 for ; Tue, 4 Oct 2022 12:59:13 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id o5so8843584wms.1 for ; Tue, 04 Oct 2022 05:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=hlDBjgsrtiAB20EmVK+DqfPkxi/fwq2hkeX3Gk/vlHA=; b=NC2sElPURU94A+oZT2BzfOw2kmYw3KRFHsAnXhb22SKXLi3zTGbXxZ62puTz8/F1Fb Nlb98uIqmDLJycbNBoyhGYKudcng5U9JyJ4G+V/ys/U9uCqwiKRXrGHitNaInKvFYa5F ZhRk/FxclhHt5Zp7aT5sjisqPIRyD0m6Xbx4FPLu0OGipVJdNiRY2IyGVMKcuCewHy/r Xn9jJ7n7ZqQSZF5mXgLE9nyAJg0liZtWgFerVjYF9hYLVOuuZYfRAR/jCEcsPRPvfPTD Ort5nw8wcLiHX1EfKlB7ikt07Er56GwiHDpIIhmObSpoU2FvP5m4Zd9DHlU6mWyy6aZo Da/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=hlDBjgsrtiAB20EmVK+DqfPkxi/fwq2hkeX3Gk/vlHA=; b=7iixcG3E/4ZxyvkbzpEeNRTyo62G+et5/riPimT3vKlO0m5Yw7iESCU195WDoggE0w gfRc8lp3D7MTQLUkMS4LWFdD99B2+vv+yahPxsZC3OLjyuagJp2CCTM2rRJKj/vWWJbE TA8tjjFkk9sc4mVrsmennsQDXEDj8i1v6eXWbKxMXFAqNv25EGl8fD4to1k/oNysO58C GuHii1NLOGoksc+8WWdfJAzua3J4PItJAYElno4WdEVcUH66c+sWYYt5XLxgNwbztVxm gmGgp+5HUsS32gnfSRjCbr1p94aAQXaqBfQ3fD+tNv+xpYtqzbdHEawDlZf+IOGiHwU+ Ygfg== X-Gm-Message-State: ACrzQf15YP7H47+rVOjlg6dFoKKBJwH7rP8Y6wn+YZKa49s6z7jn+njv 6schb4tyYHj8mUL6iWwNUUDUs99jYg== X-Google-Smtp-Source: AMsMyM6gBzKWs6xHtQ1ha1QDGnLvIWXKrRpH5PfEVMSlaS5p+0i7Z7ps44ZaOrvVJrX/ZXjW+UEGCw== X-Received: by 2002:a7b:cb91:0:b0:3b4:75b9:5a4b with SMTP id m17-20020a7bcb91000000b003b475b95a4bmr9861463wmi.33.1664888023164; Tue, 04 Oct 2022 05:53:43 -0700 (PDT) Received: from localhost.localdomain ([46.53.250.140]) by smtp.gmail.com with ESMTPSA id m38-20020a05600c3b2600b003b4ff30e566sm4017998wms.3.2022.10.04.05.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 05:53:42 -0700 (PDT) Date: Tue, 4 Oct 2022 15:53:41 +0300 From: Alexey Dobriyan To: sethjenkins@google.com Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Jann Horn , linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: /proc/pid/smaps_rollup: fix no vma's null-deref Message-ID: References: <20221003224531.1930646-1-sethjenkins@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221003224531.1930646-1-sethjenkins@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664888353; a=rsa-sha256; cv=none; b=XHIyji4KTjTtPcu39BfZ8JfqNaUcH27y7Y4gUmwZCqVgno9nbTcqLF0V+TM2kPEaxiMN/J lRpmu4tnQUpyNd8PmiH8JyalUHnp2xCeK2lqcJQK18qJoKXmSVMa7Sg8e1JgeJkzXxE00z lKi+y4vK7miSPfJptXGj9Snlj/b+yXk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NC2sElPU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=adobriyan@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664888353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hlDBjgsrtiAB20EmVK+DqfPkxi/fwq2hkeX3Gk/vlHA=; b=FGHM9jQa61p88993np86YlLpsZx1AnETRliKul2vxDA5ZAJXlLeItae4cUl9DYjNURo5Gb uVp8k0E7L0gBYuWXKigeX6N7SH5xnJbpXmPnjehoKutWoB+Nn+aEuBLBQkyUuc64GXPRCZ +bWduGe+MaafC29VtPULkRHlHqoiwTs= X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NC2sElPU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=adobriyan@gmail.com X-Stat-Signature: w99rnpajprqk5qxb4yq6ntchzurtqijf X-Rspamd-Queue-Id: 696E0180011 X-Rspamd-Server: rspam09 X-HE-Tag: 1664888353-880880 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 03, 2022 at 06:45:31PM -0400, FirstName LastName wrote: > From: Seth Jenkins > > Commit 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value > seq_file") introduced a null-deref if there are no vma's in the task in > show_smaps_rollup. > > Fixes: 258f669e7e88 ("mm: /proc/pid/smaps_rollup: convert to single value seq_file") > Cc: stable@vger.kernel.org > Signed-off-by: Seth Jenkins > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -969,7 +969,7 @@ static int show_smaps_rollup(struct seq_file *m, void *v) > vma = vma->vm_next; > } > > - show_vma_header_prefix(m, priv->mm->mmap->vm_start, > + show_vma_header_prefix(m, priv->mm->mmap ? priv->mm->mmap->vm_start : 0, > last_vma_end, 0, 0, 0, 0); > seq_pad(m, ' '); > seq_puts(m, "[rollup]\n"); Reviewed-by: Alexey Dobriyan Tested-by: Alexey Dobriyan Now I know how to create stable process without address space.