From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F370C4332F for ; Mon, 3 Oct 2022 18:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E05728E0001; Mon, 3 Oct 2022 14:17:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBEC46B0073; Mon, 3 Oct 2022 14:17:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06978E0001; Mon, 3 Oct 2022 14:17:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AA2C26B0071 for ; Mon, 3 Oct 2022 14:17:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7452016070C for ; Mon, 3 Oct 2022 18:17:01 +0000 (UTC) X-FDA: 79980444642.07.3E1CC71 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf21.hostedemail.com (Postfix) with ESMTP id 92BD11C000B for ; Mon, 3 Oct 2022 18:16:57 +0000 (UTC) Received: from zn.tnic (p200300ea9733e749329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e749:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E11EA1EC04F0; Mon, 3 Oct 2022 20:16:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664821011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=2w76/y5fSDNg4MMUq2sZOt4nJbULUyV++7iAWk2cTIQ=; b=hvrms6oDaoSQMvX6bsRISlwVU1UnL3NPL+POl+uz4e3mdDksYWCYlVaBE1orql9puF3akq raxW6vLj36Z0Cdy6u1Jzb3PwF1f9R/FhgYk6CT/xuc0gTZrIzWzCdQ2FsZjAKQSRrnxn1d LRLLLSD8N9Xubs9+WayNNhecsCiARNI= Date: Mon, 3 Oct 2022 20:16:47 +0200 From: Borislav Petkov To: Peter Gonda Cc: "Kalra, Ashish" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "Lendacky, Thomas" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "dovmurik@linux.ibm.com" , "tobin@ibm.com" , "Roth, Michael" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "marcorr@google.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "dgilbert@redhat.com" , "jarkko@kernel.org" Subject: Re: [PATCH Part2 v6 13/49] crypto:ccp: Provide APIs to issue SEV-SNP commands Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664821020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2w76/y5fSDNg4MMUq2sZOt4nJbULUyV++7iAWk2cTIQ=; b=OjIYqLepy6s3MHzqo31EXDzJN+HNbHXSulLLT81KbCmRwcTnnA4K/779e+ETWvobMDSBht b11bFfIB3PMB0hzrHZkbdvs/aM+aTlY+4BbdyRVBTDYJCcPfJAbMzteWZ5YH4U5/NIw2z1 Vk1NcyT/L1kDrXCXZD9iuK3smlMDWw0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=hvrms6oD; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664821020; a=rsa-sha256; cv=none; b=P48RKOYZaGSEcuBJNTO7E/VGoP5ZjNxbFsc201CshTQIjHkOK6xD+tpT9ypeNZ0lCC2oqN XCSwYZWcZPlM9W7gvtD8/SC/56b2vUbP+Vgu6wPmobDmIDmdZPjU4WYia0qF7eWTwUHgbV 4icmBk++ZNLf+9BFqFwb5AKcETmpPBY= X-Rspamd-Queue-Id: 92BD11C000B Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=hvrms6oD; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf21.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: d3buzncs3hrbbwgik6suxumaftj3oosz X-HE-Tag: 1664821017-866826 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 03, 2022 at 12:01:19PM -0600, Peter Gonda wrote: > We already have sev_issue_cmd_external_user() exported right? > > Another option could be to make these wrappers more helpful and less > silly. For example. My point is, whenever something needs to issue a SEV* fw command, something adds a silly wrapper and this will become unwieldy pretty quickly. If a wrapper is not a dumb one but it actually does preparatory work before issuing the command so that the caller's life is made easy, then yes, by all means. If it is only plain forwarding a call to sev_do_cmd(), then I question the whole point of the exercise... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette