From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C2EC433F5 for ; Sat, 1 Oct 2022 01:23:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9C128D0001; Fri, 30 Sep 2022 21:23:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A26B86B0073; Fri, 30 Sep 2022 21:23:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C5518D0001; Fri, 30 Sep 2022 21:23:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 771C26B0072 for ; Fri, 30 Sep 2022 21:23:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4ABE4AC0E1 for ; Sat, 1 Oct 2022 01:23:12 +0000 (UTC) X-FDA: 79970632224.12.6C7F91D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id C430540009 for ; Sat, 1 Oct 2022 01:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664587391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DVbTStlwC6pTMq+P37M/ALkgq/u7RMkS0BdQLCeN6Hg=; b=O9DlKuaq9166RaGROy4pj/Dx6tigCbWcN8ITaG/rRWt/izNqK1L5TAx1bw2hhV7KFdC/Kh 0pFgLodcJIBYMC5THONJf07Lt/tYrU1mNNBYaRRlO9+0b1b2NU3VGsM4nBeKGt5pF2Jm2H TNzxZdW+hUZ/6vuxi+2ODZ7X6DCjJHk= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-599-P92BrCcdOhacqpVXn0WPnw-1; Fri, 30 Sep 2022 21:23:09 -0400 X-MC-Unique: P92BrCcdOhacqpVXn0WPnw-1 Received: by mail-qk1-f197.google.com with SMTP id i7-20020a05620a404700b006ced0d02b68so5020125qko.10 for ; Fri, 30 Sep 2022 18:23:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=DVbTStlwC6pTMq+P37M/ALkgq/u7RMkS0BdQLCeN6Hg=; b=PD4qFy7TL7k2OY3i7hO/R0MNfaBB1siOZtNUQsogQrtE1zmW27yZAbUUxVCAlruTx+ mJKpKBKmXV61oYirV2V0Uv+KG3dog601rNS2201WRDcaVeZ9mq/uHaU9xEl3N4cuBUF0 iOBAP0b3oREdcvSp1E6XSO29FhhkrBxqFUWp4H5PURZPSxCFcwCQMsZWbuQzVVBW70Gn exDKTXo9SlBb0oiLV8m4fisoSwRQD/PzYKJu5owuERspOI7MnZjxVtuGAcA/LqkJ+cG8 GfdM5rxHKuOKNKTd8XmHpMWDNQJtVMujhqEByKdN7xi7RoWYgb6x8Gpbox9lVYISUscX dTNQ== X-Gm-Message-State: ACrzQf1MSTuBMjtlCKV17uWJJD6pyLAVhxKR4W4Wbrw4iUWSYnVSpWw8 CdWhXuwhTL7VtDHV+quNDwp71KnZF0fl1eT7lraO+rW6fFyQYg0Gqutl3Z28ca+1aw3fkEqaWMZ JwlaYLjrpb+k= X-Received: by 2002:ac8:7f48:0:b0:35b:bac4:c472 with SMTP id g8-20020ac87f48000000b0035bbac4c472mr8985702qtk.442.1664587389514; Fri, 30 Sep 2022 18:23:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7VuQVKY5fLsLbzl4g/Glj+K38DAyT8Qy+Xx4IhK30VygSWMCJjiuLCyKLN3eoRqM7sSs2w/Q== X-Received: by 2002:ac8:7f48:0:b0:35b:bac4:c472 with SMTP id g8-20020ac87f48000000b0035bbac4c472mr8985687qtk.442.1664587389189; Fri, 30 Sep 2022 18:23:09 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id r24-20020ae9d618000000b006ced196a73fsm4009510qkk.135.2022.09.30.18.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 18:23:08 -0700 (PDT) Date: Fri, 30 Sep 2022 21:23:07 -0400 From: Peter Xu To: Andrew Morton Cc: syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Edward Liaw , Axel Rasmussen , Liu Shixin , Brian Geffon , Mike Kravetz Subject: Re: [syzbot] WARNING in change_protection Message-ID: References: <00000000000046580505e9dea8e4@google.com> <20220930164211.b8215770d44e1a3803f1e660@linux-foundation.org> <20220930181415.31c2ee66166d4e1c6c0eac64@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20220930181415.31c2ee66166d4e1c6c0eac64@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9DlKuaq; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664587391; a=rsa-sha256; cv=none; b=wkG1a2aDwbabj0/on4tqjF9yoxEubH8UqX4NlBqUkBH9nl7EDgrjmwHVwlYBckmJyvBAsf eLcYXvG7E9NETHPZCkawGqpU5yPNWjHTbL8b/HbHGw6TdeO4tVoDJAPX82ANV6PLJnlY9W PdqgJM/kKACU6fkZULt9CtRzK8MCXUM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664587391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DVbTStlwC6pTMq+P37M/ALkgq/u7RMkS0BdQLCeN6Hg=; b=dkhQ/QB0bvkds4ePKnJiQYWZeDDIWYuH7QGq1bfZOhPXkjelPKFM80yXi/oNwsqR+N/X7h e+R5z0JYtzYAcFehc+Ry6kD+Eyuq28r6MULF4xDw0DFwEEQzaCKoUSYbavmZTp7TMcMky4 iHDPGtQRtiy7aJvv5ZAP6+j1ka5qyKY= X-Stat-Signature: 5ifa9hay39mzugh14cbk1nypc6uqcgtc X-Rspamd-Queue-Id: C430540009 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9DlKuaq; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664587391-125817 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 30, 2022 at 06:14:15PM -0700, Andrew Morton wrote: > On Fri, 30 Sep 2022 21:03:53 -0400 Peter Xu wrote: > > > When PTE_MARKER_UFFD_WP not configured, it's still possible to reach pte > > marker code and trigger an warning. Add a few CONFIG_PTE_MARKER_UFFD_WP > > ifdefs to make sure the code won't be reached when not compiled in. > > Thanks. > > Is 679d10331910180 ("mm: introduce PTE_MARKER swap entry") the > appropriate Fixes: target? I forgot the stable notations, sorry. Probably better use the one that enables the whole thing, because the diff will touch a few patches later than 679d10331910180 too, which means the suitable tag could be: Fixes: b1f9e876862d ("mm/uffd: enable write protection for shmem & hugetlbfs") > > Should we backport to -stable? Yes, 5.19 may need it too (if it'll still squeeze into 6.0; or 6.0 too). -- Peter Xu