linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: syzbot <syzbot+2b9b4f0895be09a6dec3@syzkaller.appspotmail.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	syzkaller-bugs@googlegroups.com, Edward Liaw <edliaw@google.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Liu Shixin <liushixin2@huawei.com>,
	Brian Geffon <bgeffon@google.com>,
	Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [syzbot] WARNING in change_protection
Date: Fri, 30 Sep 2022 21:23:07 -0400	[thread overview]
Message-ID: <YzeWe/1D6L8uuP/o@x1n> (raw)
In-Reply-To: <20220930181415.31c2ee66166d4e1c6c0eac64@linux-foundation.org>

On Fri, Sep 30, 2022 at 06:14:15PM -0700, Andrew Morton wrote:
> On Fri, 30 Sep 2022 21:03:53 -0400 Peter Xu <peterx@redhat.com> wrote:
> 
> > When PTE_MARKER_UFFD_WP not configured, it's still possible to reach pte
> > marker code and trigger an warning. Add a few CONFIG_PTE_MARKER_UFFD_WP
> > ifdefs to make sure the code won't be reached when not compiled in.
> 
> Thanks.
> 
> Is 679d10331910180 ("mm: introduce PTE_MARKER swap entry") the
> appropriate Fixes: target?

I forgot the stable notations, sorry.  Probably better use the one that
enables the whole thing, because the diff will touch a few patches later
than 679d10331910180 too, which means the suitable tag could be:

Fixes: b1f9e876862d ("mm/uffd: enable write protection for shmem & hugetlbfs")

> 
> Should we backport to -stable?

Yes, 5.19 may need it too (if it'll still squeeze into 6.0; or 6.0 too).

-- 
Peter Xu



      reply	other threads:[~2022-10-01  1:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30  5:56 syzbot
2022-09-30 23:42 ` Andrew Morton
2022-10-01  1:03   ` Peter Xu
2022-10-01  1:14     ` Andrew Morton
2022-10-01  1:23       ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzeWe/1D6L8uuP/o@x1n \
    --to=peterx@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=bgeffon@google.com \
    --cc=edliaw@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liushixin2@huawei.com \
    --cc=mike.kravetz@oracle.com \
    --cc=syzbot+2b9b4f0895be09a6dec3@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox