From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F5CC32771 for ; Wed, 28 Sep 2022 18:46:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 730C86B0072; Wed, 28 Sep 2022 14:46:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E19B6B0073; Wed, 28 Sep 2022 14:46:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 583926B0074; Wed, 28 Sep 2022 14:46:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 477ED6B0072 for ; Wed, 28 Sep 2022 14:46:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1558916042E for ; Wed, 28 Sep 2022 18:46:27 +0000 (UTC) X-FDA: 79962374814.17.F80D601 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf26.hostedemail.com (Postfix) with ESMTP id 9A059140016 for ; Wed, 28 Sep 2022 18:46:26 +0000 (UTC) Received: by mail-il1-f169.google.com with SMTP id m16so7063505ili.9 for ; Wed, 28 Sep 2022 11:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=LpxoywpaQZbEd7HNklvkbE+pBYLLyfSwOdEaf41jsQ0=; b=kWM/3CIyRI6nfI+De5JUNdFwTItNaQXTWqbDTabs6UaUl/0MCPJIFdwWe1TWp0THQt pyuVI/kmr0tZXHf86RfvoAy2tWcuMABnOLuW9Hx3mry5zD2o7haITtjPCiSFjM2w7SMk OmTU9AKIiMlvgQ/AS4vDI7wJt4dCTGI/izxGoJAXjKUgLrbtrQK0iFKQSvp8hiIE460w 7K+IGuJlBsXOCkKO3CfPBBEq2dq75P1+C0RpyxQxXTccXXClJS6elMDN9J4+1PcOC1qX ni21VCsI+ZJbnh3VosmGkjkU06nDSzTiDMUgBqSuNo1eH1cMXYU7F2qVJRhcxfl2gC7G Ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=LpxoywpaQZbEd7HNklvkbE+pBYLLyfSwOdEaf41jsQ0=; b=In77i9djzYWAmZOzwu+odAQQ/5/4dDbL/D0rbSxX25V7Zu2PLB32gKbIBNuHZf74eX 9tSgIoVo42pYm+6a94Jd7EaxUmG7/0s5+V6X/nG6XqczxqPKRZT7zj6FUwERE294jMc0 ixF/8eAE1uj4F5XdYy/Igf9j39W8lSX6H5uokmHbowISXSnjoSLbA5LjX2e2VDmB21Tn el+5I+W011hAOboqyP0u5yVXD5aGGknYJUDmrPvZz3sdivoOCSZMaieuFd5BGiGSf/bZ U1u6rjrRepM+FBJg0Uy9se9zq+zeWWGWL1Jarpdp2CM9llFfmy+E9z20szdF5gASkasx Ll0Q== X-Gm-Message-State: ACrzQf2VHBSJ/t/EW/FxdTIzPWmG823cslHLSDzYkF+tQRtwlXVLxAbm 3A2dFGW7MB3JXY1b7x3IEuf3gg== X-Google-Smtp-Source: AMsMyM6KnMs6h0Vv/mW+gYrgQ8avvnHmbBJG/o6ac7PBd3Tr7J6tylm8KXP4s2KRm+MwddNuokxv1A== X-Received: by 2002:a05:6e02:16c7:b0:2f6:6eb4:8df3 with SMTP id 7-20020a056e0216c700b002f66eb48df3mr16415870ilx.31.1664390785536; Wed, 28 Sep 2022 11:46:25 -0700 (PDT) Received: from google.com ([2620:15c:183:200:e132:6c29:fb2a:a1b]) by smtp.gmail.com with ESMTPSA id cq5-20020a056638478500b003428c21ed12sm2058124jab.167.2022.09.28.11.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 11:46:25 -0700 (PDT) Date: Wed, 28 Sep 2022 12:46:20 -0600 From: Yu Zhao To: Andrew Morton Cc: Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH mm-unstable v15 09/14] mm: multi-gen LRU: optimize multiple memcgs Message-ID: References: <20220918080010.2920238-1-yuzhao@google.com> <20220918080010.2920238-10-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220918080010.2920238-10-yuzhao@google.com> ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="kWM/3CIy"; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664390786; a=rsa-sha256; cv=none; b=OlEj7lhGqGSjVhHl9ohee5PTKCaZd06uWyuc277b0bqWOMMnc2dplRbmi1I9AS6BbOqwyP Tvfg3C4Sm8bQ+p48RKXXu82del9ib1iinwVb7C1abHK8LT86Pd2YidGVhsxwJ0soqlQnpH SfnQ3MEMwESPfDL1Tk0n/IiAWd63HgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664390786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LpxoywpaQZbEd7HNklvkbE+pBYLLyfSwOdEaf41jsQ0=; b=ttYsYSagnw2JgacB69+x5uFVL7ranZIj+tYA4P3ZszfU8kWkZDKBzclm+kEaMKgcIJBH0o BmzGVyT5eWQRXTKpsszAsJBQ66lAY/cQ7sfZ+hJ74oaSXPNjrFIx5/2dQeajz1+S766Hvr xW6mfXqkbmBNiLuYc/P1FQwweUDQVCo= X-Stat-Signature: xhnn8qf96f8pq8yz47rmew84uwmjo9m4 X-Rspamd-Queue-Id: 9A059140016 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="kWM/3CIy"; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664390786-322581 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, Can you please take this fixlet? Thanks. Fix imprecise comments. Signed-off-by: Yu Zhao --- mm/vmscan.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index a8fd6300fa7e..5b565470286b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5078,7 +5078,7 @@ static bool should_abort_scan(struct lruvec *lruvec, unsigned long seq, DEFINE_MAX_SEQ(lruvec); if (!current_is_kswapd()) { - /* age each memcg once to ensure fairness */ + /* age each memcg at most once to ensure fairness */ if (max_seq - seq > 1) return true; @@ -5103,10 +5103,9 @@ static bool should_abort_scan(struct lruvec *lruvec, unsigned long seq, /* * A minimum amount of work was done under global memory pressure. For - * kswapd, it may be overshooting. For direct reclaim, the target isn't - * met, and yet the allocation may still succeed, since kswapd may have - * caught up. In either case, it's better to stop now, and restart if - * necessary. + * kswapd, it may be overshooting. For direct reclaim, the allocation + * may succeed if all suitable zones are somewhat safe. In either case, + * it's better to stop now, and restart later if necessary. */ for (i = 0; i <= sc->reclaim_idx; i++) { unsigned long wmark; -- 2.37.3.998.g577e59143f-goog