From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD07C04A95 for ; Wed, 28 Sep 2022 17:29:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C9F96B0071; Wed, 28 Sep 2022 13:29:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4795A6B0073; Wed, 28 Sep 2022 13:29:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 368956B0074; Wed, 28 Sep 2022 13:29:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 236F86B0071 for ; Wed, 28 Sep 2022 13:29:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BFDC6A0BA7 for ; Wed, 28 Sep 2022 17:29:35 +0000 (UTC) X-FDA: 79962181110.09.9844B3F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id AC1EDC0016 for ; Wed, 28 Sep 2022 17:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wAJVGUUycbEK++mK2GtQlUllFwvg0L4+DDRRHw8L3lU=; b=m04TZ0Je7pVq359Ag3aKAx99jh QamCf0hjwJfSEzgeHnWdCn6lbKh6W75Hra1YLnbdYfM3CR/DdVySuDkh9VPtbW35CfI1A3EczvnBu RnzL19Linm6l9A6nPOZHd4KnZRpZsMimXAWxYcbD7/i+MF4WUzFIgqukSsv1C7MQvo/KqMK60S9Vv XRAcjjMbVDnx0OAjVTTeNGXmmTu2f09UNt1eSYOB5YeCE8/UbWMu64/jswNqgQdLLHvZIquU31Agn a6fqZyC6gsHrYy15MP9k0P+X0ekv7La5z/f40dT+l9tTGTlZniKYgUUwLlbbyzzrHC26OThFC+tDh QScOf00g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1odasH-00CXS6-B5; Wed, 28 Sep 2022 17:29:33 +0000 Date: Wed, 28 Sep 2022 18:29:33 +0100 From: Matthew Wilcox To: ananda Cc: linux-mm@kvack.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v5] mm: add zblock - new allocator for use via zpool API Message-ID: References: <20220928080100.19134-1-a.badmaev@clicknet.pro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220928080100.19134-1-a.badmaev@clicknet.pro> ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m04TZ0Je; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664386174; a=rsa-sha256; cv=none; b=ohroxgVDwuWpZYDa/kzxsnaWt2rEkGVxxbwnsk/uZatA4FXHg3rDPfFTCenJIrHHkOcb5t TjgBK9rjGukoCBpxAm4+QnPASAYq7OsrrK9/HaSzAGzQ/LsfbHQR6MIufqOf+Qh2o3mX2V JSGMUFlydbNsrP0SY1Gy4XE3G5ljhoU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664386174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wAJVGUUycbEK++mK2GtQlUllFwvg0L4+DDRRHw8L3lU=; b=kS/JbDFOwsXY+yuT7fzOhvDBz4CI4+q1+T+6gZ7CHzynu4wlQgASO7bndrphZyPhAgpYGP LUPZostxmaCRM7nAsyzI4ndAyWqb0/jm25/HSpQImE8/OlgKm6qVYJyEa647B5RJZZ95Xg SUIlI/OBqgsZRkRchhZR7xoFV8bE3no= Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m04TZ0Je; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: nsz1iktr1zf6aufnxm7zpq1k36fmgk6m X-Rspamd-Queue-Id: AC1EDC0016 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1664386172-999650 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 28, 2022 at 11:01:00AM +0300, ananda wrote: > +static struct zblock_block *alloc_block(struct zblock_pool *pool, > + int block_type, gfp_t gfp) Your indentation is completely screwed up. What are you trying to do here?