From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13372C54EE9 for ; Tue, 27 Sep 2022 12:16:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67F8A8E00CE; Tue, 27 Sep 2022 08:16:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62DB78E00C1; Tue, 27 Sep 2022 08:16:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5668E00CE; Tue, 27 Sep 2022 08:16:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 430938E00C1 for ; Tue, 27 Sep 2022 08:16:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 07577805D8 for ; Tue, 27 Sep 2022 12:16:26 +0000 (UTC) X-FDA: 79957763172.27.29090FE Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf07.hostedemail.com (Postfix) with ESMTP id AA0FC40002 for ; Tue, 27 Sep 2022 12:16:25 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id e129so3167483pgc.9 for ; Tue, 27 Sep 2022 05:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=yPFntR9/mCadEpXcQATRbftBmHGgFITCK1PZVUoDa5M=; b=VoBhv/vx3Dyt7a+5tjIrQKoiK/32bqqzw3DFhQAvIQ2U2NpI5Iwb9hblDSLjBWLbx0 QcXEJS9r/0jsao3abY6q8eObMjMWLS9Q8JLerW+SpZ8e2pyURC8FkvrUTpEVyJVkRJWB mYtKPnyc8aLDh0k0jrdvKJO6mio0gVnymrCAKBdwzuyMQEQCQH3PeExl0F6dx32Wh+xM jiu/wdJHvEvNgTbzLboR4/0XQUgnaihG2KF038FWO+KLxKcoUQDxMuxcffKpLOL+Pe35 dYYvp6/SuAPS3ZicYBV12uc2CJkQlo1Ukc7zm31KLa36sCIIQ/3cu66yreGo2g4jstjA M4Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=yPFntR9/mCadEpXcQATRbftBmHGgFITCK1PZVUoDa5M=; b=2HRBDo0hP2W2WMlgzC4jEYOiSxWTbrqbSdqcrV7aNY9TwGQMQIY5s1ZFlfhBmLpbrG EycBJvtTzLfdJrBYtxWjxFQudqoF0nDcMd7lhS4Rrlt4B18xq+d5Y/2qZ2qGUDI2TGm0 R+mRHu0T34ipHUsx6JwTpABDek9N9kMLeigMkMf5/q5MobXyfIVhoh+RAHJBTEob50ya +3IQcV/G7lFtNf+kdT4HMO4yGTuwl2lrMVR/gTdsOCTS7TALaBKayGE5WQxDiZVlLlfr PmwDjkzcVTCKKCR7STViiQKlx1xOyI2t0Vs41fjqOTzAcIBQaZD0uWIs1uuUFLJ+KcAS Fihg== X-Gm-Message-State: ACrzQf3V3z+L2/4cHxSnYQF5RMJFSg+px+TtClXyDu8UAXA2dJWx67yA e5RN8OEWmym0/VwkkccVOjw= X-Google-Smtp-Source: AMsMyM45fFoygZTDhSWITjzGqfccjFhrKypaNJiTaiNspHnLb45SDtZJgVq2ZW7hGYytwSOzCUGu6A== X-Received: by 2002:a65:40c8:0:b0:434:dfee:8dc1 with SMTP id u8-20020a6540c8000000b00434dfee8dc1mr25088969pgp.156.1664280984637; Tue, 27 Sep 2022 05:16:24 -0700 (PDT) Received: from debian.me (subs28-116-206-12-58.three.co.id. [116.206.12.58]) by smtp.gmail.com with ESMTPSA id y18-20020aa79432000000b0054087e1aea4sm1644771pfo.15.2022.09.27.05.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 05:16:23 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 31EE11004A5; Tue, 27 Sep 2022 19:16:19 +0700 (WIB) Date: Tue, 27 Sep 2022 19:16:18 +0700 From: Bagas Sanjaya To: Hui Tang Cc: naoya.horiguchi@nec.com, linmiaohe@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hwpoison: fix build error without CONFIG_MEMORY_FAILURE Message-ID: References: <20220927102946.98622-1-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7Fj09Ln2Ru7zIzIm" Content-Disposition: inline In-Reply-To: <20220927102946.98622-1-tanghui20@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664280985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yPFntR9/mCadEpXcQATRbftBmHGgFITCK1PZVUoDa5M=; b=hNa76a9uKoYrtwc2/RjtQJjTHCyeRRl/D5wOjtUAHopB+3aCQVh9waCXBimvKZSVSVx+s5 jRnG/IK8+aNkct8XmLL+a64/1oVavlkkQHJRgjyxlOJHhQRVQVenoZkk+iusxccQTn8S0a 2JGphglLnZBjpOusUDiH8Z7Iq8amt4M= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="VoBhv/vx"; spf=pass (imf07.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664280985; a=rsa-sha256; cv=none; b=OET/iWMAqxQ9REBKajiN0eEnEFKCIg0McKjemvnMS9mxcTcLboihwmrGGlR9gtKIYwhH4+ PAlpJxTebn5x68a4l4NdWdFoV+wQAclWZVSKlbGVPnjVowM0U7n/obLoPwYtEztayl4WEE r0e0yADDSYcpkZf6BHKeUtAGXbfUrVI= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AA0FC40002 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="VoBhv/vx"; spf=pass (imf07.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: ud6mmfsazhciu7wmodkj5emosdwydmuw X-Rspam-User: X-HE-Tag: 1664280985-36020 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002647, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --7Fj09Ln2Ru7zIzIm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 27, 2022 at 06:29:46PM +0800, Hui Tang wrote: > Building without CONFIG_MEMORY_FAILURE will fail: >=20 > mm/memory-failure.o: In function `action_result': > memory-failure.c: undefined reference to `memblk_nr_poison_inc' > mm/memory-failure.o: In function `page_handle_poison': > memory-failure.c: undefined reference to `memblk_nr_poison_inc' > mm/memory-failure.o: In function `__get_huge_page_for_hwpoison': > memory-failure.c: undefined reference to `memblk_nr_poison_inc' > mm/memory-failure.o: In function `unpoison_memory': > memory-failure.c: undefined reference to `memblk_nr_poison_sub' > mm/memory-failure.o: In function `num_poisoned_pages_inc': > memory-failure.c: undefined reference to `memblk_nr_poison_inc' >=20 > Add CONFIG_MEMORY_FAILURE wrapper for invoking memblk_nr_poison_{inc|sub}. >=20 Better say "Guard memblk_nr_poison_{inc,sub} under CONFIG_MEMORY_FAILURE". --=20 An old man doll... just what I always wanted! - Clara --7Fj09Ln2Ru7zIzIm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCYzLpjQAKCRD2uYlJVVFO o9YBAQD/LB+J7Ig7JbBnO41XhpCDYSN+JBqJiiG4joXsED0x/QEA5/tSHh66ldz1 3wWSJzbXTRZedc5ywsbxCA8SFsrLowE= =+nSn -----END PGP SIGNATURE----- --7Fj09Ln2Ru7zIzIm--