From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE8B4C433F5 for ; Thu, 6 Oct 2022 23:38:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B4306B0072; Thu, 6 Oct 2022 19:38:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13D3A8E0002; Thu, 6 Oct 2022 19:38:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF8E58E0001; Thu, 6 Oct 2022 19:38:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DBD866B0072 for ; Thu, 6 Oct 2022 19:38:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 96A881C6AFB for ; Thu, 6 Oct 2022 23:38:31 +0000 (UTC) X-FDA: 79992141222.20.F00DF9E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 0181620010 for ; Thu, 6 Oct 2022 23:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oOLFoz2ScuEP6dVb0gaYdy4OAdRu69MR7MjrV0Tmd4Y=; b=oDbgZqj70hQA5CMLaGbk548qz6 Lpp9gS8LU047NO15e/mNQfZEIMy1gPyvc1TKC1N8J860IroU5rzMGmsvd/Hen+5OVIhkMaw/6mvnk xURfiqfg20izKMGjTJDUsDlsS6l/yEYZcePWUvZPphW4Dt41AohHMcfxo4qWklcSI+5kSMOcIZq7g 7zh3Ru8BpzqQJM4oKoDm9xH/ZezZTntlQMzv7AVnlstyReuAIY2qZ9Ov2AdUwilNSO1/7sb8t7Mst 7R9khJwzSovU+GtE8zAY6o1QWlc884YOODVfUYnhZVcTc6rV3/LRoHZo5vceMelLYCcHn85G+ZAar SzttgOAQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogaRg-005zxj-6r; Thu, 06 Oct 2022 23:38:28 +0000 Date: Thu, 6 Oct 2022 16:38:28 -0700 From: Luis Chamberlain To: Song Liu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, kernel-team@fb.com, rick.p.edgecombe@intel.com, dave.hansen@intel.com Subject: Re: [RFC 3/5] modules, x86: use vmalloc_exec for module core Message-ID: References: <20220818224218.2399791-1-song@kernel.org> <20220818224218.2399791-4-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818224218.2399791-4-song@kernel.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665099511; a=rsa-sha256; cv=none; b=hfxEQ6n4ChcR0c78CCh18ATJQAaXF2MaGvMAK47aEYxP0x5Ii/Zz8aW1poxZaQGIhaNqwp 78CktBoSnrtPWXYusCuP29eW1H4FQzbUQHutO1Xe/TNX01ai7OWCh5F6XhQpw9/ZHSm9k3 5dkJJYCabL7a/jA8vuLXqxdhykgEymQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=oDbgZqj7; spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665099511; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oOLFoz2ScuEP6dVb0gaYdy4OAdRu69MR7MjrV0Tmd4Y=; b=F41AfnkJtNyACr72wjPctLcy0yZseEAaZVwfPrkRY00iZ7sZhaNeF2B8HNZrbEKh3UKOXU TGC4JcoTCXbyrK2a79gSeQKoh0L7k+kpCVwvmsGMpNO3CjAfakcluD0A83rheoGsjnvKbX +qHPiLm6Rubtr/EPe6RQ5eupoFXOyM4= X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=oDbgZqj7; spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Stat-Signature: 3r55euzmape4adpsayrcw4j61m88zbxs X-Rspamd-Queue-Id: 0181620010 X-Rspamd-Server: rspam01 X-HE-Tag: 1665099510-213001 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 18, 2022 at 03:42:16PM -0700, Song Liu wrote: > diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c > index 100446ffdc1d..570af623e28f 100644 > --- a/arch/x86/kernel/module.c > +++ b/arch/x86/kernel/module.c > @@ -229,6 +229,7 @@ int apply_relocate_add(Elf64_Shdr *sechdrs, > bool early = me->state == MODULE_STATE_UNFORMED; > void *(*write)(void *, const void *, size_t) = memcpy; > > + early = false; > if (!early) { > write = text_poke; > mutex_lock(&text_mutex); As per 88fc078a7a8f6 ("x86/module: Use text_poke() for late relocations") I'm curious why we have to take the live patching path now all the time? Luis