From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C875FC433F5 for ; Thu, 6 Oct 2022 13:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2283A8E0002; Thu, 6 Oct 2022 09:15:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FDC48E0001; Thu, 6 Oct 2022 09:15:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07AE18E0002; Thu, 6 Oct 2022 09:15:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ECA328E0001 for ; Thu, 6 Oct 2022 09:15:39 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B3A4A1401B8 for ; Thu, 6 Oct 2022 13:15:39 +0000 (UTC) X-FDA: 79990571598.15.C949985 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf07.hostedemail.com (Postfix) with ESMTP id 26CEA40017 for ; Thu, 6 Oct 2022 13:15:37 +0000 (UTC) Received: by mail-qt1-f178.google.com with SMTP id e3so126812qts.1 for ; Thu, 06 Oct 2022 06:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=GSOPunDdTF0UIVvBpION9xBpexDiGo+rjOxipFbXtOA=; b=j4TXfdYhCC5IuPEKT7c142DGOyyUICiYEJ2rQ5pM4q0yiZx4WA0kHStxgeCysxKdIn TuxQmiKuGnCh2iLv5lCSAeVvdfZCgr0gslAO6C/wmbiJpJE+HGv9p0BlGAp2YHTd7MAZ JFShEKjZddNRI3EB69zxWrjNCIn5FEtT938q5Kh600byBOTgEAyr3Cw5BxKLykg6qGKZ putHsZDuOr6KOj1BUasiDhf52tRH/Ed62HmMrAEpEsYDeTWjqgqViGX5p251folDWhG6 /9qz6hzxVHLZMa8vddlM+hc6XFLs5D7qWuuoVr7OgpiuiN/JdE0keFKPOZzvhwuMVbjX g/wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=GSOPunDdTF0UIVvBpION9xBpexDiGo+rjOxipFbXtOA=; b=aYtdK/pLieFKzgsyvwNf/9PKFra0hMlNJicJ+v/ws7Hfw2k3k++I28Hmb/1uk6ajGR b/wlRiAAnGeEm7caYsB0ctqLWD3Jhya+N1Dgm5iX4sBoZBJG+yZTkNrvIqpZ7XU7OTMn 4exD3f5nr0HPAmUUUx+Ofodj3no+iKYdxUiuhXFpupU9pUshg7Yhzq9v9bccn4iHSPSU tSIOZhO4erwwsUqsVJEIQRb5CjEL5neYOE37ncr39M3YB2kANZOOR8qiTJlTi1SZfWSc M0gHGvht/EoC9Ge6r3tV0c0y2xtF5hwr8hDRFTVijjWzJb8LPHc9gPJUwGW5eW6I3EXr 1Pyg== X-Gm-Message-State: ACrzQf28HtHdrfeq8BCQYjZ+xVCTRKJn4UnHE7rLs/SHo/qjEknKqEhW n5pi0qyNghbzL766PY5kagXsvg== X-Google-Smtp-Source: AMsMyM4GpHypPhwf4qnIOCDMCCPPCaDHHZXra2UnB6U4hePjwcf7/TKsWZTRJwrBHYFFgt7B+K7zfA== X-Received: by 2002:ac8:5703:0:b0:35c:c3f6:5991 with SMTP id 3-20020ac85703000000b0035cc3f65991mr3383265qtw.185.1665062137334; Thu, 06 Oct 2022 06:15:37 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id k11-20020a05620a0b8b00b006cbc6e1478csm18686320qkh.57.2022.10.06.06.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 06:15:36 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ogQit-00A1hY-6O; Thu, 06 Oct 2022 10:15:35 -0300 Date: Thu, 6 Oct 2022 10:15:35 -0300 From: Jason Gunthorpe To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, cake@lists.bufferbloat.net, ceph-devel@vger.kernel.org, coreteam@netfilter.org, dccp@vger.kernel.org, dev@openvswitch.org, dmaengine@vger.kernel.org, drbd-dev@lists.linbit.com, dri-devel@lists.freedesktop.org, kasan-dev@googlegroups.com, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hams@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-raid@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xfs@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, rds-devel@oss.oracle.com, SHA-cyfmac-dev-list@infineon.com, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: Re: [PATCH v1 3/5] treewide: use get_random_u32() when possible Message-ID: References: <20221005214844.2699-1-Jason@zx2c4.com> <20221005214844.2699-4-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665062138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GSOPunDdTF0UIVvBpION9xBpexDiGo+rjOxipFbXtOA=; b=Y2a/WyceDWb3AUs2t0x8duOIxsRwYvy8OsrE/gJXt6j2x8nvP6UVDMZMmemXXXGI0zZWD7 48wvaZTf5JelP5LX8M1tMI+z1Kno+vXTTZWn3PeLaJvNVCaNNbpcq6pwdBhDg5REnZ9ALv Fyk757FQ6VuMz5PEByWdD0xKl9VzGXs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=j4TXfdYh; spf=pass (imf07.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.178 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665062138; a=rsa-sha256; cv=none; b=DvK6fVw5feZe57RtTMiMCE2IupjTcI8KLvzYMJ9TTx2UMPfZbfEse7ItC5LbJj/v705rmf YhzCh8j1NZHC81/hn3qwvmmuzj/b1bwuCz7/8+uGeUB2NeDAmmX/pJUwnIh9QZUOmP0yEC 3RGcwHxvw1NxjHoIi31gDWym4Oh0hAM= X-Rspamd-Queue-Id: 26CEA40017 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=j4TXfdYh; spf=pass (imf07.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.178 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: dyqzegmmb3g1yijbgw54xte7fdza7ip7 X-HE-Tag: 1665062137-41003 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 06, 2022 at 07:05:48AM -0600, Jason A. Donenfeld wrote: > > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c > > > index fd9d7f2c4d64..a605cf66b83e 100644 > > > --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c > > > +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c > > > @@ -465,7 +465,7 @@ static int ipoib_cm_req_handler(struct ib_cm_id *cm_id, > > > goto err_qp; > > > } > > > > > > - psn = prandom_u32() & 0xffffff; > > > + psn = get_random_u32() & 0xffffff; > > > > prandom_max(0xffffff + 1) > > That'd work, but again it's not more clear. Authors here are going for > a 24-bit number, and masking seems like a clear way to express that. vs just asking directly for a 24 bit number? Jason