From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C988C433F5 for ; Thu, 6 Oct 2022 04:19:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B39766B0071; Thu, 6 Oct 2022 00:19:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE8D66B0073; Thu, 6 Oct 2022 00:19:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 988D66B0074; Thu, 6 Oct 2022 00:19:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 80B0C6B0071 for ; Thu, 6 Oct 2022 00:19:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5546441031 for ; Thu, 6 Oct 2022 04:19:36 +0000 (UTC) X-FDA: 79989220752.12.32D776D Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf17.hostedemail.com (Postfix) with ESMTP id B676140019 for ; Thu, 6 Oct 2022 04:19:35 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id t7so356411qkt.10 for ; Wed, 05 Oct 2022 21:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R4VEh9i/QK9xTQL6ExiIgh+tg9GqBfC90q8qqSObsBU=; b=sZL9/JucKLz3kza/Ci0aE4mVLQuA02JUnRd0KZ+JjmTvCYZBC54ujscNSfmQ/NxErl TBJxwh2iZtm7uXDfkJufgPQ+xGw1njpAaiBlaqgy+2mkenaYeIj2LxooAMyYvv+iFdQP TOnXK2UPvQ0tNG7A3YwlRfQmV5CMnuf8jD4P+ac5y2/XUyIZgT3NgkrCOn46rsnBY7iA dVo+PTwO2hWBzCNR8+P7nWKid7JTLjWfYHCzde0xqyh8Q44PTs7Fu3uDqvfG5I+sbALj u56wTAUzxDi/JxYTiGVAo5YQ9kbM+v0953iBfko68HZuZSyWrunAPEzP226mMlwTQj71 n57g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R4VEh9i/QK9xTQL6ExiIgh+tg9GqBfC90q8qqSObsBU=; b=m/bDrmXlvPt7yLvb9XPQvQjrd2DeaUkuasOuYurgsr5AuBgWlzjuoQ2yM9m+LuaxuW INg8rQp5jcizcSUkMcd8tUPJknQW1HB22Nau03Y+OyviIYzPX7VOgVC9PqgM2oMusOpU JGm704a4YNwukhf0xwMEdtQ1Ja6IQM6XI/hqIr2XU0u3TEn1/KWbLCyffnmWo11OnbEk 3GkabhfknvDKCEvxLRM0dPo2nQgBdoWLFQvefUGn4uc+SmWwgSIvHlC8eTZiKdlNYW7Y dGWen/sIaqcirHfhFJVGbC7BxPNjrb2lxijzV4U/gsanBCKcEvBBNXOG8OGGNWaUsUc3 63hQ== X-Gm-Message-State: ACrzQf1AsxmYOC9XThKxERfR+oMHUDfnr53cp3ldwH0eXg0rOC6suQyF UnmcNBL96wTpgtqmqoczqw0hwg== X-Google-Smtp-Source: AMsMyM5iFdQs5h8Er5ULgff4bJSprImXOkkfnC/FHoRy0rd5gqF55hYL0TbLF6bWECu4B2p/1Vq11w== X-Received: by 2002:a37:c06:0:b0:6e2:b66f:b78f with SMTP id 6-20020a370c06000000b006e2b66fb78fmr1911018qkm.444.1665029974896; Wed, 05 Oct 2022 21:19:34 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::8a16]) by smtp.gmail.com with ESMTPSA id j25-20020ac84419000000b003938a65479bsm1331656qtn.10.2022.10.05.21.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 21:19:34 -0700 (PDT) Date: Thu, 6 Oct 2022 00:19:33 -0400 From: Johannes Weiner To: Yu Zhao Cc: Yosry Ahmed , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Greg Thelen , David Rientjes , Cgroups , Linux-MM Subject: Re: [PATCH v2] mm/vmscan: check references from all memcgs for swapbacked memory Message-ID: References: <20221005173713.1308832-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665029976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4VEh9i/QK9xTQL6ExiIgh+tg9GqBfC90q8qqSObsBU=; b=VBtenbZXdTAlW58/3KRGNCI7PuRV54O8CLru2tXzIYn42xaRqzKdHfKYkXuQTgmmB8EYpE snsVlIySnUProeVs/vFueiA6GJOAC8EXlaUBJ13w/DZZgNzUeS6oxiwx8TDbWi6CmwhAe9 /yLiXqB6ZBye15DBZd0UdBPj4U8xTAY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="sZL9/Juc"; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665029976; a=rsa-sha256; cv=none; b=iAPKrwRNALTrIFFT1s5Nv7RWAdvdD87bQQCsaz1h8x7al5zjyisiYKR9N/Oj2WfErGdKys pHN5xjaaNaHkuj/AiXTtBFSBNSGSy4CSA6xJox0NsmYM+AV3djiQcD4+J2ITKQM0y/dY2w RuJAD8mPwU/EcUgwK1fJiOdEQSGWnRI= X-Rspamd-Queue-Id: B676140019 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="sZL9/Juc"; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: 8eeyy19ccokup1owe6y8qyqfpbmp77nu X-HE-Tag: 1665029975-648977 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 05, 2022 at 03:13:38PM -0600, Yu Zhao wrote: > On Wed, Oct 5, 2022 at 3:02 PM Yosry Ahmed wrote: > > > > On Wed, Oct 5, 2022 at 1:48 PM Yu Zhao wrote: > > > > > > On Wed, Oct 5, 2022 at 11:37 AM Yosry Ahmed wrote: > > > > > > > > During page/folio reclaim, we check if a folio is referenced using > > > > folio_referenced() to avoid reclaiming folios that have been recently > > > > accessed (hot memory). The rationale is that this memory is likely to be > > > > accessed soon, and hence reclaiming it will cause a refault. > > > > > > > > For memcg reclaim, we currently only check accesses to the folio from > > > > processes in the subtree of the target memcg. This behavior was > > > > originally introduced by commit bed7161a519a ("Memory controller: make > > > > page_referenced() cgroup aware") a long time ago. Back then, refaulted > > > > pages would get charged to the memcg of the process that was faulting them > > > > in. It made sense to only consider accesses coming from processes in the > > > > subtree of target_mem_cgroup. If a page was charged to memcg A but only > > > > being accessed by a sibling memcg B, we would reclaim it if memcg A is > > > > is the reclaim target. memcg B can then fault it back in and get charged > > > > for it appropriately. > > > > > > > > Today, this behavior still makes sense for file pages. However, unlike > > > > file pages, when swapbacked pages are refaulted they are charged to the > > > > memcg that was originally charged for them during swapping out. Which > > > > means that if a swapbacked page is charged to memcg A but only used by > > > > memcg B, and we reclaim it from memcg A, it would simply be faulted back > > > > in and charged again to memcg A once memcg B accesses it. In that sense, > > > > accesses from all memcgs matter equally when considering if a swapbacked > > > > page/folio is a viable reclaim target. > > > > > > > > Modify folio_referenced() to always consider accesses from all memcgs if > > > > the folio is swapbacked. > > > > > > It seems to me this change can potentially increase the number of > > > zombie memcgs. Any risk assessment done on this? > > > > Do you mind elaborating the case(s) where this could happen? Is this > > the cgroup v1 case in mem_cgroup_swapout() where we are reclaiming > > from a zombie memcg and swapping out would let us move the charge to > > the parent? > > The scenario is quite straightforward: for a page charged to memcg A > and also actively used by memcg B, if we don't ignore the access from > memcg B, we won't be able to reclaim it after memcg A is deleted. This patch changes the behavior of limit-induced reclaim. There is no limit reclaim on A after it's been deleted. And parental/global reclaim has always recognized outside references.