From: Oscar Salvador <osalvador@suse.de>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>,
Joao Martins <joao.m.martins@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Vlastimil Babka <vbabka@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] hugetlb: freeze allocated pages before creating hugetlb pages
Date: Wed, 21 Sep 2022 05:54:15 +0200 [thread overview]
Message-ID: <YyqK51L65yS4OKye@localhost.localdomain> (raw)
In-Reply-To: <Yyn0BZu1gNHG7pZ7@monkey>
On Tue, Sep 20, 2022 at 10:10:29AM -0700, Mike Kravetz wrote:
> Hi Oscar, thanks for taking a look.
>
> I think you may have missed something in the above comment. For gigantic
> pages, we only freeze pages if NOT demote. In the demote case, pages are
> already frozen.
Yeah.
It got me confused that the link you posted
(https://lore.kernel.org/linux-mm/20210622021423.154662-3-mike.kravetz@oracle.com/)
seemed like an earlier version of what it got into upstream,
and in there there was "demotion" handling.
Having checked the tree it all looks sound.
I will wait for v3.
Thanks Mike!
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2022-09-21 3:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 21:46 Mike Kravetz
2022-09-20 4:02 ` Oscar Salvador
2022-09-20 17:10 ` Mike Kravetz
2022-09-21 3:54 ` Oscar Salvador [this message]
2022-09-21 1:48 ` HORIGUCHI NAOYA(堀口 直也)
2022-09-21 3:17 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyqK51L65yS4OKye@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=joao.m.martins@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox