From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D63CC6FA82 for ; Tue, 20 Sep 2022 07:46:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97C40940009; Tue, 20 Sep 2022 03:46:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92C69940007; Tue, 20 Sep 2022 03:46:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81C23940009; Tue, 20 Sep 2022 03:46:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 748D7940007 for ; Tue, 20 Sep 2022 03:46:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 442391A0C85 for ; Tue, 20 Sep 2022 07:46:58 +0000 (UTC) X-FDA: 79931682516.04.E60FCF6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id E70B9A00D4 for ; Tue, 20 Sep 2022 07:46:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 220DD6251B; Tue, 20 Sep 2022 07:46:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C477C433C1; Tue, 20 Sep 2022 07:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663660016; bh=31LwDD6/RD3aunahOMD2sHT+ewdy1AuM7USPdp3uXHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mTqyeUFod7XeG7uJJHYdHXiuP62G+G/F1DTcdjdKysdwt9RAOgW5ll7YWf/scejs6 zEpCIB2Dax0KLjpoTMMUb0FUXx+xv+eBdOGN6j/70jM3i3rO8mNhKcf97g9FU9GuPb J2dTXXopZbyl8SN4Y3nm4E4u5v8Vtu32qpOsLZMg= Date: Tue, 20 Sep 2022 09:47:24 +0200 From: Greg Kroah-Hartman To: Akinobu Mita Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org, corbet@lwn.net, david@redhat.com, osalvador@suse.de, shuah@kernel.org, Zhao Gongyi , Wei Yongjun , Yicong Yang , "Rafael J. Wysocki" , Alexander Viro , akpm@linux-foundation.org Subject: Re: [PATCH 0/3] fix error when writing negative value to simple attribute files Message-ID: References: <20220919172418.45257-1-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919172418.45257-1-akinobu.mita@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663660018; a=rsa-sha256; cv=none; b=UGz1QCcHV4HmkPaffL+zEv/jiKpRTZI/smdB4GUQNlVqLGmqDt19thBVxyZf890SBbGy3q yu3JmGY7keUvUQ8xwKiO91ZWZUvdvRh61mHjWzWnMJ2dTia4Im6leBz5FDb8Yves4zVNdg ETxOuCN3/FZPV8ySsijpvWzrrtbyDcs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=mTqyeUFo; spf=pass (imf25.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663660018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=If3Ls/Owwi5Io2SdKF5zzGHjWm7fkzHqY9uuV5NqfmI=; b=aKlYLkSiQQ0IpjLV9HRVfdQJ/1BQtdRRhIq3GR58ZLn4W7hL+7k9kEYZeKxHWo7hJj0ETe VIIA0mCUbFBtqJGa0+f8nZenSC8pIJuEjPZn2yZZtDyaM0+88TH20EXMlr1LWgkua9bL4U Dctutem9N/P/H5qk8dr7Inzn9xxvfNA= X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: 5yspg6i6fqbnat8ywzegzxjyrami5afn X-Rspamd-Queue-Id: E70B9A00D4 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=mTqyeUFo; spf=pass (imf25.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1663660017-657464 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 20, 2022 at 02:24:15AM +0900, Akinobu Mita wrote: > The simple attribute files do not accept a negative value since the > commit 488dac0c9237 ("libfs: fix error cast of negative value in > simple_attr_write()"), but some attribute files want to accept > a negative value. > > Akinobu Mita (3): > libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value > lib/notifier-error-inject: fix error when writing -errno to debugfs > file > debugfs: fix error when writing negative value to atomic_t debugfs > file > > .../fault-injection/fault-injection.rst | 10 +++---- > fs/debugfs/file.c | 28 +++++++++++++++---- > fs/libfs.c | 22 +++++++++++++-- > include/linux/debugfs.h | 19 +++++++++++-- > include/linux/fs.h | 12 ++++++-- > lib/notifier-error-inject.c | 2 +- > 6 files changed, 73 insertions(+), 20 deletions(-) Reviewed-by: Greg Kroah-Hartman