From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EC8C6FA90 for ; Mon, 19 Sep 2022 15:01:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 237B06B0073; Mon, 19 Sep 2022 11:01:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E74D6B0074; Mon, 19 Sep 2022 11:01:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AFA480007; Mon, 19 Sep 2022 11:01:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F11CA6B0073 for ; Mon, 19 Sep 2022 11:01:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C0F20C1158 for ; Mon, 19 Sep 2022 15:01:21 +0000 (UTC) X-FDA: 79929148362.05.0ED1929 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id 41A1A400BE for ; Mon, 19 Sep 2022 15:01:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3A6931F74A; Mon, 19 Sep 2022 15:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1663599677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iDQ4TbeBXa/svhW7EfZleIQJqRglXyx7TDIqISE6yyM=; b=QruWER5KDSb+2K6n6HFs/WUurfTkzp5sMxSVkMVrm3lehOt+UtyXCfIE5QlGQ6AB/pQl2H bWA7U17LROAZJt8gYCc6PbCQMojyqbCPedL6IdL4/SbV8YQ9RG2aDhG9+P00umlWIFwU4j oOEFwRn36kywPKURtqAA8cYTgrgtKb4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 02ABA13A96; Mon, 19 Sep 2022 15:01:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SryBOTyEKGOsbgAAMHmgww (envelope-from ); Mon, 19 Sep 2022 15:01:16 +0000 Date: Mon, 19 Sep 2022 17:01:16 +0200 From: Michal Hocko To: Liu Shixin Cc: Andrew Morton , Jonathan Corbet , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH v3] mm/memcontrol: use kstrtobool for swapaccount param parsing Message-ID: References: <20220909145308.f2f61d6992f00ef6977f833b@linux-foundation.org> <20220913071358.1812206-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913071358.1812206-1-liushixin2@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663599678; a=rsa-sha256; cv=none; b=y7+k6Kk7jIBv48ylyKSgfE6Wp6fXY1JG1F8V3yXcKnyrtBRZCSGVwpZqkXnuH+WkjPIrfD K8zE3dWNHqm7SmtNHy9a+fKwWwqGO6HFTtWFHl68O7kr1qyeLc2kDJyd1fGlZ3/FNpol5w Ghfj5MK8WvQhPO/IuF1/YzQsSxphd5E= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=QruWER5K; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663599678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iDQ4TbeBXa/svhW7EfZleIQJqRglXyx7TDIqISE6yyM=; b=7M/opljyQtTBvYZI9J4EMGVn55jy7dbNnUMh5juzTfPEX3eR26oHMhw9Fke07DxeDAkX0l C56unHnSTM0t0U/LM4QXM1A6j0m44CvgIn8d497bO7sIAuW6XvkSPiNWvwCw48IzT6eAaU rVF90NHgjO+vt6+WpEJVAlssSz/cmpI= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=QruWER5K; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: g1gk5hujtx3ffunc7k57bh36ajq9x698 X-Rspamd-Queue-Id: 41A1A400BE X-HE-Tag: 1663599678-340644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 13-09-22 15:13:58, Liu Shixin wrote: > Use kstrtobool which is more powerful to handle all kinds of parameters > like 'Yy1Nn0' or [oO][NnFf] for "on" and "off". the main usefulness is with the code reusability of library functions rather than ad-hoc stuff. > Signed-off-by: Liu Shixin Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 0a1a8a846870..5511c0c120d9 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7434,10 +7434,10 @@ bool mem_cgroup_swap_full(struct folio *folio) > > static int __init setup_swap_account(char *s) > { > - if (!strcmp(s, "1")) > - cgroup_memory_noswap = false; > - else if (!strcmp(s, "0")) > - cgroup_memory_noswap = true; > + bool res; > + > + if (!kstrtobool(s, &res)) > + cgroup_memory_noswap = !res; > return 1; > } > __setup("swapaccount=", setup_swap_account); > -- > 2.25.1 -- Michal Hocko SUSE Labs