From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7420ECAAD8 for ; Fri, 16 Sep 2022 14:46:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52EC38D0005; Fri, 16 Sep 2022 10:46:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DD988D0002; Fri, 16 Sep 2022 10:46:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CC9C8D0005; Fri, 16 Sep 2022 10:46:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2D94F8D0002 for ; Fri, 16 Sep 2022 10:46:13 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0D44EA0EE5 for ; Fri, 16 Sep 2022 14:46:13 +0000 (UTC) X-FDA: 79918223826.26.C6BFDDA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id A56361C00A4 for ; Fri, 16 Sep 2022 14:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=59xaeeSnQHcY+3RA+T0HPunpoN4EGbyW+imfmiP5ukU=; b=QY7ks+FCtzUGLIAOIRCBGs9Kph ns2ivjk1NKYvhbAyO0uT+7YiSglm/Jy9Nl5nKZpUvmou6rxnTO71zRMODh3E5GLlEeqCBCR1WqFaq r+aOFdqPXcN1fA/Hgmxr352j6Uf3ERgKNdAb90AdMKu6awfJtnwbzRPlTOLHrQgybZWJSXRXHaLVy h21nHAynsNuipU9ibOtst3QGn4CyGq8ecCSBVFvgpkrvt4RfVsrhvnbpx91VN+KhZ1peoG9kSE/S6 abfIWFT5dG7axVdTvMaLUox9FGLivdb5c2bcQxzuox1EYiYCD0MPRAh2Y2BWl+aHDgyOOnom4Xku5 k5NCQUrQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZCbX-002ILG-1V; Fri, 16 Sep 2022 14:46:07 +0000 Date: Fri, 16 Sep 2022 15:46:07 +0100 From: Matthew Wilcox To: Kees Cook Cc: Uladzislau Rezki , Andrew Morton , Yu Zhao , dev@der-flo.net, linux-mm@kvack.org, linux-hardening@vger.kernel.org, Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, linux-perf-users@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 3/3] usercopy: Add find_vmap_area_try() to avoid deadlocks Message-ID: References: <20220916135953.1320601-1-keescook@chromium.org> <20220916135953.1320601-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916135953.1320601-4-keescook@chromium.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663339572; a=rsa-sha256; cv=none; b=vQUIp4ilUMiGZDKqjgHqUS+PdrvDwjLROIhJKEc/cqFx8IqU9YVb48l+tykQOOnwA5YFeT veJXEIqOXPefhuIlVWZwvcezU2YBJmIXIEX2gWfBA1zZ/gjOzVIt9JJiO9/m1/2WiHaL3p 0lDYl6QTptZ14E1F0SLLK/wzTknaSZA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QY7ks+FC; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663339572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=59xaeeSnQHcY+3RA+T0HPunpoN4EGbyW+imfmiP5ukU=; b=vif86K7tGnr5TEFBKvMipKH9vk/Tp6yGntFBHDtz16kHoW46imcna3UgJNkFnEonHrUHxT +zoaz+SGfZnq/RiJvCsUex13ECiuTjwE/xdcCDh9fo2bhbCbjwrlt4jhJDEzC5Nxbg6Zdy Lp3a6aE0ZkEvUOkANWv2kvp8ymOlI9U= X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A56361C00A4 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QY7ks+FC; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: zzwe1xotzn545m85wwxyoi7jkrnoyhai X-HE-Tag: 1663339571-354250 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 16, 2022 at 06:59:57AM -0700, Kees Cook wrote: > The check_object_size() checks under CONFIG_HARDENED_USERCOPY need to be > more defensive against running from interrupt context. Use a best-effort > check for VMAP areas when running in interrupt context I had something more like this in mind: diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index 096d48aa3437..2b7c52e76856 100644 --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -215,7 +215,7 @@ extern struct vm_struct *__get_vm_area_caller(unsigned long size, void free_vm_area(struct vm_struct *area); extern struct vm_struct *remove_vm_area(const void *addr); extern struct vm_struct *find_vm_area(const void *addr); -struct vmap_area *find_vmap_area(unsigned long addr); +struct vmap_area *find_vmap_area_try(unsigned long addr); static inline bool is_vm_area_hugepages(const void *addr) { diff --git a/mm/usercopy.c b/mm/usercopy.c index c1ee15a98633..e0fb605c1b38 100644 --- a/mm/usercopy.c +++ b/mm/usercopy.c @@ -173,7 +173,11 @@ static inline void check_heap_object(const void *ptr, unsigned long n, } if (is_vmalloc_addr(ptr)) { - struct vmap_area *area = find_vmap_area(addr); + struct vmap_area *area = find_vmap_area_try(addr); + + /* We may be in NMI context */ + if (area == ERR_PTR(-EAGAIN)) + return; if (!area) usercopy_abort("vmalloc", "no area", to_user, 0, n); diff --git a/mm/vmalloc.c b/mm/vmalloc.c index dd6cdb201195..2ea76cb56d4b 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1829,7 +1829,7 @@ static void free_unmap_vmap_area(struct vmap_area *va) free_vmap_area_noflush(va); } -struct vmap_area *find_vmap_area(unsigned long addr) +static struct vmap_area *find_vmap_area(unsigned long addr) { struct vmap_area *va; @@ -1840,6 +1840,18 @@ struct vmap_area *find_vmap_area(unsigned long addr) return va; } +struct vmap_area *find_vmap_area_try(unsigned long addr) +{ + struct vmap_area *va; + + if (!spin_lock(&vmap_area_lock)) + return ERR_PTR(-EAGAIN); + va = __find_vmap_area(addr, &vmap_area_root); + spin_unlock(&vmap_area_lock); + + return va; +} + /*** Per cpu kva allocator ***/ /*