From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92765ECAAA1 for ; Thu, 15 Sep 2022 04:47:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D1B38D0002; Thu, 15 Sep 2022 00:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9803A8D0001; Thu, 15 Sep 2022 00:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 847D88D0002; Thu, 15 Sep 2022 00:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 76FB38D0001 for ; Thu, 15 Sep 2022 00:47:43 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 537EB16080A for ; Thu, 15 Sep 2022 04:47:43 +0000 (UTC) X-FDA: 79913086806.05.FAFC58B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id D0E4E400A4 for ; Thu, 15 Sep 2022 04:47:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B1AF05C9DD; Thu, 15 Sep 2022 04:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663217261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oyIUsk6sHUPZgVxXFtXQrzKmfZGdQ9Uug4BgQW8pjW4=; b=vNFFy42GO0d+iLV2boTsxMGM5d9oO6WnPxTRuNys6O9RSl5m6QTB8SlF+AjFqnwZXMK9LA Kp1d7/yy/8zo9AzFl879IfV2hzvrRhNmFUi2Ct/P2cQI7AOyFw88Cgh8XnzfLsgXxvGpsD 9HZDIAhplK/Dkx6JvSNzn8I8ZqJuWVo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663217261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oyIUsk6sHUPZgVxXFtXQrzKmfZGdQ9Uug4BgQW8pjW4=; b=45Dr8e/qy9q8kjqsjkPxCa3Y/VdTI8y+qgP5QP59S4crqaCHHiT2W9aBxab+gIx4Hq4s7+ 1N9mRlU4J2QM6RCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C207139B3; Thu, 15 Sep 2022 04:47:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BOKoE22uImPnKwAAMHmgww (envelope-from ); Thu, 15 Sep 2022 04:47:41 +0000 Date: Thu, 15 Sep 2022 06:47:39 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics() Message-ID: References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-5-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909092451.24883-5-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663217262; a=rsa-sha256; cv=none; b=tTcWDgQ7HJL1E0XtC7bVqCkO0jtMSnj0L4VI0ynW58lgjCbVD4/QgMgkdRqiMH6Lrag1t+ XlmLhL3539/9l3EaePsHk2krUy5WsMWlvbGFS6acO4nUGyJiVClx+HHb/+DfARvtwKFMxe rUNHIWua2K+ajt4DG7fOm+kcRSMCv9s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vNFFy42G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="45Dr8e/q"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663217262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oyIUsk6sHUPZgVxXFtXQrzKmfZGdQ9Uug4BgQW8pjW4=; b=WuuY0vCtsBBQu+cjVzNtK8HwxGTtisVCB4XXtd+XOO8UBUR+HucfuVztu48K6vhxX1RHai Z/RZZqYIstmtvHB/maP7iCO+IECGwb9dotud3MjCOb2dtv3yQvbIC4rUCNBZUO1cSxzbp3 10BcKwW/BmDz3dIk4Af8ob0k89DGelU= X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vNFFy42G; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="45Dr8e/q"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam11 X-Stat-Signature: i9eacipmmikmzb8g694hkfew6ryicuzn X-Rspamd-Queue-Id: D0E4E400A4 X-HE-Tag: 1663217262-362822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 09, 2022 at 05:24:39PM +0800, Miaohe Lin wrote: > Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs > are disabled for VM counters"), zone_statistics() is not called with > interrupts disabled. Update the corresponding comment. > > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2deac2fe3372..c81f06d8a4f5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) > > /* > * Update NUMA hit/miss statistics > - * > - * Must be called with interrupts disabled. > */ > static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, > long nr_account) > -- > 2.23.0 > -- Oscar Salvador SUSE Labs