From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101B6ECAAD3 for ; Wed, 14 Sep 2022 16:43:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C37A8D0007; Wed, 14 Sep 2022 12:43:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 672968D0001; Wed, 14 Sep 2022 12:43:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53AE68D0007; Wed, 14 Sep 2022 12:43:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4547F8D0001 for ; Wed, 14 Sep 2022 12:43:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 11A38AAD1A for ; Wed, 14 Sep 2022 16:43:38 +0000 (UTC) X-FDA: 79911262116.25.50AFDB3 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf01.hostedemail.com (Postfix) with ESMTP id B50D64009E for ; Wed, 14 Sep 2022 16:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p0nNQonitIzyxK9JwPGKSpAgLtU8h121WpYGnuj58kg=; b=aDvgresHHEIy2mC6FZyabKavW7 RUHQ+xcPelAm99KjFHK5m6gLwFw/5d4Dji5VY269XgsRLS7gHzd4FFcQGJwiSQgx/FyDSBbz/TXY5 LNQvk5X8mIl5fONDkY1Kzu0a10M+kdhRtVqhKOWzIgWPdTqCsrK0g6XTBKPXrytTcvyfOoa9PudCe djsOtpUkuvKD4CN2Ql6OTqFQVYGsdar8BrH12EGJiRCyY5VXMuU/yrB/Z05TNEXn4h+L5PVXt9gbt ckO+o8/FTgmT1XfFMqPGT4DRZEc0v2Xyj6Yxp4fhj4uGIiRPBc2tXJ5tE6CzcnVmWjdX2NDxT8HJT Xo96LboQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1oYVU2-00GF5R-0c; Wed, 14 Sep 2022 16:43:30 +0000 Date: Wed, 14 Sep 2022 17:43:30 +0100 From: Al Viro To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlbfs: use macro SZ_1K to replace 1024 Message-ID: References: <20220914115723.38271-1-xhao@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220914115723.38271-1-xhao@linux.alibaba.com> ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=aDvgresH; spf=none (imf01.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663173817; a=rsa-sha256; cv=none; b=UzXUfLl2OLrxhDfNMt1ZXmdzGYG/y5gslomLYgccfb1ww6FZmyutLTW+sf8/+I7ntXmNxI alZ7eTJtohKEF4D73leUk/78V4RjluS36SJLfCwD0fScA0pmH1WcNQoRaH1ElxZ6JYWC1n LY9+Glnt/bh7r2AIqpE0A7nUIyLJlmM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663173817; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p0nNQonitIzyxK9JwPGKSpAgLtU8h121WpYGnuj58kg=; b=yZOjRGj8AC1SU0oUSXAnkH9cGofbl/K8OLD0GuLvygL5yE2/p34Dpa3Q97rc3AmlxszkAR +orrFDuAEY34/br8bpUHwjUjsfV4rB3eKfSppkJPXY64ZDJHalj5ICCx5mDqOZeSYfUcri WYqpMIctB5HbmyeCKzlhWfsPJCQCTH8= X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=aDvgresH; spf=none (imf01.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk X-Rspamd-Server: rspam04 X-Stat-Signature: uaecs45rtaz8ndfdzezqxdrb96jaeoz5 X-Rspamd-Queue-Id: B50D64009E X-HE-Tag: 1663173817-507516 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 14, 2022 at 07:57:23PM +0800, Xin Hao wrote: > Using macro SZ_1K in hugetlbfs_show_options() has no any functional > changes, just makes code more readable. Why is it any more readable that way? > Signed-off-by: Xin Hao > --- > fs/hugetlbfs/inode.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index f7a5b5124d8a..9b9784ffe8de 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1023,10 +1023,10 @@ static int hugetlbfs_show_options(struct seq_file *m, struct dentry *root) > if (sbinfo->max_inodes != -1) > seq_printf(m, ",nr_inodes=%lu", sbinfo->max_inodes); > > - hpage_size /= 1024; > + hpage_size /= SZ_1K; > mod = 'K'; > - if (hpage_size >= 1024) { > - hpage_size /= 1024; > + if (hpage_size >= SZ_1K) { > + hpage_size /= SZ_1K; > mod = 'M'; > } > seq_printf(m, ",pagesize=%lu%c", hpage_size, mod); > -- > 2.31.0