From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3056ECAAD3 for ; Wed, 14 Sep 2022 12:47:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 055BB6B0071; Wed, 14 Sep 2022 08:47:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0041B8D0003; Wed, 14 Sep 2022 08:47:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0F2A8D0001; Wed, 14 Sep 2022 08:47:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CF22C6B0071 for ; Wed, 14 Sep 2022 08:47:25 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A6567A0A57 for ; Wed, 14 Sep 2022 12:47:25 +0000 (UTC) X-FDA: 79910666850.14.B358749 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by imf29.hostedemail.com (Postfix) with ESMTP id AAA0F1200E4 for ; Wed, 14 Sep 2022 12:47:23 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VPogkmb_1663159636; Received: from B-P7TQMD6M-0146.lan(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VPogkmb_1663159636) by smtp.aliyun-inc.com; Wed, 14 Sep 2022 20:47:18 +0800 Date: Wed, 14 Sep 2022 20:47:16 +0800 From: Gao Xiang To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton , linux-mm@kvack.org, Josef Bacik , linux-block@vger.kernel.org, Chris Mason , David Sterba , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 4/5] erofs: add manual PSI accounting for the compressed address space Message-ID: Mail-Followup-To: Christoph Hellwig , Jens Axboe , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton , linux-mm@kvack.org, Josef Bacik , linux-block@vger.kernel.org, Chris Mason , David Sterba , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220910065058.3303831-5-hch@lst.de> ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.56 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663159645; a=rsa-sha256; cv=none; b=wa7c/p8WZAPZt9yG62AGoPHpMEstN8iNqx0DreSYIbfa5X9aw+6QLD8cvE4FFZMmnzdWzO EME51bhEIKepW7daSd9GSz6fjAWcIt3RX1HgdedBoFzE3VyGM1ed59S2pgRnBQvFKdwxYo 5H6gjLvQha5B81Nuunbalr7YOrskzxg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663159645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9tSPmWbYDOz3tiyl7VSu9PUSd6rK702bL8+sWIgi/cQ=; b=lHk5fMgWQc6G8Lyakn9lMvUv/tdvxJiEzl4uQoIVtS9Z/MHpu+/7vboNLEfBZauIn7DTcO /w0iL57veM05IW10j4pwOWvIlNBzWIJMePXD+ZYf/QwGIX9IMllYR3ha9mLlU7o4pn492b OUvvXVz29tgn2ERGMQOK1rT+l28L9VI= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AAA0F1200E4 X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.56 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Stat-Signature: 9qkpb86ton33cnhb5py9somnkkdx4ss6 X-HE-Tag: 1663159643-131318 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 10, 2022 at 08:50:57AM +0200, Christoph Hellwig wrote: > erofs uses an additional address space for compressed data read from disk > in addition to the one directly associated with the inode. Reading into > the lower address space is open coded using add_to_page_cache_lru instead > of using the filemap.c helper for page allocation micro-optimizations, > which means it is not covered by the MM PSI annotations for ->read_folio > and ->readahead, so add manual ones instead. > > Signed-off-by: Christoph Hellwig Thanks, Looks good to me (Although I don't have chance to seek more time digging into PSI internal...) Acked-by: Gao Xiang Thanks, Gao Xiang,