From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB43CECAAD8 for ; Wed, 14 Sep 2022 11:47:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 323EB6B0073; Wed, 14 Sep 2022 07:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D3A3940008; Wed, 14 Sep 2022 07:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19B5F940007; Wed, 14 Sep 2022 07:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 08EBF6B0073 for ; Wed, 14 Sep 2022 07:47:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D981180137 for ; Wed, 14 Sep 2022 11:47:42 +0000 (UTC) X-FDA: 79910516364.28.20A0B11 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf03.hostedemail.com (Postfix) with ESMTP id 84E582008C for ; Wed, 14 Sep 2022 11:47:42 +0000 (UTC) Received: by mail-wm1-f52.google.com with SMTP id n35-20020a05600c502300b003b4924c6868so2138880wmr.1 for ; Wed, 14 Sep 2022 04:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=gNw8KIHA1akV3WAIG3mTyAM9FwwfR45IWHpt7v8NJ/D3h8AuPnRAR4Fr9l6bY4Z+l+ yBth3uvMnFhQguK7OFTCFEvob15XvvYYkQE6d5COR/F3dEL9EtIxWGeLd3Ti+huvh2AS UBiZdvfDAe2ffljdOWuaI7kc+tuNrsOiJfuhmKifgcExmxx2CxBo4QEmKguep2CjcgBi Mp80NzZ2QTsl+f2ooHri9mIxl/A9EFiJh010AdjbJ9RG0BFdICtooF0X4b+3YpOiUcxo PiaQDy5iGBG39jXagGb5CLj0tueVl6vvcptlPqe1xaYjbhuQ/GbIW0ZWRwxqmB33Cc8w iz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=FJH89KAjzlHY1oFds7RuU3T7Z8W7anUMLXuR3ofNVjXfKyeb8vcAB6CFg/f/vVi6du D6UQQwrI+vEmyMj6CuHAovtJV0RK2hvu/Q2HrUmBEPKPU6ZKH4w+EMBu9Me2hy8QU2Sv z7A/5iYeBiK0L//yGy4pH+BykJgs2P6LvEvccr1lFAoP6vpPVjk97iLfKZrmC7qjaVKg YxNsV/YmqSTl/mh3qU5aCmbN8TxZ8SgVqlgJpkQoLowFV/K0QwMTr0Qq2QEqPXuF/Sa9 p2ax4xsMH8hbrlSFyCBShDRqrHCXiq4jbNwuviXYYA/XwR+7cDMlxIUQPzeX0EXa8BDW GBtA== X-Gm-Message-State: ACgBeo26qTIW/Fxu6rO/jbtnweGiRu2NJs7+ofqowc/AGxJuijtFPPcO zRE9XFCyGr+XJo/cx8tXKQvkJbDlYwGIp7kG X-Google-Smtp-Source: AA6agR6aSV3jXyKXuS6Lp8ysxs2qtNOBdPRNKt7wbfiui0ec8Ug1sA6v6mmiNfrSa5l3/MzmVoabgw== X-Received: by 2002:a7b:c84c:0:b0:3b3:3faa:10c3 with SMTP id c12-20020a7bc84c000000b003b33faa10c3mr2800743wml.94.1663156061281; Wed, 14 Sep 2022 04:47:41 -0700 (PDT) Received: from localhost ([185.122.133.20]) by smtp.gmail.com with ESMTPSA id n9-20020a5d6609000000b0021e51c039c5sm13066031wru.80.2022.09.14.04.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 04:47:40 -0700 (PDT) Date: Wed, 14 Sep 2022 12:47:40 +0100 From: Johannes Weiner To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] erofs: add manual PSI accounting for the compressed address space Message-ID: References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220910065058.3303831-5-hch@lst.de> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663156062; a=rsa-sha256; cv=none; b=1cyRnDiUroXtV5MyGfhLIpOgZtoNIUL9WlRYi4cRUNJFZbzJtz4BAvyRzzKHhbgzwaM6Lj hrEKEYX3aZEhp96sBcMBCsEwPkcK5MO5n336sfmGrurPlSunCrkVxyhhpWaWJP1KdtvJBX NViGZq381rX6p8o0d+lqOU4UUQn5n30= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=gNw8KIHA; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf03.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663156062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=YbmZmCBiOqZ4tHv2RHNOrpEq6eOBLeah/vut0GzM8OWJc2ngSs5kVmBbSELHspifhuOSDY nBKa0QYSMhemFAWiELV36Oi5jaKLwp5qfxnRnHszh0W7nHh1eVH6st2ftr82MWJCqjguWp 4IFt7cGoLeSyHkmJrX9er9cHym7eAGE= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=gNw8KIHA; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf03.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: 8ypttmqc11etxbqjfqofugn8we9kd793 X-Rspamd-Queue-Id: 84E582008C X-HE-Tag: 1663156062-828615 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 10, 2022 at 08:50:57AM +0200, Christoph Hellwig wrote: > erofs uses an additional address space for compressed data read from disk > in addition to the one directly associated with the inode. Reading into > the lower address space is open coded using add_to_page_cache_lru instead > of using the filemap.c helper for page allocation micro-optimizations, > which means it is not covered by the MM PSI annotations for ->read_folio > and ->readahead, so add manual ones instead. > > Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner