From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 727A0ECAAD3 for ; Fri, 9 Sep 2022 08:19:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AED48000D; Fri, 9 Sep 2022 04:19:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05E9980007; Fri, 9 Sep 2022 04:19:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68398000D; Fri, 9 Sep 2022 04:19:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D6E1F80007 for ; Fri, 9 Sep 2022 04:19:56 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AA4611404C3 for ; Fri, 9 Sep 2022 08:19:56 +0000 (UTC) X-FDA: 79891848792.18.AA761B8 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf03.hostedemail.com (Postfix) with ESMTP id 72CC820071 for ; Fri, 9 Sep 2022 08:19:56 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id bg5-20020a05600c3c8500b003a7b6ae4eb2so3885606wmb.4 for ; Fri, 09 Sep 2022 01:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=M80nuH0as/dyuPHdT1nX8UsUUmqoa+KIEZcH7oWzmKc=; b=dMC9Cl2UatNEGchSPLYQrxGB2PGv4NvywsDD3724PHbU/3oVL2aNcU8+xSWplpjvc4 neJcokyoHrO3vUSbIvx0+1+2VtjUGH73P+zfgHD4BqOmErVnf4CtdoGNCnH5zm0o9vPp Ka6Ah02a91aoNAf5SmayHSVsqtkKlvoyawaUKvbAFFFxlh9Z21k6rl4khDfHPcKVWyJK +BvAzQSljhxVojUxdj/RJDONhnlPdearj0kdbCEyZSlSZ+QApC28ByJ1k8HgxUdnnZ9h UVPT52bUnR6zPH24+su1/TYHfG5wXSBrAqCI6Tb2/Jbi0lGXgxXNY7MBJWDaBax88kqC RZvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=M80nuH0as/dyuPHdT1nX8UsUUmqoa+KIEZcH7oWzmKc=; b=rLvYdpQHTdreLWneKunfGG1xBpYsjKHuUccjLGsEsugbZoUBcwkmtCFH+efMTtin2f a6JB7cLWDUBx422GGLjy2wzs8ZWtyvjj4PLaOyFNFGB1U8yOHlxgrQ8jdEeeS0TgxoiA hSxzC/z5zUeEufsVTUotlRMSh52Jvx1vAxEoUXtIH/BtVSnmFB+Mu7f+2xLSylwmmZXR D17Ur1h+Clni+iVUEtVKkUZGJ4Yg1kCHsrzOlQKUxRAvuvOtfDlrHNk+h8JCmSB4J5BN r8eTD/Ifniiy35E/fqeJ10vsR9RqNtwoEf9AIsKfxYZfgor0pIpvR0DeeGESG7zRyHzt MAiw== X-Gm-Message-State: ACgBeo3XNpNERcnZmS4J0cyaiY1TLAwcwAJpjrRnLAomFxC/EfHw+GEh meOWnE7JML/PO3Nxl0mj8fG/vw== X-Google-Smtp-Source: AA6agR7gJw/MYcMBE4WBJCYjAtalYkIhggEBXED0qnUmijJhSc7OaCgGWT9NwnsXwoUQs+n8htTAWQ== X-Received: by 2002:a05:600c:1c16:b0:3a6:b11:79be with SMTP id j22-20020a05600c1c1600b003a60b1179bemr4491777wms.203.1662711594959; Fri, 09 Sep 2022 01:19:54 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:1d1e:ddcd:2020:36c2]) by smtp.gmail.com with ESMTPSA id p12-20020a5d68cc000000b00228a6ce17b4sm1265073wrw.37.2022.09.09.01.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 01:19:54 -0700 (PDT) Date: Fri, 9 Sep 2022 10:19:47 +0200 From: Marco Elver To: Liu Shixin Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH] mm: kfence: convert to DEFINE_SEQ_ATTRIBUTE Message-ID: References: <20220909083140.3592919-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909083140.3592919-1-liushixin2@huawei.com> User-Agent: Mutt/2.2.6 (2022-06-05) ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=dMC9Cl2U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of elver@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662711596; a=rsa-sha256; cv=none; b=m8QAAeA7+4KcT7LL8SvNlh2O3fWNpHmV9KoowF90Z1Q5d1dIhO24DCOEtLAM11N03SQXQL KAHXdTB2bw/HxdOuGRq5U1wSNQvbqMDDd4xAvqpP5fmfG6Fc2RqhH1h9dvtXF8ySPJFYG1 7Rcc2o4NrFE9IXo46+StHbwho/Q/AO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662711596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M80nuH0as/dyuPHdT1nX8UsUUmqoa+KIEZcH7oWzmKc=; b=tmY8voj3nqbCtVT5BECxd8m0rg2WN/JqdSEBTNoZ634lpEntGQ53iDn6tt6Zxd/DMrMQG2 tSuEhbLXTTBe6y3XtDtYEXIi2PvkEprB3wNSDaf5JeXaf+n/xP+CefH9QreljJYrvagpq4 F271fT5xwoZeggNWTjWsb2r5KBQSIjM= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=dMC9Cl2U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of elver@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=elver@google.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: hidgktmy4sk7zea68h35h19r3nhz798d X-Rspamd-Queue-Id: 72CC820071 X-HE-Tag: 1662711596-206374 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 09, 2022 at 04:31PM +0800, 'Liu Shixin' via kasan-dev wrote: > Use DEFINE_SEQ_ATTRIBUTE helper macro to simplify the code. > > Signed-off-by: Liu Shixin Reviewed-by: Marco Elver Tested-by: Marco Elver > --- > mm/kfence/core.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 8c08ae2101d7..26de62a51665 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -719,24 +719,13 @@ static int show_object(struct seq_file *seq, void *v) > return 0; > } > > -static const struct seq_operations object_seqops = { > +static const struct seq_operations objects_sops = { > .start = start_object, > .next = next_object, > .stop = stop_object, > .show = show_object, > }; > - > -static int open_objects(struct inode *inode, struct file *file) > -{ > - return seq_open(file, &object_seqops); > -} > - > -static const struct file_operations objects_fops = { > - .open = open_objects, > - .read = seq_read, > - .llseek = seq_lseek, > - .release = seq_release, > -}; > +DEFINE_SEQ_ATTRIBUTE(objects); > > static int __init kfence_debugfs_init(void) > { > -- > 2.25.1