From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C24CFECAAA1 for ; Fri, 9 Sep 2022 08:50:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B62E8D0002; Fri, 9 Sep 2022 04:50:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 266238D0001; Fri, 9 Sep 2022 04:50:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12E428D0002; Fri, 9 Sep 2022 04:50:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 01BD38D0001 for ; Fri, 9 Sep 2022 04:50:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C406B80A57 for ; Fri, 9 Sep 2022 08:50:43 +0000 (UTC) X-FDA: 79891926366.18.ED2682E Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf28.hostedemail.com (Postfix) with ESMTP id 6EDEAC00A8 for ; Fri, 9 Sep 2022 08:50:43 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id y127so1051650pfy.5 for ; Fri, 09 Sep 2022 01:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=NQ9A54Z8CrY5jmH+r9/WMnhPXv0fZegOM1GsxMLYivs=; b=fsuGRjKJLd6qfgSCuLuq3Lt6Y3e0yzujg28kWkL6OWPHdyEsFnzJfcfEuOvjIkg4ne tmnlQNnKoUdM46/oEukw1eYmkfgIP8rfXe9G1RJV6K2CN6FamgH+UuGDEYv9LUalZ9Yp WTc0KOpfouqx7byOabYsqG+/ARlXvXQ4Cgjc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=NQ9A54Z8CrY5jmH+r9/WMnhPXv0fZegOM1GsxMLYivs=; b=zZgf5G/lNsZeF4yV8G5bohpyh7a79CmYu+w4cUH9uIjTDBeAk+akA4SQk77/uOoLP5 5Nb5YE6SgK33WEafY47GjHaED65wxJ11u+uXLsQab1cPwh3B9aFdSHKXoeydaEW2FdBI 00V8rLlYpJTPQWNF+VeZnDAt7pdNO67Ha07cV4VagCNVx7W3SMVHBdP7WWTT9u+0XxMS pDItys4yxVAfYxxiZSaHVhbFSagoAuw6NtHrjDTRGpAkfVMszAceAYvGfQj2TbTTE6bN SfVrGJjXstzAimlaTQwdY20LfCWCviUHg/nQrN8kYxfxS9dPScu9l0P26++SxLGhCwMd ILBw== X-Gm-Message-State: ACgBeo3JIweuFnrr6jG6BcU/gwcCzGNKOQI/yqFP6CEWBSLyz2JbHFiT NJVWiAmixXY6/dTpwM3Y3/7gFnZZMgdamw== X-Google-Smtp-Source: AA6agR4eVohPouIdbf94GuuS4F+zf9LrnIGKPWj4kthWqhX2bHCNKX7dTvOXveIWtBGoANoxSvL6YA== X-Received: by 2002:a63:6b05:0:b0:41c:2216:d2b2 with SMTP id g5-20020a636b05000000b0041c2216d2b2mr11697974pgc.118.1662713442523; Fri, 09 Sep 2022 01:50:42 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:48ca:975b:3395:bf]) by smtp.gmail.com with ESMTPSA id b2-20020a636702000000b0041cd2417c66sm796886pgc.18.2022.09.09.01.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 01:50:41 -0700 (PDT) Date: Fri, 9 Sep 2022 17:50:36 +0900 From: Sergey Senozhatsky To: Alexey Romanov Cc: minchan@kernel.org, senozhatsky@chromium.org, ngupta@vflare.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru Subject: Re: [PATCH v1] zsmalloc: use correct types in _first_obj_offset functions Message-ID: References: <20220909083722.85024-1-avromanov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909083722.85024-1-avromanov@sberdevices.ru> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662713443; a=rsa-sha256; cv=none; b=5qF4JUeJVv3Qt0t9jqG1lMGaysWMXvX8N5ZGaazJlqrrpnrepGC/FQJtXFwxmJtqGd6+73 JzHSqDaODoNtEIwfNH0cA3cWv722wLQnwEwhL4WTqe33dbBWdbeRl//HjE7t/5slM+WxKb PUWRjBUnVmSwkp/N8i2aosuHkQkJFyY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fsuGRjKJ; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662713443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NQ9A54Z8CrY5jmH+r9/WMnhPXv0fZegOM1GsxMLYivs=; b=UDMM3JjOm+7BK0RNXdl3xzOaxQmkDgd3t8EB+s1wwqDIlBG0cAhhNCZ/fbtBr2lnQ+QjE6 /3HtbPnkuBWiajYIXXxW1QJ+s3NPIXv2kvZI6jRpFHGh5FAA2sgGzNioQtg9Ftq+rrkLF5 E1ljlG5BfqZKYTtxLlZat7zmva9kFVs= X-Rspamd-Queue-Id: 6EDEAC00A8 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fsuGRjKJ; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 95ro6eyyikjscd41m6crizrbpfpzczox X-HE-Tag: 1662713443-12129 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/09/09 11:37), Alexey Romanov wrote: > Since commit ffedd09fa9b0 > ("zsmalloc: Stop using slab fields in struct page") we are using > page->page_type (unsigned int) field instead of page->units (int) > as first object offset in a subpage of zspage. So get_first_obj_offset() > and set_first_obj_offset() functions should work with unsigned int type. > > Fixes: ffedd09fa9b0 ("zsmalloc: Stop using slab fields in struct page") > Signed-off-by: Alexey Romanov Reviewed-by: Sergey Senozhatsky