From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8196CC54EE9 for ; Fri, 9 Sep 2022 00:26:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF10D8D0003; Thu, 8 Sep 2022 20:26:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E795E8D0001; Thu, 8 Sep 2022 20:26:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF31A8D0003; Thu, 8 Sep 2022 20:26:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BA66A8D0001 for ; Thu, 8 Sep 2022 20:26:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 86C7016031A for ; Fri, 9 Sep 2022 00:26:43 +0000 (UTC) X-FDA: 79890656286.28.A5CDD0D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 266F21C0076 for ; Fri, 9 Sep 2022 00:26:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 022341F74A; Fri, 9 Sep 2022 00:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1662683202; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oLbPE0Wn9MUv5iN+ZKgk87GvaSESM1SLfiGAHxsb7sE=; b=M74DCUqR4Zhu9qqowdIzC0yWGEoMxSvugFKMY6JydiDEwLYyXEwH+g1XQQml9JPnNg32Hz mbxmvw39Sc18R00K1lESxAGd+PBORN4d2sIqExz+Xv3FSi1hhzsEO6JM0hbam1jNxG//tS Ux5JGHlq845aLt0NMqCQKtgNo4wBibM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B9EE413A93; Fri, 9 Sep 2022 00:26:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XX8wLEGIGmO3MAAAMHmgww (envelope-from ); Fri, 09 Sep 2022 00:26:41 +0000 Date: Fri, 9 Sep 2022 02:26:40 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] memcg: extract memcg_vmstats from struct mem_cgroup Message-ID: References: <20220907043537.3457014-1-shakeelb@google.com> <20220907043537.3457014-2-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220907043537.3457014-2-shakeelb@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662683203; a=rsa-sha256; cv=none; b=IbYUYXzJSC3OZHLmjY+cifofqYlYrV0SofDCBC1YxELc3OOcRaS75gGJLyt8+H8kbSzkWI ZWMw/MzkaRhjz2CCM2CyODd5p8Of/ynAHcFncMUUEW49ZRSpi/c9RRnwa5OoFeSeUlTDgN ZgF+1gz+5mot4ONO522W9Kl0G77h16c= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=M74DCUqR; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf18.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662683203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oLbPE0Wn9MUv5iN+ZKgk87GvaSESM1SLfiGAHxsb7sE=; b=Nj3SgH6FMb5zvRJtvflnZOSnwoI5wu4FH1MPRCU860I9BdTu54IgOq3HhwEsZtotQRhatT 0u63eZkA4F82EPpS+f8p2JZMlM1RDD+id6lihGGYisAudpfVdHMQpkE+2X5JUd4VPXDIEA eArdXH/V7EWS5jVq1kQVsLqR1esL0PY= X-Stat-Signature: cn9ukki8me5dgq4xr9ono6spxcsr7fxc X-Rspamd-Queue-Id: 266F21C0076 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=M74DCUqR; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf18.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com X-Rspamd-Server: rspam12 X-HE-Tag: 1662683202-169293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi. On Wed, Sep 07, 2022 at 04:35:35AM +0000, Shakeel Butt wrote: > This is a preparatory patch to reduce the memory overhead of memory > cgroup. The struct memcg_vmstats is the largest object embedded into the > struct mem_cgroup. > This patch extracts struct memcg_vmstats from struct > mem_cgroup to ease the following patches in reducing the size of struct > memcg_vmstats. Is the reason for the extraction just moving things away from the header file? Or is the separate allocation+indirection somehow beneficial wrt, e.g. fragmentation? Thanks, Michal