From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A99C38145 for ; Thu, 8 Sep 2022 18:07:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A3848D0001; Thu, 8 Sep 2022 14:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2518B6B0073; Thu, 8 Sep 2022 14:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11AD58D0001; Thu, 8 Sep 2022 14:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 02CE96B0072 for ; Thu, 8 Sep 2022 14:07:54 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D49CD1A028A for ; Thu, 8 Sep 2022 18:07:53 +0000 (UTC) X-FDA: 79889701626.29.389DAEC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 719C11C0087 for ; Thu, 8 Sep 2022 18:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662660473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XOiQMUC0eykppoN7iesoA/Zyk8TgTL7xhVonR4jGpV8=; b=SO+YhVse3wysCzKhj5ZyUCQAuYReLnzFONZ4c4IXZn72s07EgZqj8oKw+z1BWqtv+nVSGe u6JQxMoN3R6q0LO30ZC+xF9zTLISPKMgReIodIRxNHdM5/5nXvC+6j1WV8Xyt61KoXBxfd QzYZ2cRhNQv70Qm7fUH4eJKDQVxeA30= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-74-69a1AP2iPVKRvCAjbKyOjA-1; Thu, 08 Sep 2022 14:07:51 -0400 X-MC-Unique: 69a1AP2iPVKRvCAjbKyOjA-1 Received: by mail-qk1-f198.google.com with SMTP id bi16-20020a05620a319000b006bc2334be53so15433161qkb.14 for ; Thu, 08 Sep 2022 11:07:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=XOiQMUC0eykppoN7iesoA/Zyk8TgTL7xhVonR4jGpV8=; b=D5AJOkPH7doSm8JvztSxZYG7/V0tabt7Mb+W83gpN6b3uJCcy+Pybn5CkVp+j7FOzi Kd7H9P9jttEy84AFDh9OLuqUJo6vCil2qg9V0GR9umTzB8sxVb35++nyIlKT/YhBsQ9/ /rqvPfkKAuqsdiPSAXigzav8EiSR62uCJqvxUn+YP7/a+Ydah/l2wXqhxlgDgMTqqyQb fEUGfje2JFstGb18xAWIwwfKV7r21hF/JBuhYZDDUXTxYgqlAq+CRTa+Y4FZr0e3a6XY 3yC5bYGT1ojYUJ149kNwqKIHOpMJ9jsmP8APAgEI1TJgg33wQlW2PReGORxu4hUOPJJm S9TA== X-Gm-Message-State: ACgBeo0nNUyP4TeGNgBL6Gl9Tf4qeff9kJglaqMrZkxhlY4XmKw2xy7/ sgRSVtoKNs3cudJinftGwIX5W7JBylDzryERiOQke0zCx4384zQbUllcbi/ULrGqlRzBLMeYv9k ArCmnvm+t2XE= X-Received: by 2002:a05:6214:1cce:b0:474:60f:18f0 with SMTP id g14-20020a0562141cce00b00474060f18f0mr8729240qvd.106.1662660471249; Thu, 08 Sep 2022 11:07:51 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ShN4ZriISlkNihCRT9UneKcyfjn7m2julSQZDvT5VWiC/SRhFP8rVzbu7xyxcMgzdQGFNPA== X-Received: by 2002:a05:6214:1cce:b0:474:60f:18f0 with SMTP id g14-20020a0562141cce00b00474060f18f0mr8729221qvd.106.1662660471044; Thu, 08 Sep 2022 11:07:51 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-35-70-27-3-10.dsl.bell.ca. [70.27.3.10]) by smtp.gmail.com with ESMTPSA id j17-20020a05620a289100b006b5d9a1d326sm18302465qkp.83.2022.09.08.11.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 11:07:50 -0700 (PDT) Date: Thu, 8 Sep 2022 14:07:49 -0400 From: Peter Xu To: James Houghton Cc: Mike Kravetz , Muchun Song , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Jue Wang , Manish Mishra , "Dr . David Alan Gilbert" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 09/26] hugetlb: add hugetlb_hgm_enabled Message-ID: References: <20220624173656.2033256-1-jthoughton@google.com> <20220624173656.2033256-10-jthoughton@google.com> MIME-Version: 1.0 In-Reply-To: <20220624173656.2033256-10-jthoughton@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SO+YhVse; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662660473; a=rsa-sha256; cv=none; b=7dmQO4pkYxnHESv/tN6Pdele7/SMgakY99Q6zXM1siLpe+L2mAjHoxkTFuER3FGVBtEiRl jQmGfZ1v0J5NBNgTJe7ZUoZ62QkdkFAmGWm9i1U+7QrG4/0vaCof0mluTVRY5bkWIdieB/ /9GMNZTJloI+OyYhZIxYGQbnISaZbzk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662660473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XOiQMUC0eykppoN7iesoA/Zyk8TgTL7xhVonR4jGpV8=; b=q98THBgMRORLT6RhOyQrxoZaHT77dO+uufuqoqzvlfVzwI6i02xfZs0+ypv8sGlLJIq9v9 UcRuB1oiLJ6oLz/zjOqdyet2xjtzrLg1/+CoeFmq6MjDuGktNUWurI3Yj/oHPX8U6YQhmU K/PVEFzZ1iv+pdRByDbtuPEaSwIWajc= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 719C11C0087 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SO+YhVse; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: hespx5xwkyo8iiz7shcb1sozpshtm4w3 X-Rspam-User: X-HE-Tag: 1662660473-29313 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 24, 2022 at 05:36:39PM +0000, James Houghton wrote: > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > +bool hugetlb_hgm_enabled(struct vm_area_struct *vma) > +{ > + /* All shared VMAs have HGM enabled. */ > + return vma->vm_flags & VM_SHARED; > +} > +#endif /* CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING */ Another nitpick: suggest to rename this to "hugetlb_***_supported()" (with whatever the new name could be..), as long as it cannot be "disabled". :) -- Peter Xu