From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4EEECAAA1 for ; Tue, 6 Sep 2022 23:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 015C06B0074; Tue, 6 Sep 2022 19:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F06E96B0075; Tue, 6 Sep 2022 19:13:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCEA38D0001; Tue, 6 Sep 2022 19:13:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CD2936B0074 for ; Tue, 6 Sep 2022 19:13:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9B6DF160888 for ; Tue, 6 Sep 2022 23:13:32 +0000 (UTC) X-FDA: 79883214264.30.347F6E5 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf15.hostedemail.com (Postfix) with ESMTP id 3E440A006B for ; Tue, 6 Sep 2022 23:13:32 +0000 (UTC) Received: by mail-qt1-f181.google.com with SMTP id h22so9263217qtu.2 for ; Tue, 06 Sep 2022 16:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date; bh=xnYIwry+S9QmI3kzTAy54hZ+WSydaEv9efoA6mUFDlI=; b=YQj0fOnKOsrK0NQh4pwLBz8h4TpbywPIKdXErYOPUxqBdMEnXnrPeSqZcnNVobqqnv t3yzOeVg7DLJ2o9eBn2Ujf3Y5kZXVZ5Lie/2Lj+72ENAXlkucIk8p5DQ8Lf4OlLAbQEe +P2OYULv6bWTogHvVtQQCQ+ct9rB08VUreDnEjWXTmqHVom9fQgJ7zPbP03oLmyrtz8c Ah5oIIXCfPVCoORYzBEx6tVQx2xHzT5Vi/xi4qznam7W0IJOzBblR2buMJpewKOu39Cb KT/wcNLGms+zGuqNlmsSuIXP3N1Z/AdJa9UjWKzQqVO++Yv0q0M2jerHvaOg7fkJ2NZu 7rFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=xnYIwry+S9QmI3kzTAy54hZ+WSydaEv9efoA6mUFDlI=; b=peTQNp4yyRNuir/YCnM56r88cAjjzMyHUzDZDsmzxdoOGp8VJzjgm2/FEFecZGPjzO 5zmFENERy9WHvsmIS/irFNyl9GrdD6D4dfZXXcL7wieat8o0HotH6EyV4WVhQa/FnEkO UPRho/k87Kw5O59MrqacDgRaG6rSwa655d8lAWYNBpfKgTMPT49j1qAl9EgWxVIt/jHF Odd12NP30BvMy7m3aCaJkupZiUBgTWFH5UMFM/NzAOwolo26fCjSuypwZ6cfJwlZFc6N dH1AxbK/G7gJcCTHRn4up0O5GPeXFZPdz5h93h9spzVKJgwLAQUXZrth5XJ1e9q324vY HsCQ== X-Gm-Message-State: ACgBeo0bOZiZ0L/P231dtmIbvPeOpsdBoAvUvpZmmZNjo/DvXqOLpLBJ y6J3ujInn5lJWmJpc3CiIFmnJw== X-Google-Smtp-Source: AA6agR63wRkPOvdwlh1CTNJzoRf8jK43AOJzOEMqgN2OUNkQ/5M16XOHY6bxHK4WQSN0wyioO7n7xg== X-Received: by 2002:ac8:7f0f:0:b0:344:2fd8:8a66 with SMTP id f15-20020ac87f0f000000b003442fd88a66mr943986qtk.98.1662506011557; Tue, 06 Sep 2022 16:13:31 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id l2-20020ac87242000000b0034455ff76ddsm10530166qtp.34.2022.09.06.16.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 16:13:30 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1oVhl4-008EPf-0N; Tue, 06 Sep 2022 20:13:30 -0300 Date: Tue, 6 Sep 2022 20:13:29 -0300 From: Jason Gunthorpe To: mpenttil@redhat.com, Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com, vbabka@suse.cz Subject: Re: [PATCH v8] mm/hmm/test: use char dev with struct device to get device node Message-ID: References: <20220826050631.25771-1-mpenttil@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220826050631.25771-1-mpenttil@redhat.com> ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=YQj0fOnK; spf=pass (imf15.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.181 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662506012; a=rsa-sha256; cv=none; b=TWxSEnFsHV4Wi32CiFcJeBrbwLbTYXS1QNxGIwkLUqqJBiIChTVjjv4qSlAGJU8jcc96S3 13BL3GfzuEnHyAEm5j9GdbAJh5n1MQ+i55rXSTsEusEl32M6Yv9UW14wsTClFti7JkIX/o cddH8wXWueZ2NvypAiQOxlSjF9Dv8io= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662506012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xnYIwry+S9QmI3kzTAy54hZ+WSydaEv9efoA6mUFDlI=; b=Lp4c2F94hB6RI04F+FBi6+nG+91wCJ8iH2OErkfs2ip+oUeEkftPr0xUW40/0nAv4991R/ nnSXosUG2xHbXRU/pJ4O8cdsEuqR4/T3Bwy9WfmUz9T+AHbv7enCV9XhzWMewlNPPmV4PE Ih9u7ecGbc8DQEBVmzJYgka0NPqIwwE= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3E440A006B X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=YQj0fOnK; spf=pass (imf15.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.181 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none X-Stat-Signature: fjanc466roc8tpzgmm3b7apb36er6h3t X-HE-Tag: 1662506012-311550 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 26, 2022 at 08:06:31AM +0300, mpenttil@redhat.com wrote: > From: Mika Penttilä > > HMM selftests use an in-kernel pseudo device to emulate device > memory. The pseudo device registers a major device range for two or > four pseudo device instances. User space has a script that > reads /proc/devices in order to find the assigned major number, > and sends that to mknod(1), once for each node. > > Change this to properly use cdev and struct device APIs. > > Delete the /proc/devices parsing from the user-space test script, now > that it is unnecessary. > > Also, deleted an unused field in struct dmirror_device: devmem. > > Signed-off-by: Mika Penttilä > Reviewed-by: John Hubbard > Reviewed-by: Christoph Hellwig > Reviewed-by: Jason Gunthorpe > Cc: Alistair Popple > Cc: Ralph Campbell > Cc: Vlastimil Babka Andrew, this looks OK, can you pick it up? Thanks, Jason