From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE53ECAAD5 for ; Tue, 6 Sep 2022 12:08:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB17A8027B; Tue, 6 Sep 2022 08:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C61BF80224; Tue, 6 Sep 2022 08:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B01F88027B; Tue, 6 Sep 2022 08:08:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9EF3B80224 for ; Tue, 6 Sep 2022 08:08:56 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6FC814064B for ; Tue, 6 Sep 2022 12:08:56 +0000 (UTC) X-FDA: 79881539472.08.5515456 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf18.hostedemail.com (Postfix) with ESMTP id DD5301C0068 for ; Tue, 6 Sep 2022 12:08:55 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 78D7E5C010E; Tue, 6 Sep 2022 08:08:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 06 Sep 2022 08:08:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1662466135; x=1662552535; bh=NYqC7vn1O7 NJXEHuHuR2CvnvQzulPRc/85g+mG6DDls=; b=CMPCxayjPd4S28jwM4nZZ8jEIl ZGHrqWU/nJOvHNqs2g7rbB7eFB5A3SDXvn/vO2XGKbfzQpjCAk+eUH3wctgTq0NP iIZENisRlSXC9IXwGDLzARhUGBikQTxGye0eCpHORxNTsNVVyubp3u8LPmgxqd6o thOeXzQzp9j0TivfafRSbiACL5fjz8DDZ8PmCBeCO+7vAzDAOugnbYFLREiUE4FI n0okOcM/LF+0z8jsVtPW0lk46c0es7J+OyXPvAZ+HrInxl7FT0nG7FFDK+Cz1iAQ lSEmgEA4bLg+FFYxYG593EU45oCshOrvScIBfMFV7+F4f+IGqzwVO5hpy2Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662466135; x=1662552535; bh=NYqC7vn1O7NJXEHuHuR2CvnvQzul PRc/85g+mG6DDls=; b=0gp9rPyhbg+NByoYazvwHfOXi/gTfVXMiM5Ilpq4UNjj uOGdnFQ1S47QZ0wVBFwPth9VYR6h+1fbV5D/U2pVo1n2FjL084vcmhYa/SJJ020v qW6L7s5wZO9OtDjEZaB8kvKm2BoWnTNnuEQkflr1NhsdxHNIoPEvhFcka4VBm1bY rvZMPC4ULXbbPOY4u9m2pLux84vOBNt683pxKAPshFhyNpzlq1qpAgJWe+ZiCP2x 3Rp2siz+jDyrZYSUnnN0tzi8CBsgkPV6iHfKxZH5KzDOKXKCVhKRan+j/p4+KSmp 2XrjWeppwlgJ/rhPnNvotfWpazFcrHjeCBwLKRr+rw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelkedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Sep 2022 08:08:54 -0400 (EDT) Date: Tue, 6 Sep 2022 14:08:51 +0200 From: Greg KH To: yee.lee@mediatek.com Cc: linux-kernel@vger.kernel.org, patrick.wang.shcn@gmail.com, stable@vger.kernel.org, Catalin Marinas , Andrew Morton , Matthias Brugger , "open list:MEMORY MANAGEMENT" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH 5.15.y] Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()" Message-ID: References: <20220906070309.18809-1-yee.lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906070309.18809-1-yee.lee@mediatek.com> ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=CMPCxayj; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=0gp9rPyh; spf=pass (imf18.hostedemail.com: domain of greg@kroah.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662466136; a=rsa-sha256; cv=none; b=ftoea3N36UCuY+8dgukW3y5E5K2PjxrLTSjhNJh8TFGE5b6duLR46En59Wu+yn5+zWNgzK UaS2ZkcM3uqkeWE0RW5z86UulFua5YpssOM3/ZZYV3byznNzgoQReEG1ofo1SK2j1Tk7Yr 6Q7E3fE9HBGDpmt1j8Nz8oPPHVOMzNI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662466136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NYqC7vn1O7NJXEHuHuR2CvnvQzulPRc/85g+mG6DDls=; b=PL+t33B1Ps6a1AMpZKqJ6xjX4Z/IF4U1sJfgN7uE6eT5LRrA+XD0oqu9GyvtrJWPOomNp/ J/rYrp2Tl9itgQ/m2uQZTsoshiqEWNz4COVVHfGK+/frmNeezDM+r+0/C0V0IawfXh1qbq OXU6kya0Bc5Y7KCTwlb3G7a7gd9Olfk= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=CMPCxayj; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=0gp9rPyh; spf=pass (imf18.hostedemail.com: domain of greg@kroah.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=none X-Stat-Signature: 15f3kodyk8d8rpmty9i8hry8kgxbmnoi X-Rspamd-Queue-Id: DD5301C0068 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1662466135-542310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 06, 2022 at 03:03:06PM +0800, yee.lee@mediatek.com wrote: > From: Yee Lee > > This reverts commit 23c2d497de21f25898fbea70aeb292ab8acc8c94. > > Commit 23c2d497de21 ("mm: kmemleak: take a full lowmem check in > kmemleak_*_phys()") brought false leak alarms on some archs like arm64 > that does not init pfn boundary in early booting. The final solution > lands on linux-6.0: commit 0c24e061196c ("mm: kmemleak: add rbtree and > store physical address for objects allocated with PA"). > > Revert this commit before linux-6.0. The original issue of invalid PA > can be mitigated by additional check in devicetree. > > The false alarm report is as following: Kmemleak output: (Qemu/arm64) > unreferenced object 0xffff0000c0170a00 (size 128): > comm "swapper/0", pid 1, jiffies 4294892404 (age 126.208s) > hex dump (first 32 bytes): > 62 61 73 65 00 00 00 00 00 00 00 00 00 00 00 00 base............ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<(____ptrval____)>] __kmalloc_track_caller+0x1b0/0x2e4 > [<(____ptrval____)>] kstrdup_const+0x8c/0xc4 > [<(____ptrval____)>] kvasprintf_const+0xbc/0xec > [<(____ptrval____)>] kobject_set_name_vargs+0x58/0xe4 > [<(____ptrval____)>] kobject_add+0x84/0x100 > [<(____ptrval____)>] __of_attach_node_sysfs+0x78/0xec > [<(____ptrval____)>] of_core_init+0x68/0x104 > [<(____ptrval____)>] driver_init+0x28/0x48 > [<(____ptrval____)>] do_basic_setup+0x14/0x28 > [<(____ptrval____)>] kernel_init_freeable+0x110/0x178 > [<(____ptrval____)>] kernel_init+0x20/0x1a0 > [<(____ptrval____)>] ret_from_fork+0x10/0x20 > > This pacth is also applicable to linux-5.17.y/linux-5.18.y/linux-5.19.y > > Cc: > Signed-off-by: Yee Lee > --- > mm/kmemleak.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) What is the git commit id of this change in Linus's tree? And what about older stable trees with this commit in it? thanks, greg k-h