From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B98CC6FA83 for ; Tue, 6 Sep 2022 06:50:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E83EA80256; Tue, 6 Sep 2022 02:49:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E333A80224; Tue, 6 Sep 2022 02:49:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFC0880256; Tue, 6 Sep 2022 02:49:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C06A580224 for ; Tue, 6 Sep 2022 02:49:59 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9795A141424 for ; Tue, 6 Sep 2022 06:49:59 +0000 (UTC) X-FDA: 79880735718.22.9C02F39 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf31.hostedemail.com (Postfix) with ESMTP id 6155420080 for ; Tue, 6 Sep 2022 06:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=29BCCHFkbIUvIEkJ/NT2axzz3sINy2OSORQKgk8fFZA=; b=RxGtQVXb+DTaBvy7bbOri5nYAg Vlb1SRCZHEDoJqUOVg0QSh7MMLoV+F9l+kk4YFZmCrpL4bfLviIzZt86aP7PMF/Sx755TIndJqbn2 vUYABmKgOwA6ZRqXcimL9pgJJ/QYUIHXV5GPYKvCROQx062hhMR+mCOgD1Tn18Us8aW8nvBeVfpny Umh8wtLdaRIrBIAzAa53a/M3auCX0EPffzuBfmut/XNIDXEkkgr0EosOkxeA2x9Vhb+scbIFZ1v0Z GytoOg3FHHaIiluF0aHHfUt7G5QMYlm5BzF4uSByddA4H+J+Sl3785RSLNpiy5z62/QmKRpYIwMBR 0e7+915A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVSP8-00AYGR-D8; Tue, 06 Sep 2022 06:49:50 +0000 Date: Mon, 5 Sep 2022 23:49:50 -0700 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Jens Axboe , Alexander Viro , Miklos Szeredi , Christoph Hellwig , "Darrick J . Wong" , Trond Myklebust , Anna Schumaker , Jan Kara , David Hildenbrand , Logan Gunthorpe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v2 6/7] NFS: direct-io: convert to FOLL_PIN pages Message-ID: References: <20220831041843.973026-1-jhubbard@nvidia.com> <20220831041843.973026-7-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831041843.973026-7-jhubbard@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662446999; a=rsa-sha256; cv=none; b=aOVGiT/cS+4WGD0UQ2/ZTkcyZEt38SEbJei2ovvVX6l9AjK8OKe9gEVj6iHBrLx3F5o1lX 4Y5NVnw9SFHuXW6hSb3njnGS9UMZVpp46hEReDPqnm3cxA5Ycl76jhe0a1O1kWaOlkfsQ5 exPSU6pT8vDztG/GnaCiZXmEbbRC5jA= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RxGtQVXb; spf=none (imf31.hostedemail.com: domain of BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662446999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=29BCCHFkbIUvIEkJ/NT2axzz3sINy2OSORQKgk8fFZA=; b=268dXKaQDpKYHjnB9MGCLP91qxtilTlqSDo8tFzzjBhZdql2zVswPo76xi/uyqdl7Edfyl rBor91Y+eKVyisp9ZeREWTqpwWUuBHaJbIHVMXTwuAgpg38vZooN4vMveocxcE4dS8e+Tv p8nq6fL5K5N+JBy6tIpusmD7oVcwVO8= Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RxGtQVXb; spf=none (imf31.hostedemail.com: domain of BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6155420080 X-Stat-Signature: cb31o6zx3rfqq5osr9rbxz93nigort1m X-Rspam-User: X-HE-Tag: 1662446999-547327 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 09:18:42PM -0700, John Hubbard wrote: static void nfs_direct_release_pages(struct iov_iter *iter, struct page **pages, unsigned int npages) > { > - unsigned int i; > - for (i = 0; i < npages; i++) > - put_page(pages[i]); > + if (user_backed_iter(iter) || iov_iter_is_bvec(iter)) > + dio_w_unpin_user_pages(pages, npages); > + else > + release_pages(pages, npages); Instead of having this magic in all kinds of places, we need a helper that takes the page array, npages and iter->type and does the right thing.